Ubuntu One for Rhythmbox

Merge lp:~rodrigo-moya/rhythmbox-ubuntuone/fix-632735 into lp:rhythmbox-ubuntuone

  1. fix-632735
  2. Merge into trunk
Proposed by Rodrigo Moya
Status: Merged
Approved by: Rodrigo Moya
Approved revision: 86
Merged at revision: 86
Proposed branch: lp:~rodrigo-moya/rhythmbox-ubuntuone/fix-632735
Merge into: lp:rhythmbox-ubuntuone
Diff against target: 10 lines (+0/-1)
1 file modified
umusicstore/MusicStoreWidget.py (+0/-1)
To merge this branch: bzr merge lp:~rodrigo-moya/rhythmbox-ubuntuone/fix-632735
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
John Lenton (community) Approve
Review via email: mp+34984@code.launchpad.net

Commit message

Remove useless call to player.play()

Description of the change

Remove useless call to player.play()

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

boo for api changes. yay for fixes.

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

I want tests. I do. Honestly, we all want.

review: Approve
Revision history for this message
UbuntuOne Tarmac (ubuntuone-tarmac) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these revisions as well.

lp:~rodrigo-moya/rhythmbox-ubuntuone/fix-632735 updated
86. By Rodrigo Moya

Merge from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'umusicstore/MusicStoreWidget.py'
2--- umusicstore/MusicStoreWidget.py 2010-08-31 10:29:19 +0000
3+++ umusicstore/MusicStoreWidget.py 2010-09-14 06:12:50 +0000
4@@ -169,7 +169,6 @@
5 self.shell.props.db.set(entry, rhythmdb.PROP_TITLE, title)
6 player = self.shell.get_player()
7 player.stop()
8- player.play()
9 player.play_entry(entry, self.source)
10 # FIXME delete this entry when it finishes playing. Don't know how yet.
11

Subscribers

People subscribed via source and target branches