Merge lp:~rodrigo-moya/libubuntuone/fix-634384 into lp:libubuntuone

Proposed by Rodrigo Moya
Status: Merged
Approved by: dobey
Approved revision: 106
Merged at revision: 105
Proposed branch: lp:~rodrigo-moya/libubuntuone/fix-634384
Merge into: lp:libubuntuone
Diff against target: 35 lines (+4/-5)
1 file modified
libubuntuone/u1-music-store.c (+4/-5)
To merge this branch: bzr merge lp:~rodrigo-moya/libubuntuone/fix-634384
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
dobey (community) Approve
Review via email: mp+35831@code.launchpad.net

Commit message

Clear tokens when the server tells us about invalid tokens

Description of the change

Clear tokens when the server tells us about invalid tokens

This branch needs lp:~rodrigo-moya/ubuntuone-client/fix-634384

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

Code looks ok to me.

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

+1

review: Approve
Revision history for this message
dobey (dobey) wrote :
Download full text (19.5 KiB)

The attempt to merge lp:~rodrigo-moya/libubuntuone/fix-634384 into lp:libubuntuone failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.67
checking for automake >= 1.6...
  testing automake-1.11... found 1.11.1
checking for libtool >= 1.5...
  testing libtoolize... found 2.2.6b
checking for glib-gettext >= 2.2.0...
  testing glib-gettextize... found 2.25.15
checking for intltool >= 0.30...
  testing intltoolize... found 0.41.1
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.25
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.15
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
Running glib-gettextize... Ignore non-fatal messages.
Copying file mkinstalldirs
Copying file po/Makefile.in.in

Please add the files
  codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
  progtest.m4
from the /aclocal directory to your autoconf macro directory
or directly to your aclocal.m4 file.
You will also need config.guess and config.sub, which you can get from
ftp://ftp.gnu.org/pub/gnu/config/.

Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) ...

Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

This needs the new libsyncdaemon package, which is already accepted

Revision history for this message
dobey (dobey) wrote :
Download full text (19.5 KiB)

The attempt to merge lp:~rodrigo-moya/libubuntuone/fix-634384 into lp:libubuntuone failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.67
checking for automake >= 1.6...
  testing automake-1.11... found 1.11.1
checking for libtool >= 1.5...
  testing libtoolize... found 2.2.6b
checking for glib-gettext >= 2.2.0...
  testing glib-gettextize... found 2.25.15
checking for intltool >= 0.30...
  testing intltoolize... found 0.41.1
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.25
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.15
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
Running glib-gettextize... Ignore non-fatal messages.
Copying file mkinstalldirs
Copying file po/Makefile.in.in

Please add the files
  codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
  progtest.m4
from the /aclocal directory to your autoconf macro directory
or directly to your aclocal.m4 file.
You will also need config.guess and config.sub, which you can get from
ftp://ftp.gnu.org/pub/gnu/config/.

Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) ...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libubuntuone/u1-music-store.c'
2--- libubuntuone/u1-music-store.c 2010-09-15 08:20:48 +0000
3+++ libubuntuone/u1-music-store.c 2010-09-18 08:14:46 +0000
4@@ -354,10 +354,10 @@
5 g_str_has_prefix (uri_args[i], "next")) {
6 this_arg = g_strsplit (uri_args[i], "=", 2);
7
8- url_to_use = g_strdup_printf ("%s%s?returnUrl=%s&forward_on_to_url=%s",
9+ url_to_use = g_strdup_printf ("%s%s?forward_on_to_url=%s",
10 nrrd->music_store->priv->base_url,
11 U1_STORE_URL,
12- this_arg[1], this_arg[1]);
13+ this_arg[1]);
14 g_strfreev (this_arg);
15 break;
16 }
17@@ -370,8 +370,6 @@
18 } else
19 url_to_use = g_strdup_printf ("%s%s", nrrd->music_store->priv->base_url, U1_STORE_URL);
20
21- nrrd->music_store->priv->auth_retries = 0;
22-
23 /* Now sign the URL and load the new page in the view */
24 real_url = oauth_sign_url2 (url_to_use, NULL, OA_HMAC, "GET",
25 oauth_consumer_token, oauth_consumer_secret,
26@@ -544,7 +542,8 @@
27 g_strrstr (parsed_uri->query, "next=") != NULL) {
28 fire_authentication (music_store, request, policy_decision);
29 } else if (g_str_has_prefix (parsed_uri->path, U1_TOKEN_INVALID_URL)) {
30- // FIXME: do we need this from ubuntu-sso? authentication_clear_tokens ();
31+ syncdaemon_authentication_clear_token (syncdaemon_daemon_get_authentication (music_store->priv->syncdaemon));
32+ music_store->priv->auth_retries = 0;
33 fire_authentication (music_store, request, policy_decision);
34 } else if (g_strrstr (parsed_uri->path, "library.aspx") != NULL ||
35 g_str_has_prefix (parsed_uri->path, "/music/store/library")) {

Subscribers

People subscribed via source and target branches