Merge lp:~rodrigo-moya/evolution-couchdb/set-descriptions into lp:evolution-couchdb

[Rodrigo Moya]

[Rodrigo Moya (rodrigo-moya)]

Set the description for email addresses correctly

[Chad Miller (cmiller)]

Looks good.

My only complaint is that I hate integers mapped to true/false, as in the three strcmp()s. "String compare", on equality, returns zero -- which is false in C. I really want a comparison to zero, or at least a comment there explaining what it means.

review: Approve

[dobey (dobey)]

As already suggested, please use comparison against 0 for the strcmp/g_strcasecmp calls. Also, I think you might need to check that the return of e_vcard_attribute_param_get_name is not NULL, if it could ever return NULL, otherwise strcmp() will crash.

review: Needs Fixing

[Rodrigo Moya (rodrigo-moya)]

The use of int as true/false values is just a matter of taste, but changed it anyway. Changed also the strcmp call with g_strcmp0, which deals correctly with NULL values.

review: Abstain

[Guillermo Gonzalez (verterok)]

I wasn't able to build it, after installing some missing dependencies () ./autogen.sh says: "No package 'evolution-plugin' found" and searching in th epackage database the only matches are:
guillermo@gothmog:~/canonical/evolution-couchdb.set-descriptions$ apt-cache search evolution-plugin
evolution-plugins - standard plugins for Evolution
evolution-plugins-experimental - experimental plugins for Evolution

I already have evolution-plugins installed.

review: Abstain

[Guillermo Gonzalez (verterok)]

> I wasn't able to build it, after installing some missing dependencies ()

libcouchdb-glib-dev libebook1.2-dev libedata-book1.2-dev

[Rodrigo Moya (rodrigo-moya)]

>
> > I wasn't able to build it, after installing some missing dependencies ()
>
> libcouchdb-glib-dev libebook1.2-dev libedata-book1.2-dev

evolution-plugin is in evolution-dev package, and then you also need those 3, plus libjson-glib-dev and evolution-data-server-dev. That should be all AFAICS

[Eric Casteleijn (thisfred)]

I can't find couchdb-glib, is this Karmic only (I haven't made the switch yet...)

[Rodrigo Moya (rodrigo-moya)]

> I can't find couchdb-glib, is this Karmic only (I haven't made the switch
> yet...)

you've got jaunty packages of couchdb-glib at the beta PPA -> https://launchpad.net/~ubuntuone/+archive/beta

[Elliot Murphy (statik)]

>
> > I wasn't able to build it, after installing some missing dependencies ()
>
> libcouchdb-glib-dev libebook1.2-dev libedata-book1.2-dev

you all probably already know this, but the easiest way to get the build dependencies is to use
 'apt-get build-dep <package-you-want-tobuild>'. Much easier than manually searching for various dependencies and waiting to see what configure complains about.

[Eric Casteleijn (thisfred)]

Code looks good, and builds. Caveat: My C is rusty at best.

review: Approve

[dobey (dobey)]

review: Approve

=== modified file 'addressbook/e-book-backend-couchdb.c'
--- addressbook/e-book-backend-couchdb.c	2009-07-01 16:03:33 +0000
+++ addressbook/e-book-backend-couchdb.c	2009-07-21 22:21:49 +0000
@@ -161,7 +161,7 @@
 {
 	EContactDate *dt;
 	GSList *list;
-	gint i;
+	GList *attr_list, *al;
 	const char *str;
 	CouchDBDocument *document;
 	EContactAddress *contact_address;
@@ -178,14 +178,44 @@
 
 	/* email addresses */
 	list = NULL;
-	for (i = E_CONTACT_FIRST_EMAIL_ID; i <= E_CONTACT_LAST_EMAIL_ID; i++) {
+	attr_list = e_contact_get_attributes (contact, E_CONTACT_EMAIL);
+	for (al = attr_list; al != NULL; al = al->next) {
 		const gchar *email;
+		EVCardAttribute *attr = (EVCardAttribute *) al->data;
 
-		email = e_contact_get_const (contact, i);
+		email = e_vcard_attribute_get_value (attr);
 		if (email) {
 			CouchDBStructField *sf;
-
-			sf = couchdb_document_contact_email_new (email, /* FIXME */ NULL);
+			GList *params;
+			const gchar *description = NULL;
+
+			params = e_vcard_attribute_get_params (attr);
+			if (params) {
+				GList *pl;
+
+				for (pl = params; pl != NULL; pl = pl->next) {
+					GList *v;
+					EVCardAttributeParam *p = pl->data;
+
+					if (g_strcmp0 (EVC_TYPE, e_vcard_attribute_param_get_name (p)) != 0)
+						continue;
+
+					v = e_vcard_attribute_param_get_values (p);
+					while (v && v->data) {
+						if (g_ascii_strcasecmp ((const gchar *) v->data, "HOME") == 0) {
+							description = "home";
+							break;
+						} else if (g_ascii_strcasecmp ((const gchar *) v->data, "WORK") == 0) {
+							description = "work";
+							break;
+						}
+
+						v = v->next;
+					}
+				}
+			}
+
+			sf = couchdb_document_contact_email_new (email, description);
 			list = g_slist_append (list, sf);
 		}
 	}