Merge lp:~rodrigo-moya/evolution-couchdb/multiple-deletes into lp:evolution-couchdb

[Rodrigo Moya]

[Rodrigo Moya (rodrigo-moya)]

Get the UID from the iterated list item, not from the head of the list, which tries to delete all the time the first ID

[Mark G. Saye (markgsaye)]

Code looks fine, but not easy to test.

review: Approve

[Tim Cole (tcole)]

review: Approve

=== modified file 'addressbook/e-book-backend-couchdb.c'
--- addressbook/e-book-backend-couchdb.c	2009-10-10 09:04:04 +0000
+++ addressbook/e-book-backend-couchdb.c	2009-10-20 11:25:17 +0000
@@ -1083,12 +1083,25 @@
 	for (l = id_list; l != NULL; l = l->next) {
 		CouchDBDocument *document;
 		GError *error = NULL;
-		const gchar *uid = (const gchar *) id_list->data;
+		const gchar *uid = (const gchar *) l->data;
 
 		document = couchdb_document_get (couchdb_backend->couchdb, couchdb_backend->dbname, uid, &error);
 		if (document) {
 			if (couchdb_document_delete (document, &error))
 				deleted_ids = g_list_append (deleted_ids, (gpointer) uid);
+			else {
+				if (error != NULL) {
+					g_debug ("Error deleting document: %s", error->message);
+					g_error_free (error);
+				} else
+					g_debug ("Error deleting document");
+			}
+		} else {
+			if (error != NULL) {
+				g_debug ("Error getting document: %s", error->message);
+				g_error_free (error);
+			} else
+				g_debug ("Error getting document");
 		}
 	}