evolution-couchdb

Merge lp:~rodrigo-moya/evolution-couchdb/kenvandine-doesnt-like-localhost into lp:evolution-couchdb

  1. kenvandine-doesnt-like-localhost
  2. Merge into trunk
Proposed by Rodrigo Moya
Status: Merged
Approved by: Rodrigo Moya
Approved revision: 60
Merge reported by: Rodrigo Moya
Merged at revision: not available
Proposed branch: lp:~rodrigo-moya/evolution-couchdb/kenvandine-doesnt-like-localhost
Merge into: lp:evolution-couchdb
Diff against target: None lines
To merge this branch: bzr merge lp:~rodrigo-moya/evolution-couchdb/kenvandine-doesnt-like-localhost
Reviewer Review Type Date Requested Status
Ken VanDine (community) Approve
Review via email: mp+10662@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Use 127.0.0.1 instead of localhost, since that resolves to :1 in machines with IPv6 enabled, and couchdb listens only on 127.0.0.1

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good, worked for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addressbook/e-book-backend-couchdb.c'
2--- addressbook/e-book-backend-couchdb.c 2009-08-22 10:00:21 +0000
3+++ addressbook/e-book-backend-couchdb.c 2009-08-25 15:19:27 +0000
4@@ -639,7 +639,7 @@
5 dbus_g_connection_unref (bus);
6
7 if (success)
8- uri = g_strdup_printf ("http://localhost:%d", port);
9+ uri = g_strdup_printf ("http://127.0.0.1:%d", port);
10 else {
11 g_warning ("Couldn't get port for desktopcouch: %s", error->message);
12 g_error_free (error);
13@@ -650,7 +650,7 @@
14 } else if (g_strcmp0 (property, "remote") == 0)
15 uri = g_strdup_printf ("http://%s", e_source_get_property (source, "couchdb_remote_server"));
16 else
17- uri = g_strdup ("http://localhost:5984");
18+ uri = g_strdup ("http://127.0.0.1:5984");
19
20 if (! (couchdb_backend->couchdb = couchdb_new (uri))) {
21 g_free (uri);

Subscribers

People subscribed via source and target branches