Merge lp:~rodrigo-moya/couchdb-glib/no-revision-in-auth-header into lp:couchdb-glib

Proposed by Rodrigo Moya on 2009-10-06
Status: Merged
Approved by: Tim Cole on 2009-10-06
Approved revision: 98
Merge reported by: Rodrigo Moya
Merged at revision: not available
Proposed branch: lp:~rodrigo-moya/couchdb-glib/no-revision-in-auth-header
Merge into: lp:couchdb-glib
Diff against target: 25 lines
2 files modified
couchdb-glib/couchdb-document.c (+1/-0)
couchdb-glib/utils.c (+3/-0)
To merge this branch: bzr merge lp:~rodrigo-moya/couchdb-glib/no-revision-in-auth-header
Reviewer Review Type Date Requested Status
Tim Cole (community) Approve on 2009-10-06
Guillermo Gonzalez 2009-10-06 Approve on 2009-10-06
Review via email: mp+12927@code.launchpad.net
To post a comment you must log in.
Rodrigo Moya (rodrigo-moya) wrote :

Don't include non-OAuth URL parameters in OAuth header

review: Approve
Tim Cole (tcole) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'couchdb-glib/couchdb-document.c'
2--- couchdb-glib/couchdb-document.c 2009-09-09 12:30:29 +0000
3+++ couchdb-glib/couchdb-document.c 2009-10-06 15:05:21 +0000
4@@ -178,6 +178,7 @@
5 parser = send_message_and_parse (document->couchdb, SOUP_METHOD_DELETE, url, NULL, error);
6 if (parser) {
7 g_object_unref (G_OBJECT (parser));
8+ result = TRUE;
9
10 g_signal_emit_by_name (document->couchdb, "document_deleted", document->dbname, id);
11 }
12
13=== modified file 'couchdb-glib/utils.c'
14--- couchdb-glib/utils.c 2009-09-09 14:53:00 +0000
15+++ couchdb-glib/utils.c 2009-10-06 15:05:21 +0000
16@@ -104,6 +104,9 @@
17 for (i = 0; params[i] != NULL; i++) {
18 gchar **url_param;
19
20+ if (!g_str_has_prefix (params[i], "oauth_"))
21+ continue;
22+
23 #ifdef DEBUG_OAUTH
24 g_debug ("%s\n", params[i]);
25 #endif

Subscribers

People subscribed via source and target branches