Merge lp:~rockstar/ubuntuone-ios-music/fix-warnings into lp:ubuntuone-ios-music
Proposed by
Paul Hummer
Status: | Merged |
---|---|
Approved by: | Zachery Bir |
Approved revision: | 221 |
Merged at revision: | 222 |
Proposed branch: | lp:~rockstar/ubuntuone-ios-music/fix-warnings |
Merge into: | lp:ubuntuone-ios-music |
Diff against target: |
79 lines (+10/-16) 4 files modified
utilities/U1HTTPRequest.h (+0/-4) utilities/U1HTTPRequest.m (+6/-3) utilities/U1HTTPResponse.h (+0/-4) utilities/U1HTTPResponse.m (+4/-5) |
To merge this branch: | bzr merge lp:~rockstar/ubuntuone-ios-music/fix-warnings |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zachery Bir | Approve | ||
Review via email: mp+111910@code.launchpad.net |
Commit message
Remove warnings.
Description of the change
Very superficial, meaningless branch. I killed all the build warnings. It's basically a "6 of one, half a dozen of the other" situation. I'm of the opinion that explicit is always better than implicit, but there might be some idiomatic Obj-C thing that I don't know about.
Feel free to reject this branch. I'm of the opinion that warnings should always be heeded, and we should keep the build clean if at all possible, but I'm the junior here. :)
To post a comment you must log in.
Yeah, allowing for the LLVM changes just opens another can of worms (and warnings in code we don't own (and don't want to)).
I'm +1 for this branch, though.