Merge lp:~rockstar/phazr/images into lp:phazr

[Paul Hummer]

Add images for okay, cancel, and close

This branch adds the images and css for Okay, Cancel, and Close. These images are a bit dark, and probably need some work (they didn't shrink from their original 128x128 size very well). I wanted to stick them in, and if we have time to come back and fix them before release, we can do that.

[Deryck Hodge (deryck)]

I'm ok with this. I agree that the images could be touched up perhaps. And there's some weird spacing between the cancel and save icons when sat beside each other. But as a first pass to cleanup later, I think it's fine.

At some point, we should add docs about how to easily re-skin or use different images. Images are such a personal issue. I like these, but not every project will want them.

Cheers,
deryck

review: Approve (code)

[Paul Hummer (rockstar)]

The prerequisite lp:~rockstar/phazr/close-overlay has not yet been merged into lp:phazr.

[Paul Hummer (rockstar)]

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

=== added directory 'src/css/images'
=== added file 'src/css/images/cancel.png'
Binary files src/css/images/cancel.png	1970-01-01 00:00:00 +0000 and src/css/images/cancel.png	2011-04-05 03:50:53 +0000 differ
=== added file 'src/css/images/close.png'
Binary files src/css/images/close.png	1970-01-01 00:00:00 +0000 and src/css/images/close.png	2011-04-05 03:50:53 +0000 differ
=== added file 'src/css/images/okay.png'
Binary files src/css/images/okay.png	1970-01-01 00:00:00 +0000 and src/css/images/okay.png	2011-04-05 03:50:53 +0000 differ
=== modified file 'src/css/phazr.css'
--- src/css/phazr.css	2011-03-22 04:38:18 +0000
+++ src/css/phazr.css	2011-04-05 03:50:53 +0000
@@ -36,9 +36,24 @@
     text-align: right;
 }
 div.yui3-overlay div.yui3-overlay-controls a {
-    margin-left: 4px;
+    display: inline-block;
+    height: 32px;
+    width: 32px;
+}
+div.yui3-overlay div.yui3-overlay-controls a#save-control {
+    background: url('images/okay.png') 0 0 no-repeat;
+}
+div.yui3-overlay div.yui3-overlay-controls a#cancel-control {
+    background: url('images/cancel.png') 0 0 no-repeat;
 }
 div.yui3-overlay div.yui3-overlay-close {
     float: right;
     margin: 5px 5px 0 0;
 }
+div.yui3-overlay div.yui3-overlay-close a.yui3-overlay-close-button {
+    background: url('images/close.png') 0 0 no-repeat;
+    cursor: pointer;
+    display: inline-block;
+    height: 20px;
+    width: 20px;
+}

=== modified file 'src/js/formplugin/formplugin.js'
--- src/js/formplugin/formplugin.js	2011-03-21 20:14:02 +0000
+++ src/js/formplugin/formplugin.js	2011-04-05 03:50:53 +0000
@@ -16,9 +16,9 @@
         renderUI: function() {
             var host = this.get('host'),
                 saveButton = Y.Node.create(
-                    '<a class="clickable" id="save-control">Save</a>'),
+                    '<a class="clickable" id="save-control"></a>'),
                 cancelButton = Y.Node.create(
-                    '<a class="clickable" id="cancel-control">Cancel</a>'),
+                    '<a class="clickable" id="cancel-control"></a>'),
                 controls = Y.Node.create('<div></div>');
             controls.addClass(host.getClassName() + '-controls');
             controls.appendChild(saveButton);

=== modified file 'src/js/modalplugin/modalplugin.js'
--- src/js/modalplugin/modalplugin.js	2011-03-22 04:36:17 +0000
+++ src/js/modalplugin/modalplugin.js	2011-04-05 03:50:53 +0000
@@ -7,7 +7,7 @@
         },
         renderUI: function() {
             var host = this.get('host'),
-                closeButton = Y.Node.create('<a>close</a>'),
+                closeButton = Y.Node.create('<a></a>'),
                 closeContainer = Y.Node.create('<div></div>'),
                 className = host.getClassName();
             closeButton.addClass(className + '-close-button');