LAZR Javascript Library

Merge lp:~rockstar/lazr-js/overlay-width into lp:lazr-js

  1. overlay-width
  2. Merge into toolchain
Proposed by Paul Hummer on 2010-08-24
Status: Merged
Merged at revision: 181
Proposed branch: lp:~rockstar/lazr-js/overlay-width
Merge into: lp:lazr-js
Diff against target: 52 lines (+6/-6)
1 file modified
src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css (+6/-6)
To merge this branch: bzr merge lp:~rockstar/lazr-js/overlay-width
Reviewer Review Type Date Requested Status
Tim Penhey (community) 2010-08-24 Approve on 2010-08-24
Review via email: mp+33478@code.launchpad.net

Description of the Change

This branch fixes two bugs with the overlay - first, the overlay can now grow depending on its contents, and second, the overlay doesn't enforce a font-family anymore.

I figured I would fix these two bugs before I work through the wizard widget.

To post a comment you must log in.
Tim Penhey (thumper) wrote :

Looks fine to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css'
2--- src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css 2010-05-07 17:40:07 +0000
3+++ src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css 2010-08-24 01:41:42 +0000
4@@ -8,13 +8,13 @@
5 padding: 0;
6 margin: 0;
7 left: 405px;
8- width: 402px;
9+ min-width: 40%;
10 }
11
12 .yui3-pretty-overlay #yui3-pretty-overlay-modal {
13 margin: 7px 0px;
14 padding: 0;
15- font: normal normal 12px/normal sans-serif;
16+ font: normal normal 12px/normal;
17 color: #484848;
18 background: #fff;
19 }
20@@ -22,7 +22,7 @@
21 .yui3-pretty-overlay .close {
22 margin: 0;
23 padding: 0 5px;
24- font: normal normal 10px/normal sans-serif;
25+ font: normal normal 10px/normal;
26 color: #484848;
27 background: #fff;
28 }
29@@ -42,7 +42,7 @@
30
31 .yui3-pretty-overlay #yui3-pretty-overlay-modal h1,
32 .yui3-pretty-overlay #yui3-pretty-overlay-modal h2 {
33- font: normal normal 18px/normal sans-serif;
34+ font: normal normal 18px/normal;
35 color: #000;
36 text-indent: 15px;
37 margin: 0;
38@@ -51,13 +51,13 @@
39
40 .yui3-pretty-overlay #yui3-pretty-overlay-modal h2 {
41 height: 30px;
42- font: normal normal 18px sans-serif;
43+ font: normal normal 18px;
44 color: #000;
45 }
46
47 .yui3-pretty-overlay #yui3-pretty-overlay-modal .steps h2 {
48 height: 30px;
49- font: normal normal 14px/30px sans-serif;
50+ font: normal normal 14px/30px;
51 color: #666;
52 }
53

Subscribers

People subscribed via source and target branches