Merge lp:~rockstar/lazr-js/bzr-revno-version into lp:lazr-js

Proposed by Paul Hummer
Status: Merged
Approved by: Martin Albisetti
Approved revision: 185
Merged at revision: 185
Proposed branch: lp:~rockstar/lazr-js/bzr-revno-version
Merge into: lp:lazr-js
Diff against target: 16 lines (+3/-1)
1 file modified
setup.py (+3/-1)
To merge this branch: bzr merge lp:~rockstar/lazr-js/bzr-revno-version
Reviewer Review Type Date Requested Status
Martin Albisetti (community) Approve
Review via email: mp+35008@code.launchpad.net

Description of the change

For making sdists, the branch revno really should be part of the version in trunk.

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) wrote :

<beuno> rockstar, doesn't this mean that lazr-js is indistributable as a tarball? (ie, not in a branch)
<rockstar> beuno, when we release, we'll bump the version and remove that code.
<rockstar> beuno, as DEV though, revnos make sense.
<rockstar> (I have to do this everytime I bump the launchpad lazr-js version)
<beuno> rockstar, I agree. I'll +1 if you add a comment :)

Revision history for this message
Martin Albisetti (beuno) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2010-08-23 20:01:04 +0000
3+++ setup.py 2010-09-09 17:25:58 +0000
4@@ -3,9 +3,11 @@
5 import distribute_setup
6 distribute_setup.use_setuptools()
7
8+from bzrlib import branch
9 from setuptools import setup
10
11-__version__ = '1.5DEV'
12+revno = branch.Branch.open('.').revno()
13+__version__ = '1.5DEVr%s' % (revno)
14
15
16 setup(

Subscribers

People subscribed via source and target branches