Launchpad itself

Merge lp:~rockstar/launchpad/recipe-build-table into lp:launchpad

  1. recipe-build-table
  2. Merge into devel
Proposed by Paul Hummer on 2010-08-05
Status: Merged
Approved by: Tim Penhey on 2010-08-05
Approved revision: no longer in the source branch.
Merged at revision: 11309
Proposed branch: lp:~rockstar/launchpad/recipe-build-table
Merge into: lp:launchpad
Diff against target: 45 lines (+2/-4)
3 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+0/-2)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+1/-1)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+1/-1)
To merge this branch: bzr merge lp:~rockstar/launchpad/recipe-build-table
Reviewer Review Type Date Requested Status
Tim Penhey (community) 2010-08-05 Approve on 2010-08-05
Review via email: mp+31882@code.launchpad.net

Description of the Change

This branch is small, and fixes bug #604901 - the recipe table had it's "narrow-listing" class removed and the order in which the builds were listing reversed.

To post a comment you must log in.
Tim Penhey (thumper) wrote :

So to confirm the ordering, newest builds are at the top?

review: Needs Information
Paul Hummer (rockstar) wrote :

Yes, as opposed to being on the bottom, as they were before.

Tim Penhey (thumper) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/browser/sourcepackagerecipe.py'
2--- lib/lp/code/browser/sourcepackagerecipe.py 2010-08-02 02:36:32 +0000
3+++ lib/lp/code/browser/sourcepackagerecipe.py 2010-08-05 20:24:51 +0000
4@@ -166,7 +166,6 @@
5 builds.append(build)
6 if len(builds) >= 5:
7 break
8- builds.reverse()
9 return builds
10
11
12@@ -382,7 +381,6 @@
13 return
14
15
16-
17 distros = data.pop('distros')
18 if distros != self.context.distroseries:
19 self.context.distroseries.clear()
20
21=== modified file 'lib/lp/code/browser/tests/test_sourcepackagerecipe.py'
22--- lib/lp/code/browser/tests/test_sourcepackagerecipe.py 2010-07-31 14:46:11 +0000
23+++ lib/lp/code/browser/tests/test_sourcepackagerecipe.py 2010-08-05 20:24:51 +0000
24@@ -610,7 +610,7 @@
25 set_day(build5, 12)
26 set_day(build6, 11)
27 self.assertEqual(
28- [build5, build4, build3, build2, build1], view.builds)
29+ [build1, build2, build3, build4, build5], view.builds)
30
31 def test_request_builds_page(self):
32 """Ensure the +request-builds page is sane."""
33
34=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
35--- lib/lp/code/templates/sourcepackagerecipe-index.pt 2010-07-21 14:01:51 +0000
36+++ lib/lp/code/templates/sourcepackagerecipe-index.pt 2010-08-05 20:24:51 +0000
37@@ -82,7 +82,7 @@
38 <div class="yui-g">
39 <div class="portlet">
40 <h2>Build records</h2>
41- <table class="listing narrow-listing" style='margin-bottom: 1em;'>
42+ <table class="listing" style='margin-bottom: 1em;'>
43 <thead>
44 <tr>
45 <th>Status</th>