Merge lp:~rockstar/launchpad/junk-recipe-listings into lp:launchpad
Proposed by
Paul Hummer
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11237 | ||||
Proposed branch: | lp:~rockstar/launchpad/junk-recipe-listings | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
64 lines (+4/-14) 3 files modified
lib/lp/code/browser/sourcepackagerecipebuild.py (+2/-11) lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py (+1/-2) lib/lp/code/templates/sourcepackagerecipe-listing.pt (+1/-1) |
||||
To merge this branch: | bzr merge lp:~rockstar/launchpad/junk-recipe-listings | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Review via email: mp+30990@code.launchpad.net |
Description of the change
This branch was actually supposed to fix another bug, so the name is misleading. The actual fix in here was intended to be a driveby fix. However, I apparently had already fixed that other bug and never marked it Fix Committed. I figure this branch is still got some good in it, so I'll propose it for merging.
I was using zope.schema.Text for the Rescore field in the rescore builds. Apparently that means "use a TextArea" which is totally braindead. I swapped it to zope.schema.Int, which meant that I could completely remove the validate method from that view, because the type already makes the same check.
No lint.
To post a comment you must log in.