Merge lp:~rockstar/launchpad/js-no-bigger-than-512k into lp:launchpad

[Paul Hummer]

[Paul Hummer (rockstar)]

Hi there-

  This branch adds a real quick script to assert that the generated javascript
doesn't exceed 512K. If it does, Windmill does odd things. I'm still
investigating why, but this is a stopgap so we don't waste so much time trying
to figure out why windmill tests are failing spuriously.

Cheers,
Paul

[Brad Crittenden (bac)]

Looks great Paul with the following three changes we discussed on IRC:

1) Add #!/usr/bin/python2.5 to the script
2) Update copyright year to 2010
3) MAX_FILE_SIZE = 512 * 1024

Thanks for this script -- it'll certainly help us until we can figure out the root cause of the JS problem.

review: Approve (code)

=== modified file 'Makefile'
--- Makefile	2010-02-19 18:45:21 +0000
+++ Makefile	2010-02-19 22:38:24 +0000
@@ -137,6 +137,7 @@
 		-b $(LP_BUILT_JS_ROOT) \
 		$(shell $(HERE)/utilities/yui-deps.py) \
 		lib/canonical/launchpad/icing/lazr/build/lazr.js
+	${SHHH} bin/jssize
 
 eggs:
 	# Usually this is linked via link-external-sourcecode, but in

=== modified file 'buildout.cfg'
--- buildout.cfg	2009-12-14 21:55:56 +0000
+++ buildout.cfg	2010-02-19 22:38:24 +0000
@@ -75,6 +75,7 @@
     jsbuild=lazr.js.build:main
     jslint=lazr.js.jslint:main
     tracereport=zc.zservertracelog.tracereport:main
+    jssize=lp.scripts.utilities.jssize:main
 
 [iharness]
 recipe = zc.recipe.egg

=== added file 'lib/lp/scripts/utilities/jssize.py'
--- lib/lp/scripts/utilities/jssize.py	1970-01-01 00:00:00 +0000
+++ lib/lp/scripts/utilities/jssize.py	2010-02-19 22:38:24 +0000
@@ -0,0 +1,21 @@
+#!/usr/bin/env python2.5
+# Copyright 2010 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Script to check the size of the generated javascript.
+
+This script tests to ensure optimized javascript never gets over a certain
+size.  If it gets too big, Windmill has issues. This is a hack until we can
+find out why Windmill has such issues.
+"""
+
+import os
+
+FILE_NAME = 'lib/canonical/launchpad/icing/build/launchpad.js'
+MAX_FILE_SIZE = 512 * 1024
+
+def main():
+    size = os.path.getsize(FILE_NAME)
+    if size > MAX_FILE_SIZE:
+        raise Exception(
+            'launchpad.js is greater than %d bytes' % MAX_FILE_SIZE)