Merge lp:~rockstar/launchpad/build-farm-job-constraint into lp:launchpad/db-devel

Proposed by Paul Hummer on 2010-09-21
Status: Merged
Approved by: Aaron Bentley on 2010-09-22
Approved revision: no longer in the source branch.
Merged at revision: 9817
Proposed branch: lp:~rockstar/launchpad/build-farm-job-constraint
Merge into: lp:launchpad/db-devel
Diff against target: 12 lines (+8/-0)
1 file modified
database/schema/patch-2208-16-0.sql (+8/-0)
To merge this branch: bzr merge lp:~rockstar/launchpad/build-farm-job-constraint
Reviewer Review Type Date Requested Status
Aaron Bentley (community) 2010-09-21 Approve on 2010-09-22
Stuart Bishop db 2010-09-21 Approve on 2010-09-22
Robert Collins db 2010-09-21 Pending
Review via email:

Description of the change

This branch doesn't actually FIX bug #628427, but it fixes an issue there so that the next time the bug rears its ugly head, it rears it as a database integrity issue instead of waiting for a read to happen.

Basically, the interface and database model said sourcepackage_recipe_build couldn't be NULL, but the database was quite fine with it.

Aaron and I suspect the bug originally was because someone was futzing with the database. I've had the LOSAs run the query to make sure that this patch will apply (making sure there aren't any SourcePackageRecipeBuildJob rows with a NULL sourcepackage_recipe_build).

To post a comment you must log in.
Stuart Bishop (stub) wrote :

Fine. patch-2208-16-0.sql

review: Approve (db)
Aaron Bentley (abentley) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2208-16-0.sql'
2--- database/schema/patch-2208-16-0.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2208-16-0.sql 2010-09-22 16:22:47 +0000
4@@ -0,0 +1,8 @@
5+-- Copyright 2010 Canonical Ltd. This software is licensed under the
6+-- GNU Affero General Public License version 3 (see the file LICENSE).
7+SET client_min_messages=ERROR;
9+ALTER TABLE SourcePackageRecipeBuildJob
10+ ALTER COLUMN sourcepackage_recipe_build SET NOT NULL;
12+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 16, 0);


People subscribed via source and target branches

to status/vote changes: