Merge lp:~rockstar/entertainer/no-open-excepts into lp:entertainer

[Paul Hummer]

Specified the music metadata exception catching to not catch every different type of exception.

[Paul Hummer (rockstar)]

This branch fixes an issue that should have been addressed before Bug 366368 was fixed in Samuel's branch. Basically, in the fix, the branch introduced an open except block. This bug happened because I removed all open excepts to make bugs that were hidden revealed. I made the except more specific, and added a comment to explain WHY the except would happen (which should probably happen when the except is kind of, like a ValueError in this case).

[Matt Layman (mblayman)]

make check passes to the level expected (failing weather test unrelated to this branch).

Assuming that this was the only exception type that EyeD3 was throwing, I'm okay with this minor change.

review: Approve

=== modified file 'entertainerlib/backend/components/mediacache/music_cache.py'
--- entertainerlib/backend/components/mediacache/music_cache.py	2009-04-24 20:41:49 +0000
+++ entertainerlib/backend/components/mediacache/music_cache.py	2009-05-06 01:05:57 +0000
@@ -253,7 +253,7 @@
         try:
             mp3_file = eyeD3.Mp3AudioFile(filename, eyeD3.ID3_ANY_VERSION)
             tags = mp3_file.getTag()
-        except:
+        except ValueError: # Tags are corrupt
             self.logger.error("Couldn't read ID3tags: " + filename)
             return