Merge lp:~rockstar/entertainer/more-pylint-fun into lp:entertainer

[Paul Hummer]

[Paul Hummer (rockstar)]

This branch enables more pylint warnings, mostly concerning how exceptions are
handled. The big thing is that catchall exceptions like...

try:
    do_stuff()
except:
    pass

...is no longer allowed. Also, doing a flat "pass" right after an exception is
also not allowed. And just doing "except Exception" is also not good (it's the
same as not specifying an exception at all).

The other pylint error fixed is cases where the inherited class doesn't
implement the same method signature as its parent class.

Other pylint warnings were made permanent. For instance, methods and functions
that have unused arguments aren't really a huge concern, especially in cases
where a method is overridden, or it's a clutter function we have no control
over. __init__ methods don't always have to be present, and sometimes instance
attributes shoould be initialized in a method other than __init__ (although is
almost always called from __init__ only).

I'm really concerned that removing some of these exceptions mean that we're
going to have to do some MASSIVE QA. It means that we'll have a more stable
codebase in the long run, but since we're not suppressing errors anymore, we're
going to get a lot of exceptions bubbling up and an in-flux of bugs is likely.
I found, however, that when I tried to find a way to catch an exception and
just move on, there was a better way to approach the code itself, like checking
for a non-empty list before even considering operating on it.

--
Paul Hummer
http://theironlion.net
1024/862FF08F C921 E962 58F8 5547 6723 0E8C 1C4D 8AC5 862F F08F

[Matt Layman (mblayman)]

Looks good. Let the breakage begin.

One comment: I think you fix a bunch of tech-debt bugs with this branch, but you haven't linked to any of them.

review: Approve

[Samuel Buffet (samuel-buffet)]

Hi Paul,

branch description : ok
make test : ok
make lint :
************* Module entertainerlib.frontend.frontend_client
W0612: 50:FrontendClient.__init__: Unused variable 'system_tray_icon'
=> This one is not linked to your branch because it's also there in trunk so it's ok

> This branch enables more pylint warnings, mostly concerning how exceptions are
> handled. The big thing is that catchall exceptions like...
>
> try:
> do_stuff()
> except:
> pass
>
> ...is no longer allowed. Also, doing a flat "pass" right after an exception is
> also not allowed. And just doing "except Exception" is also not good (it's the
> same as not specifying an exception at all).

Okay, no problem with that. It will help to get the code more robust. Need to catch exception from file IO and from network tough.

> The other pylint error fixed is cases where the inherited class doesn't
> implement the same method signature as its parent class.
>
> Other pylint warnings were made permanent. For instance, methods and functions
> that have unused arguments aren't really a huge concern, especially in cases
> where a method is overridden, or it's a clutter function we have no control
> over.

Agreed it's good for the code.

> __init__ methods don't always have to be present, and sometimes instance
> attributes shoould be initialized in a method other than __init__ (although is
> almost always called from __init__ only).

Sure __init__ is not mandatory when there's no needed argument initialization. But what's the interest not to do them in the __init__ method ?

content-manager broken on my box.
Here is what I have when I try to close it:

Traceback (most recent call last):
  File "/mnt/raid/Programmes/branches_entertainer/more-pylint-fun/entertainerlib/utils/content_management_dialog.py", line 145, in on_close_button_clicked
    proxy.connectToMessageBus()
  File "/mnt/raid/Programmes/branches_entertainer/more-pylint-fun/entertainerlib/backend/core/message_bus_proxy.py", line 63, in connectToMessageBus
    self.socket_to_server.connect(('localhost', self.config.get_port()))
  File "<string>", line 1, in connect

entertainer-preferences broken on my desktop.
Here is what I have trying to run it :

Traceback (most recent call last):
  File "./entertainer-preferences", line 12, in <module>
    PreferencesDialog(True)
  File "/mnt/raid/Programmes/branches_entertainer/more-pylint-fun/entertainerlib/utils/preferences_dialog.py", line 62, in __init__
    self.init_dialog_values_from_configure_file()
  File "/mnt/raid/Programmes/branches_entertainer/more-pylint-fun/entertainerlib/utils/preferences_dialog.py", line 245, in init_dialog_values_from_configure_file
    name = model.get_value(iter, 0)
TypeError: iter must be a GtkTreeIter

=== modified file 'entertainerlib/backend/components/mediacache/image_cache.py'
--- entertainerlib/backend/components/mediacache/image_cache.py 2009-02-06 08:13:48 +0000
+++ entertainerlib/backend/components/mediacache/image_cache.py 2009-02-08 19:09:10 +0000
@@ -57,37 +57,26 @@
             thumb_file = os.path.join(self.config.IMAGE_THUMB_DIR, element)
             try:
                 os.remove(thumb_file)
- excep...

[lp:~rockstar/entertainer/more-pylint-fun]

350. By Paul Hummer on 2009-02-10

Handled exceptions when the backend isn't running

351. By Paul Hummer on 2009-02-10

Fixed exceptions in Preferences dialog

352. By Paul Hummer on 2009-02-10

Fixed a small test issue and a small lint issue

=== modified file 'entertainerlib/backend/backend_server.py'
--- entertainerlib/backend/backend_server.py	2009-02-07 00:44:47 +0000
+++ entertainerlib/backend/backend_server.py	2009-02-08 07:01:25 +0000
@@ -6,8 +6,6 @@
 __author__ = "Lauri Taimila <[e-mail]>"
 __version__ = "0.1"
 
-import sys
-
 import gobject
 
 from entertainerlib.utils.configuration import Configuration
@@ -46,6 +44,7 @@
         self.config = Configuration()
         self.logger = Logger().getLogger('backend.BackendServer')
         self.message_bus = MessageBus()
+        self._port = self.config.get_port()
 
         # Connection server - Thread that listens incoming socket connections
         self.connection_server = None
@@ -69,34 +68,19 @@
 
     def initialize_configuration(self):
         """Initialize configuration"""
-        try:
-            cfg_dict = { MessageType.CONTENT_CONF_UPDATED :
-                             MessagePriority.VERY_HIGH,
-                         MessageType.PREFERENCES_CONF_UPDATED :
-                             MessagePriority.VERY_HIGH }
-            self.message_bus.registerMessageHandler(self.config, cfg_dict)
-            self.logger.debug("Configuration intialized successfully")
-        except:
-            print "Couldn't read configuration file! Execution aborted..."
-            sys.exit(1)
+        cfg_dict = {
+            MessageType.CONTENT_CONF_UPDATED : MessagePriority.VERY_HIGH,
+            MessageType.PREFERENCES_CONF_UPDATED : MessagePriority.VERY_HIGH
+            }
+        self.message_bus.registerMessageHandler(self.config, cfg_dict)
+        self.logger.debug("Configuration intialized successfully")
 
     def initialize_connection_server(self):
         """Initialize connection server."""
-        try:
-            self._port = self.config.get_port()
-            self.connection_server = ConnectionServer(self._port,
-                                                      self.message_bus)
-            # Start listening incoming connections
-            self.connection_server.start()
-        except:
-            self.logger.error("ConnectionServer initialization failed!")
-            message = 'Error occured. Please see '
-            message += self.config.ENTERTAINER_LOG
-            message += ' for more information. This is probably not a fatal'
-            message += ' error. Just wait one minute and try again.'
-            print message
-            print "Execution aborted!"
-            sys.exit(1)
+        self.connection_server = ConnectionServer(self._port,
+                                                  self.message_bus)
+        # Start listening incoming connections
+        self.connection_server.start()
 
     def initialize_scheduler(self):
         """Initialize message scheduler."""

=== modified file 'entertainerlib/backend/components/feeds/feed_fetcher.py'
--- entertainerlib/backend/components/feeds/feed_fetcher.py	2009-02-06 08:13:48 +0000
+++ entertainerlib/backend/components/feeds/feed_fetcher.py	2009-02-07 21:43:35 +0000
@@ -52,14 +52,9 @@
                     last_update = datetime(dt[0], dt[1], dt[2],
                                            dt[3], dt[4], dt[5])
                 except AttributeError:
-                    try:
-                        dt = data.entries[0].date_parsed
-                        last_update = datetime(dt[0], dt[1], dt[2],
-                                               dt[3], dt[4], dt[5])
-                    except:
-                        self.logger.warning("Couldn't determine feed date of " \
-                             + data.feed.title)
-                        continue # Skip to the next feed
+                    dt = data.entries[0].date_parsed
+                    last_update = datetime(dt[0], dt[1], dt[2],
+                                           dt[3], dt[4], dt[5])
 
                 #Check if this feed has new entries
                 db_cursor.execute("""SELECT date,time

=== modified file 'entertainerlib/backend/components/mediacache/image_cache.py'
--- entertainerlib/backend/components/mediacache/image_cache.py	2009-02-06 08:13:48 +0000
+++ entertainerlib/backend/components/mediacache/image_cache.py	2009-02-07 22:12:25 +0000
@@ -57,37 +57,26 @@
             thumb_file = os.path.join(self.config.IMAGE_THUMB_DIR, element)
             try:
                 os.remove(thumb_file)
-            except:
+            except OSError:
                 self.logger.error(
                     "Media manager couldn't remove thumbnail : %s"
                     % thumb_file)
-        try:
-            os.remove(self.config.IMAGE_DB)
-            self._createImageCacheDatabase()
-        except:
-            raise IOError("Couldn't clear image cache")
+        os.remove(self.config.IMAGE_DB)
+        self._createImageCacheDatabase()
 
 
     def addFile(self, filename):
         """
         Add image file to the cache. Do nothing if file is already cached.
         """
-        try:
-            filename = filename.encode('utf8')
-            if (not self.isFileInCache(filename) and
-                self.isSupportedFormat(filename)):
-                # Do not add album thumbnail to images
-                if (filename[filename.rfind('/') +1:filename.rfind('.')] ==
-                    ".entertainer_album"):
-                    return
-                try:
-                    self._addJPEGfile(filename)
-                except Exception, e:
-                    self.logger.error("Couldn't cache file: " + filename)
-                    self.logger.debug("Exception: " + str(e.message))
-        except Exception, e:
-            self.logger.error("Problem With " + filename)
-            self.logger.error("Exception: " + e.message)
+        filename = filename.encode('utf8')
+        if (not self.isFileInCache(filename) and
+            self.isSupportedFormat(filename)):
+            # Do not add album thumbnail to images
+            if (filename[filename.rfind('/') +1:filename.rfind('.')] ==
+                ".entertainer_album"):
+                return
+            self._addJPEGfile(filename)
 
     def removeFile(self, filename):
         """
@@ -105,7 +94,7 @@
                 thumb = os.path.join(self.config.IMAGE_THUMB_DIR, name)
                 try:
                     os.remove(thumb)
-                except:
+                except OSError:
                     self.logger.error("Couldn't remove thumbnail: " + thumb)
                 self.db_cursor.execute("""DELETE
                                             FROM image
@@ -153,10 +142,7 @@
                                     WHERE filename LIKE '""" + path + "%'")
         for row in self.db_cursor:
             thumb_file = row[0] + ".jpg"
-            try:
-                os.remove(os.path.join(self.config.IMAGE_THUMB_DIR, thumb_file))
-            except:
-                pass
+            os.remove(os.path.join(self.config.IMAGE_THUMB_DIR, thumb_file))
 
         # Remove folder thumbnails
         self.db_cursor.execute("""SELECT hash
@@ -164,10 +150,7 @@
                                     WHERE path LIKE '""" + path + "%'")
         for row in self.db_cursor:
             thumb_file = row[0] + ".jpg"
-            try:
-                os.remove(os.path.join(self.config.IMAGE_THUMB_DIR, thumb_file))
-            except:
-                pass
+            os.remove(os.path.join(self.config.IMAGE_THUMB_DIR, thumb_file))
 
         # Clean cache database
         self.db_cursor.execute(
@@ -260,7 +243,7 @@
                 inf_f = open(album_info)
                 a_title = inf_f.readline()[6:]
                 a_description = inf_f.readline()[12:]
-            except:
+            except IOError:
                 a_title = path[path.rfind('/')+1:].replace('_',' ').title()
                 a_description = ""
         else:
@@ -302,13 +285,10 @@
             str(tmp.day), str(tmp.hour) + ":" + str(tmp.minute) + ":" +
             str(tmp.second)]
 
-        try:
-            title, description = self._readMetadataFile(filename)
-        except:
-            # Generate name from filename
-            tmp = filename[filename.rfind('/') + 1 : filename.rfind('.')]
-            title = tmp.replace('_',' ').title() # Make title more attractive
-            description = "" # No description for this image file
+        # Generate name from filename
+        tmp = filename[filename.rfind('/') + 1 : filename.rfind('.')]
+        title = tmp.replace('_',' ').title() # Make title more attractive
+        description = "" # No description for this image file
 
         im = Image.open(filename)
         width, height = im.size
@@ -346,27 +326,3 @@
                 VALUES(?,?,?,?,?,?,?,?,?,?)""", db_row)
         self.db_conn.commit()
 
-    def _readMetadataFile(self, filename):
-        """
-        Reads image title and description from explicite metadata file if
-        the file exists. If file doesn't exist, this method throws an
-        exception, which indicates to the caller that metadata should be
-        received from some place else.
-        """
-        # Generate metadata filename
-        abs_path = filename[:filename.rfind('/') + 1] # Cut filename off
-        img_file = filename[filename.rfind('/') + 1:] # Cut path off
-        metadata_file = abs_path + "." + img_file[:img_file.rfind('.')] + \
-            ".info"
-
-        if os.path.exists(metadata_file):
-            try:
-                info_file = open(metadata_file)
-                title = info_file.readline()[6:]
-                description = info_file.readline()[12:]
-                return title, description
-            except:
-                raise Exception("Couldn't read existing metadata file.")
-        else:
-            raise Exception("Metadata file doesn't exist.")
-

=== modified file 'entertainerlib/backend/components/mediacache/music_cache.py'
--- entertainerlib/backend/components/mediacache/music_cache.py	2009-02-06 08:13:48 +0000
+++ entertainerlib/backend/components/mediacache/music_cache.py	2009-02-07 21:43:35 +0000
@@ -55,34 +55,20 @@
         """
         covers = os.listdir(self.config.ALBUM_ART_DIR)
         for element in covers:
-            try:
-                os.remove(os.path.join(self.config.ALBUM_ART_DIR, element))
-            except:
-                pass
-        try:
-            os.remove(self.config.MUSIC_DB)
-            self.__createMusicCacheDatabase()
-        except:
-            raise IOError("Couldn't clear music cache")
+            os.remove(os.path.join(self.config.ALBUM_ART_DIR, element))
+
+        os.remove(self.config.MUSIC_DB)
+        self.__createMusicCacheDatabase()
 
     def addFile(self, filename):
         """Add audio file to the cache."""
-        try:
-            filename = filename.encode('utf8')
-            if (not self.isFileInCache(filename) and
-                self.isSupportedFormat(filename)):
-                try:
-                    if self.__getFileExtension(filename) == "mp3":
-                        self.__addMP3file(filename)
-                    elif self.__getFileExtension(filename) == "ogg":
-                        self.__addOGGfile(filename)
-                except Exception, e:
-                    self.logger.error("Couldn't cache file: " + filename)
-                    self.logger.debug("Exception: " + e.message)
-        except Exception, e:
-            self.logger.error("Problem With " + filename)
-            self.logger.error("Exception: " + e.message)
-
+        filename = filename.encode('utf8')
+        if (not self.isFileInCache(filename) and
+            self.isSupportedFormat(filename)):
+            if self.__getFileExtension(filename) == "mp3":
+                self.__addMP3file(filename)
+            elif self.__getFileExtension(filename) == "ogg":
+                self.__addOGGfile(filename)
 
     def removeFile(self, filename):
         """Remove audio file from the cache."""
@@ -111,7 +97,7 @@
                 try:
                     os.remove(os.path.join(self.config.ALBUM_ART_DIR,
                         albumart_file))
-                except:
+                except OSError:
                     self.logger.error("Couldn't remove albumart: " +
                         os.path.join(self.config.ALBUM_ART_DIR, albumart_file))
 
@@ -181,7 +167,7 @@
                 try:
                     os.remove(os.path.join(self.config.ALBUM_ART_DIR,
                         albumart_file))
-                except:
+                except OSError:
                     self.logger.error(
                         "Couldn't remove albumart: " +
                         os.path.join(self.config.ALBUM_ART_DIR, albumart_file))
@@ -264,12 +250,8 @@
             - Get tags
             - Insert data to the music cache database
         """
-        try:
-            mp3_file = eyeD3.Mp3AudioFile(filename, eyeD3.ID3_ANY_VERSION)
-            tags = mp3_file.getTag()
-        except:
-            self.logger.error("Couldn't read ID3tags: " + filename)
-            return
+        mp3_file = eyeD3.Mp3AudioFile(filename, eyeD3.ID3_ANY_VERSION)
+        tags = mp3_file.getTag()
 
         if tags is None:
             self.logger.error("Couldn't read ID3tags: " + filename)
@@ -297,11 +279,8 @@
             title = self.__DEFAULT['title']
 
         # Get track genre
-        try:
-            genre = str(tags.getGenre())
-            if genre is None or len(genre) == 0:
-                genre = self.__DEFAULT['genre']
-        except:
+        genre = str(tags.getGenre())
+        if genre is None or len(genre) == 0:
             genre = self.__DEFAULT['genre']
 
         # Get track number
@@ -357,12 +336,8 @@
             - Get tags
             - Insert data to the music cache database
         """
-        try:
-            ogg_file = ogg.vorbis.VorbisFile(filename)
-            info = ogg_file.comment().as_dict()
-        except:
-            self.logger.error("Couldn't index file: " + filename)
-            return
+        ogg_file = ogg.vorbis.VorbisFile(filename)
+        info = ogg_file.comment().as_dict()
 
         # Get length
         length = round(ogg_file.time_total(-1))

=== modified file 'entertainerlib/backend/components/mediacache/video_cache.py'
--- entertainerlib/backend/components/mediacache/video_cache.py	2009-02-06 08:13:48 +0000
+++ entertainerlib/backend/components/mediacache/video_cache.py	2009-02-07 22:12:25 +0000
@@ -49,34 +49,19 @@
         covers = os.listdir(self.config.MOVIE_ART_DIR)
         for element in covers:
             if element[-3:] == "jpg":
-                try:
-                    os.remove(os.path.join(self.config.MOVIE_ART_DIR, element))
-                except:
-                    self.logger.error(
-                        "Media manager couldn't remove movie cover.")
+                os.remove(os.path.join(self.config.MOVIE_ART_DIR, element))
 
-        try:
-            os.remove(self.config.VIDEO_DB)
-        except:
-            pass
+        os.remove(self.config.VIDEO_DB)
         self.__createVideoCacheDatabase()
 
     def addFile(self, filename):
         """
         This method adds a new file to the cache.
         """
-        try:
-            filename = filename.encode('utf8')
-            if not self.isFileInCache(filename) and \
-                self.isSupportedFormat(filename):
-                try:
-                    self._addVideoFile(filename)
-                except Exception, e:
-                    self.logger.error("Couldn't cache file: " + filename)
-                    self.logger.debug("Exception: " + e.message)
-        except Exception, e:
-            self.logger.error("Problem With " + filename)
-            self.logger.error("Exception: " + e.message)
+        filename = filename.encode('utf8')
+        if not self.isFileInCache(filename) and \
+            self.isSupportedFormat(filename):
+            self._addVideoFile(filename)
 
     def removeFile(self, filename):
         """
@@ -116,15 +101,9 @@
 
             # Remove thumbnail and cover art
             if os.path.exists(art) and not self.__hasSeriesEpisodes(series):
-                try:
-                    os.remove(art)
-                except:
-                    self.logger.error("Couldn't remove movie art" + art)
+                os.remove(art)
             if os.path.exists(thumb):
-                try:
-                    os.remove(thumb)
-                except:
-                    self.logger.error("Couldn't remove thumbnail" + thumb)
+                os.remove(thumb)
 
     def updateFile(self, filename):
         """
@@ -255,15 +234,10 @@
     def _addVideoFile(self, filename):
         """Add video file to the video cache."""
         # Generate thumbnail
-        try:
-            thumbnailer = VideoThumbnailer(filename)
-            thumbnailer.create_thumbnail()
-            thash = thumbnailer.get_hash()
-            del thumbnailer
-        except Exception, e:
-            thash = None
-            self.logger.error("Problem Creating Thumbnail: " + filename)
-            self.logger.debug("Exception: " + e.message)
+        thumbnailer = VideoThumbnailer(filename)
+        thumbnailer.create_thumbnail()
+        thash = thumbnailer.get_hash()
+        del thumbnailer
 
         #FIXME: read resolution, length etc. from video file and add to db
         self.__db_cursor.execute("""INSERT INTO videofile(filename, hash)
@@ -279,11 +253,7 @@
     def __searchMetadata(self, filename):
         """Search metadata for video file from the Internet."""
         search_thread = None
-        try:
-            search_thread = VideoMetadataSearch(filename)
-        except:
-            self.logger.error(
-                "Invalid TV-Series episode filename detected: " + filename)
+        search_thread = VideoMetadataSearch(filename)
 
         if search_thread is not None:
             search_thread.start()

=== modified file 'entertainerlib/backend/components/mediacache/video_metadata_search.py'
--- entertainerlib/backend/components/mediacache/video_metadata_search.py	2008-12-07 20:41:05 +0000
+++ entertainerlib/backend/components/mediacache/video_metadata_search.py	2009-02-07 22:12:25 +0000
@@ -102,11 +102,7 @@
         Search metadata from IMDB and update video cache database.
         """
         search_results = []
-        try:
-            search_results = self.IMDb.search_movie(self.title)
-        except:
-            self.logger.error("IMDB search failed")
-            return # Network error or too many results to handle
+        search_results = self.IMDb.search_movie(self.title)
 
         if len(search_results) == 0:
             return # No matches for this search
@@ -114,69 +110,42 @@
         if search_results[0]['kind'] == "movie":
             # We trust that the first search result is the best
             movie = search_results[0]
-            try:
-                self.IMDb.update(movie)
-            except:
-                self.logger.error(
-                    "Metadata search failed for: " + self.filename)
-                return
+            self.IMDb.update(movie)
 
             video_type = "MOVIE"
-            try:
-                title = movie['title']
-                year = movie['year']
-                # convert to 5-stars rating
-                rating = round(float(movie['rating']) / 2)
-
-                genres = ','.join(movie['genres'])
-                try:
-                    plot_outline = movie['plot outline']
-                except:
-                    plot_outline = ""
-
-                try:
-                    plot_string = movie['plot'][0]
-                    plot = plot_string[plot_string.rfind("::")+2:].lstrip()
-                except:
-                    plot = _("Plot not available")
-
-                # IMDb returns sometimes list and sometimes string
-                if(type(plot)) is list:
-                    plot = plot[0]
-                if(type(plot_outline)) is list:
-                    plot_outline = plot_outline[0]
-
-                try:
-                    runtime = movie['runtime'][0]
-                    int(runtime) # Raises exception if not integer
-                except:
-                    runtime = 0
-                p = self._get_persons(movie)
-                row = (video_type, title, "", runtime, genres, rating,
-                       year, plot_outline, plot, 0, 0, p[0], p[1], p[2],
-                       p[3], p[4], p[5], p[6], p[7], p[8], self.filename)
-                self._update_video_cache(row)
-
-                # Download and save cover art
-                try:
-                    self._download_cover_art(movie['cover url'], title)
-                except:
-                    pass
-            except:
-                self.logger.error("Couldn't find metadata from IMDB for: " +
-                                    self.filename)
-                return
+            title = movie['title']
+            year = movie['year']
+            # convert to 5-stars rating
+            rating = round(float(movie['rating']) / 2)
+
+            genres = ','.join(movie['genres'])
+            plot_outline = movie['plot outline']
+
+            plot_string = movie['plot'][0]
+            plot = plot_string[plot_string.rfind("::")+2:].lstrip()
+
+            # IMDb returns sometimes list and sometimes string
+            if(type(plot)) is list:
+                plot = plot[0]
+            if(type(plot_outline)) is list:
+                plot_outline = plot_outline[0]
+
+            runtime = movie['runtime'][0]
+            int(runtime) # Raises exception if not integer
+            p = self._get_persons(movie)
+            row = (video_type, title, "", runtime, genres, rating,
+                   year, plot_outline, plot, 0, 0, p[0], p[1], p[2],
+                   p[3], p[4], p[5], p[6], p[7], p[8], self.filename)
+            self._update_video_cache(row)
+
+            # Download and save cover art
+            self._download_cover_art(movie['cover url'], title)
 
         elif search_results[0]['kind'] == "tv series":
             series = search_results[0]
             # We trust that the first search result is the best
-            try:
-                self.IMDb.update(series)
-                self.IMDb.update(series, "episodes")
-            except:
-                self.logger.error("Couldn't find metadata from IMDB for: " +
-                                    self.filename)
-                return
+            self.IMDb.update(series)
+            self.IMDb.update(series, "episodes")
 
             video_type = "TV-SERIES"
             p = self._get_persons(series)
@@ -186,34 +155,19 @@
 
             series_title = series['title']
             genres = ','.join(series['genres'])
-            try:
-                time = series['runtime']
-                runtime = time[0][:time[0].find(":")]
-                int(runtime) # This raises exception if runtime is not integer
-            except:
-                runtime = 0
-            try:
-                year = series['series years']
-            except:
-                year = series['year']
-            try:
-                title = series['episodes'][self.season][self.episode]['title']
-            except:
-                title = _("%(episode)d. Episode") % {'episode': self.episode}
-            try:
-                plot =  series['episodes'][self.season][self.episode]['plot']
-            except:
-                plot = _("No plot outline available")
+            time = series['runtime']
+            runtime = time[0][:time[0].find(":")]
+            int(runtime) # This raises exception if runtime is not integer
+            year = series['series years']
+            title = series['episodes'][self.season][self.episode]['title']
+            plot =  series['episodes'][self.season][self.episode]['plot']
             row = (video_type, title, series_title, runtime, genres, rating, \
                    year, "", plot, self.season, self.episode, p[0], p[1], \
                    p[2], p[3], p[4], p[5] ,p[6], p[7], p[8], self.filename)
             self._update_video_cache(row)
 
             # Download and save cover art
-            try:
-                self._download_cover_art(series['cover url'], series_title)
-            except:
-                pass
+            self._download_cover_art(series['cover url'], series_title)
         else:
             # This file wasn't identified to be a movie or a TV-series episode.
             return
@@ -224,36 +178,32 @@
         @param db_row: List that contains all information we want to store into
                        cache
         """
-        try:
-            db_conn = sqlite.connect(self.config.VIDEO_DB)
-            db_cursor = db_conn.cursor()
-            db_cursor.execute("""UPDATE metadata
-                                 SET type=?,
-                                     title=?,
-                                     series_title=?,
-                                     runtime=?,
-                                     genres=?,
-                                     rating=?,
-                                     year=?,
-                                     plot_outline=?,
-                                     plot=?,
-                                     season=?,
-                                     episode=?,
-                                     actor_1=?,
-                                     actor_2=?,
-                                     actor_3=?,
-                                     actor_4=?,
-                                     actor_5=?,
-                                     writer_1=?,
-                                     writer_2=?,
-                                     director_1=?,
-                                     director_2=?
-                                 WHERE filename=?""", db_row)
-            db_conn.commit()
-            db_conn.close()
-        except Exception, e:
-            self.logger.error("Exception occured during video cache update: " +
-                                e.message)
+        db_conn = sqlite.connect(self.config.VIDEO_DB)
+        db_cursor = db_conn.cursor()
+        db_cursor.execute("""UPDATE metadata
+                             SET type=?,
+                                 title=?,
+                                 series_title=?,
+                                 runtime=?,
+                                 genres=?,
+                                 rating=?,
+                                 year=?,
+                                 plot_outline=?,
+                                 plot=?,
+                                 season=?,
+                                 episode=?,
+                                 actor_1=?,
+                                 actor_2=?,
+                                 actor_3=?,
+                                 actor_4=?,
+                                 actor_5=?,
+                                 writer_1=?,
+                                 writer_2=?,
+                                 director_1=?,
+                                 director_2=?
+                             WHERE filename=?""", db_row)
+        db_conn.commit()
+        db_conn.close()
 
 
     def _get_persons(self, movie):
@@ -263,42 +213,15 @@
         @param movie: Movie name
         @return: List of strings containing actors, directors and writers
         """
-        try:
-            a1 = movie['actors'][0]['name']
-        except:
-            a1 = ""
-        try:
-            a2 = movie['actors'][1]['name']
-        except:
-            a2 = ""
-        try:
-            a3 = movie['actors'][2]['name']
-        except:
-            a3 = ""
-        try:
-            a4 = movie['actors'][3]['name']
-        except:
-            a4 = ""
-        try:
-            a5 = movie['actors'][4]['name']
-        except:
-            a5 = ""
-        try:
-            w1 = movie['writer'][0]['name']
-        except:
-            w1 = ""
-        try:
-            w2 = movie['writer'][1]['name']
-        except:
-            w2 = ""
-        try:
-            d1 = movie['director'][0]['name']
-        except:
-            d1 = ""
-        try:
-            d2 = movie['director'][1]['name']
-        except:
-            d2 = ""
+        a1 = movie['actors'][0]['name']
+        a2 = movie['actors'][1]['name']
+        a3 = movie['actors'][2]['name']
+        a4 = movie['actors'][3]['name']
+        a5 = movie['actors'][4]['name']
+        w1 = movie['writer'][0]['name']
+        w2 = movie['writer'][1]['name']
+        d1 = movie['director'][0]['name']
+        d2 = movie['director'][1]['name']
 
         return [a1, a2, a3, a4, a5, w1, w2, d1, d2]
 
@@ -311,10 +234,7 @@
         # Check if we have cover art for this series or movie already
         if not os.path.exists(
             os.path.join(self.config.MOVIE_ART_DIR, title + ".jpg")):
-            try:
-                image = urllib.urlopen(url)
-            except:
-                return
+            image = urllib.urlopen(url)
             dest = open(os.path.join(
                 self.config.MOVIE_ART_DIR, title + ".jpg"), 'w')
             dest.write(image.read())

=== modified file 'entertainerlib/backend/core/client_connection.py'
--- entertainerlib/backend/core/client_connection.py	2008-08-16 04:28:47 +0000
+++ entertainerlib/backend/core/client_connection.py	2009-02-07 21:43:35 +0000
@@ -52,11 +52,7 @@
         # Receive dictionary
         dict_str = self.client.readline()
         dictionary = None
-        try:
-            dictionary = cPickle.loads(dict_str[:-1])
-        except:
-            self.logger.error(
-                'Client sent malformed message dict to the backend!')
+        dictionary = cPickle.loads(dict_str[:-1])
 
         # This client to the message bus if desired
         if dictionary != None and len(dictionary) > 0:
@@ -87,10 +83,6 @@
         @param message: Received Message object
         """
         message_str = cPickle.dumps(message, cPickle.HIGHEST_PROTOCOL)
-        try:
-            self.client_out.sendall(message_str)
-            self.client_out.sendall("\nEND_OF_MESSAGE_OBJECT\n")
-        except:
-            self.logger.error(
-                "Socket broken! Client didn't receive a message.")
+        self.client_out.sendall(message_str)
+        self.client_out.sendall("\nEND_OF_MESSAGE_OBJECT\n")
 

=== modified file 'entertainerlib/frontend/frontend_client.py'
--- entertainerlib/frontend/frontend_client.py	2009-02-07 19:47:17 +0000
+++ entertainerlib/frontend/frontend_client.py	2009-02-07 22:12:25 +0000
@@ -60,24 +60,14 @@
 
     def initialize_backend_connection(self):
         '''Connect to the backend server.'''
-        try:
-            backend_connection = BackendConnection()
-            self.logger.debug('Connected to the Entertainer backend server.')
-        except:
-            print 'Couldn\'t connect to the backend server. Execution aborted!'
-            print 'Make sure that Entertainer backend server is up and running.'
-            sys.exit(1)
+        backend_connection = BackendConnection()
+        self.logger.debug('Connected to the Entertainer backend server.')
 
         return backend_connection
 
     def quit_frontend(self):
         '''Clean up the connection to the backend then close the frontend.'''
-        try:
-            self.backend_connection.close_connection()
-        except Exception, e:
-            print 'Error closing Backend Connection:', e.message
-            print 'Closing anyway'
-            sys.exit(0)
+        self.backend_connection.close_connection()
 
         gtk.main_quit()
         sys.exit(0)

=== modified file 'entertainerlib/frontend/gui/screens/audio_play.py'
--- entertainerlib/frontend/gui/screens/audio_play.py	2009-02-06 08:33:50 +0000
+++ entertainerlib/frontend/gui/screens/audio_play.py	2009-02-08 07:01:25 +0000
@@ -1,4 +1,5 @@
 '''AudioPlay - Screen displays information of currently playing audio'''
+# pylint: disable-msg=W0221
 
 __licence__ = "GPLv2"
 __copyright__ = "2007, Lauri Taimila"

=== modified file 'entertainerlib/frontend/gui/screens/disc.py'
--- entertainerlib/frontend/gui/screens/disc.py	2009-02-03 23:37:57 +0000
+++ entertainerlib/frontend/gui/screens/disc.py	2009-02-07 21:43:35 +0000
@@ -81,7 +81,6 @@
             self._create_album_cover_texture(artist, title)
             self._create_list_indicator()
 
-            # Check if artfile exists. If it doesn't let's make a search for it.
             art_file = os.path.join(self.config.ALBUM_ART_DIR,
                 artist + " - " + title + ".jpg")
             if artist != "Unknown artist" and not os.path.exists(art_file):
@@ -89,7 +88,7 @@
                     self.config.ALBUM_ART_DIR, self._update_albumart)
                 art_search.start()
 
-        except: # No disc in drive
+        except IndexError: # No disc in drive
             no_disc = Label(0.05, "title", 0.5, 0.5, 
                 _("No audio disc in drive"))
             no_disc.set_anchor_point_from_gravity(clutter.GRAVITY_CENTER)

=== modified file 'entertainerlib/frontend/gui/screens/photo.py'
--- entertainerlib/frontend/gui/screens/photo.py	2009-02-03 23:37:57 +0000
+++ entertainerlib/frontend/gui/screens/photo.py	2009-02-08 07:43:25 +0000
@@ -60,10 +60,8 @@
         """
         Change current image. Display image from given index.
         """
-        try:
+        if self.texture:
             self.texture.destroy()
-        except AttributeError:
-            pass # No previous texture in memory. No problem, let's continue
 
         # Create a new texture and display it
         image = self.images[index]

=== modified file 'entertainerlib/frontend/gui/screens/photo_albums.py'
--- entertainerlib/frontend/gui/screens/photo_albums.py	2009-02-03 23:37:57 +0000
+++ entertainerlib/frontend/gui/screens/photo_albums.py	2009-02-07 21:43:35 +0000
@@ -170,10 +170,7 @@
         Update album preview. Display preview images from the current album.
         @param album: Currently selected album in menu
         """
-        try:
-            gobject.source_remove(self.preview_fade)
-        except:
-            pass # If there is no image switcher enabled that's ok
+        gobject.source_remove(self.preview_fade)
 
         new = self._create_album_preview(album)
 

=== modified file 'entertainerlib/frontend/gui/screens/tv_episodes.py'
--- entertainerlib/frontend/gui/screens/tv_episodes.py	2009-02-03 23:37:57 +0000
+++ entertainerlib/frontend/gui/screens/tv_episodes.py	2009-02-08 07:43:25 +0000
@@ -82,11 +82,8 @@
         """
         Create a thumbnail texture. This is called as menu is scrolled
         """
-        try:
+        if self.thumb:
             self.thumb.hide()
-            del self.thumb
-        except:
-            pass # No problem, this is just the first time we call this method
 
         # Thumbnail. Use cover art if thumbnail doesn't exist
         menu_item = self.episode_menu.get_current_menuitem()

=== modified file 'entertainerlib/frontend/gui/widgets/image_menu.py'
--- entertainerlib/frontend/gui/widgets/image_menu.py	2008-12-08 17:26:56 +0000
+++ entertainerlib/frontend/gui/widgets/image_menu.py	2009-02-08 07:43:25 +0000
@@ -62,7 +62,7 @@
         This method is called when widget is set active or inactive. This
         method allows widget to react this action.
         """
-        try:
+        if len(self.items):
             if self.active:
                 self.cursor.show()
                 self.items[self.logical_position].set_active(True)
@@ -71,8 +71,6 @@
                 self.cursor.hide()
                 self.items[self.logical_position].set_active(False)
                 self.set_opacity(128)
-        except:
-            pass # No items in menu
 
     def _scale_menuitem(self, menuitem):
         """

=== modified file 'entertainerlib/frontend/gui/widgets/text_menu.py'
--- entertainerlib/frontend/gui/widgets/text_menu.py	2008-11-05 17:38:30 +0000
+++ entertainerlib/frontend/gui/widgets/text_menu.py	2009-02-08 07:43:25 +0000
@@ -47,7 +47,7 @@
         This method is called when widget is set active or inactive. This
         method allows widget to react this action.
         """
-        try:
+        if len(self.items):
             if self.active:
                 self.cursor.show()
                 self.items[self.logical_position].set_active(True)
@@ -56,9 +56,7 @@
                 self.cursor.hide()
                 self.items[self.logical_position].set_active(False)
                 self.set_opacity(128)
-        except:
-            pass # No items in menu
-    
+
     def get_index(self, text):
         """
         Returns index of label with the text as passed, returns -1 if not found

=== modified file 'entertainerlib/frontend/medialibrary/music.py'
--- entertainerlib/frontend/medialibrary/music.py	2009-02-07 17:12:21 +0000
+++ entertainerlib/frontend/medialibrary/music.py	2009-02-07 21:43:35 +0000
@@ -63,10 +63,7 @@
         @return: CompactDisc
         """
         cdrom = DiscID.open()
-        try:
-            disc_id = DiscID.disc_id(cdrom)
-        except:
-            raise Exception("No media in drive.")
+        disc_id = DiscID.disc_id(cdrom)
         return CompactDisc(disc_id)
 
     def get_playlists(self):
@@ -629,7 +626,7 @@
                     track_title = read_info['TTITLE' + str(i)]
                     self.tracks.append(CompactDiscTrack(i + 1, track_title,
                                                         length))
-            except:
+            except TypeError:
                 query = query_info[0]
                 self.artist = query['title'][:query['title'].index(' / ')]
                 self.album = query['title'][query['title'].index(' / ') + 3:]

=== modified file 'entertainerlib/tests/mock.py'
--- entertainerlib/tests/mock.py	2009-02-04 00:52:34 +0000
+++ entertainerlib/tests/mock.py	2009-02-08 07:01:25 +0000
@@ -268,7 +268,7 @@
         if make_album:
             self.album = MockAlbum(make_track=False)
 
-    def get_album(self):
+    def get_album(self, cursor=False):
         '''See `Track.get_album`.'''
         return self.album
 

=== modified file 'entertainerlib/tests/test_feedconfigtools.py'
--- entertainerlib/tests/test_feedconfigtools.py	2009-01-31 21:36:56 +0000
+++ entertainerlib/tests/test_feedconfigtools.py	2009-02-08 07:01:25 +0000
@@ -18,7 +18,7 @@
 class FeedConfigToolsTest(EntertainerTest):
     '''Test for entertainerlib.utils.feed_utils FeedConfigTools'''
 
-    def setUp(self, debug=False):
+    def setUp(self):
         """Sets up everything for the test"""
         EntertainerTest.setUp(self)
 

=== modified file 'entertainerlib/tests/test_feedentryparser.py'
--- entertainerlib/tests/test_feedentryparser.py	2009-01-31 21:36:56 +0000
+++ entertainerlib/tests/test_feedentryparser.py	2009-02-08 07:01:25 +0000
@@ -7,18 +7,14 @@
 
 import unittest
 
-from entertainerlib.utils.logger import Logger
 from entertainerlib.utils.feed_utils import FeedEntryParser
 
+
 class FeedEntryParserTest(unittest.TestCase):
     '''Test the FeedEntryParser'''
 
-    def setUp(self, debug=False):
+    def setUp(self):
         """Sets up everything for the test"""
-        self.debug = debug
-        if(self.debug):
-            self.logger = Logger('./tests.log').getLogger(
-                'FeedEntryParserTest')
 
         #test strings
         self.testString001 = "<body><b>Hello World</body></b>"
@@ -33,9 +29,6 @@
         tags
         """
         output = FeedEntryParser().strip_tags(self.testString001)
-        if(self.debug):
-            self.logger.debug("EXPECTED: " + self.resultString001)
-            self.logger.debug("OUTPUT: " + output)
         self.assertEqual(output, self.resultString001)
 
     def testStripTags002(self):
@@ -43,9 +36,6 @@
         non-default tags
         """
         output = FeedEntryParser().strip_tags(self.testString001, ["body"])
-        if(self.debug):
-            self.logger.debug("EXPECTED: " + self.resultString003)
-            self.logger.debug("OUTPUT: " + output)
         self.assertEqual(output, self.resultString003)
 
     def testStripNonPangoTags(self):
@@ -53,16 +43,10 @@
         non-pango tags from input
         """
         output = FeedEntryParser().strip_non_pango_tags(self.testString002)
-        if(self.debug):
-            self.logger.debug("EXPECTED: " + self.resultString002)
-            self.logger.debug("OUTPUT: " + output)
         self.assertEqual(output, self.resultString002)
 
     def testConvert(self):
         """tests if FeedEntryParser converts input to correct output"""
         output = FeedEntryParser().convert(self.testString002)
-        if(self.debug):
-            self.logger.debug("EXPECTED: " + self.resultString004)
-            self.logger.debug("OUTPUT: " + output)
         self.assertEqual(output, self.resultString004)
 

=== modified file 'entertainerlib/tests/test_music.py'
--- entertainerlib/tests/test_music.py	2009-02-07 17:12:21 +0000
+++ entertainerlib/tests/test_music.py	2009-02-07 21:43:35 +0000
@@ -251,10 +251,7 @@
 
     def setUp(self):
         TestMusic.setUp(self)
-        try:
-            self.backend_connection = MockBackendConnection()
-        except:
-            print "\nbackend_connection failed"
+        self.backend_connection = MockBackendConnection()
         self.musiclibrary = MusicLibrary(self.backend_connection)
 
     def tearDown(self):

=== modified file 'entertainerlib/tests/test_opmlparser.py'
--- entertainerlib/tests/test_opmlparser.py	2009-01-31 21:36:56 +0000
+++ entertainerlib/tests/test_opmlparser.py	2009-02-08 07:01:25 +0000
@@ -9,19 +9,16 @@
 import os
 import xml.parsers.expat
 
-from entertainerlib.utils.logger import Logger
 from entertainerlib.utils.feed_utils import OPMLParser
 
 THIS_DIR = os.path.dirname(__file__)
 
+
 class OPMLParserTest(unittest.TestCase):
     '''Test OPMLParser'''
 
-    def setUp(self, debug=False):
+    def setUp(self):
         '''See unittest.TestCase'''
-        self.debug = debug
-        if(self.debug):
-            self.logger = Logger('./tests.log').getLogger('OPMLParserTest')
 
         #set up lists and paths
         self.testURL = "http://www.scripting.com/feeds/top100.opml"
@@ -48,15 +45,10 @@
     def testGetRssFeeds001(self):
         """Check if OPMLParser can parse a normal file"""
         output = OPMLParser().get_rss_feeds(self.okFilePath)
-        if(self.debug):
-            self.logger.debug('Expecting the list : ' + str(self.feedList))
-            self.logger.debug('OUTPUT:' + str(output))
         self.assertEqual(output, self.feedList)
 
     def testGetRssFeeds002(self):
         """Check if OPMLParser can handle a non-existant file"""
-        if(self.debug):
-            self.logger.debug('Expecting an IOError')
         self.assertRaises(IOError, OPMLParser().get_rss_feeds,
             self.badFilePath)
 
@@ -69,35 +61,23 @@
         links
         """
         output = OPMLParser().get_rss_feeds(self.insideFilePath)
-        if(self.debug):
-            self.logger.debug('Expecting the list : ' + str(self.feedList))
-            self.logger.debug('OUTPUT: ' + str(output))
         self.assertEqual(output, self.feedList)
 
     def testGetRssFeeds004(self):
         """Check if OPMLParser can handle a file which is not an opml file or
         even an xml file
         """
-        if(self.debug):
-            self.logger.debug('Expecting an ExpatError')
         self.assertRaises(xml.parsers.expat.ExpatError,
             OPMLParser().get_rss_feeds, self.notXMLFile)
 
     def testGetRssFeeds005(self):
         """Check if OPMLParser can handle a URL"""
         output = OPMLParser().get_rss_feeds(self.testURL)
-        if(self.debug):
-            self.logger.debug('Expecting anything but []')
-            self.logger.debug('OUTPUT: ' + str(output))
         self.assertTrue(output != [])
 
     def testGetLifereaOpml001(self):
         """Check if OPMLParser can pick the opml file for liferea"""
         output = OPMLParser().get_liferea_opml(self.singleLifereaFolder)
-        if(self.debug):
-            self.logger.debug('Expecting the string : ' +
-                self.singleLifereaFolder+"/.liferea/feedlist.opml")
-            self.logger.debug('OUTPUT: ' + output)
         self.assertEqual(output,
             self.singleLifereaFolder+"/.liferea/feedlist.opml")
 
@@ -106,10 +86,6 @@
         of liferea out of a selection of folders
         """
         output = OPMLParser().get_liferea_opml(self.multipleLifereaFolders)
-        if(self.debug):
-            self.logger.debug('Expecting the string : ' +
-                self.multipleLifereaFolders+"/.liferea_1.4/feedlist.opml")
-            self.logger.debug('OUTPUT: ' + output)
         self.assertEqual(output,
             self.multipleLifereaFolders+"/.liferea_1.4/feedlist.opml")
 
@@ -118,9 +94,6 @@
         liferea opml folder
         """
         output = OPMLParser().get_liferea_opml(self.noLifereaFolder)
-        if(self.debug):
-            self.logger.debug('Expecting an empty string')
-            self.logger.debug('OUTPUT: ' + output)
         self.assertEqual(output, "")
 
     def testGetLifereaOpml004(self):
@@ -128,8 +101,5 @@
         liferea opml file
         """
         output = OPMLParser().get_liferea_opml(self.noLifereaFile)
-        if(self.debug):
-            self.logger.debug('Expecting an empty string')
-            self.logger.debug('OUTPUT: ' + output)
         self.assertEqual(output, "")
 

=== modified file 'entertainerlib/tests/test_weather.py'
--- entertainerlib/tests/test_weather.py	2009-02-07 17:49:58 +0000
+++ entertainerlib/tests/test_weather.py	2009-02-07 21:43:35 +0000
@@ -30,12 +30,9 @@
         self.weather.set_location('Bath,England')
         self.weather.refresh()
         forecasts = self.weather.get_forecasts()
-        try:
-            today = forecasts[0]
-            day = datetime.utcnow().strftime('%a')
-            self.assertEqual(str(today["Day"]), day)
-        except:
-            self.fail()
+        today = forecasts[0]
+        day = datetime.utcnow().strftime('%a')
+        self.assertEqual(str(today["Day"]), day)
 
     def testWeatherSet(self):
         """Tests the setting of a forecast to a given state"""

=== modified file 'entertainerlib/utils/albumart_downloader.py'
--- entertainerlib/utils/albumart_downloader.py	2009-01-04 23:22:07 +0000
+++ entertainerlib/utils/albumart_downloader.py	2009-02-07 21:43:35 +0000
@@ -238,8 +238,8 @@
             return
 
         try:
-            xmldoc = minidom.parseString (result_data)
-        except:
+            xmldoc = minidom.parseString(result_data)
+        except (TypeError, AttributeError):
             self.search_next()
             return
 
@@ -269,12 +269,7 @@
         if len(image_urls) == 0:
             return
         image_url = image_urls[0]
-        # This doesn't check which result is the best match
-        #image_url = result[0].ImageUrlLarge
-        try:
-            image_file = urllib.urlopen(image_url)
-        except:
-            return
+        image_file = urllib.urlopen(image_url)
         # base64 encode artist and album so there can be a '/' in the artist
         # or album
         artist_album = self.artist + " - " + self.album

=== modified file 'entertainerlib/utils/content_management_dialog.py'
--- entertainerlib/utils/content_management_dialog.py	2009-02-07 17:12:21 +0000
+++ entertainerlib/utils/content_management_dialog.py	2009-02-07 21:43:35 +0000
@@ -126,13 +126,10 @@
 
     def on_dialog_closed(self, widget):
         """Callback function for dialog's close button"""
-        try:
-            proxy = MessageBusProxy(client_name = "Content Management GUI")
-            proxy.connectToMessageBus()
-            proxy.sendMessage(Message(MessageType.CONTENT_CFG_UPDATED))
-            proxy.disconnectFromMessageBus()
-        except:
-            pass # This means that backend is not running. Doesn't matter
+        proxy = MessageBusProxy(client_name = "Content Management GUI")
+        proxy.connectToMessageBus()
+        proxy.sendMessage(Message(MessageType.CONTENT_CFG_UPDATED))
+        proxy.disconnectFromMessageBus()
 
         if(self.stand_alone):
             self.dialog.hide()
@@ -144,13 +141,10 @@
 
     def on_close_button_clicked(self, widget):
         """Callback function for dialog's close button"""
-        try:
-            proxy = MessageBusProxy(client_name = "Content Management GUI")
-            proxy.connectToMessageBus()
-            proxy.sendMessage(Message(MessageType.CONTENT_CFG_UPDATED))
-            proxy.disconnectFromMessageBus()
-        except:
-            pass # This means that backend is not running. Doesn't matter
+        proxy = MessageBusProxy(client_name = "Content Management GUI")
+        proxy.connectToMessageBus()
+        proxy.sendMessage(Message(MessageType.CONTENT_CFG_UPDATED))
+        proxy.disconnectFromMessageBus()
 
         if(self.stand_alone):
             self.dialog.hide()
@@ -182,14 +176,11 @@
         widget = self.widgets.get_widget("treeview_videos")
         model = widget.get_model()
         selection = widget.get_selection().get_selected()
-        try:
-            rm_folder = model.get_value(selection[1], 0)
-            self.video_folders.remove(rm_folder)
-            str_folders = ";".join(self.video_folders)
-            self.config.write_content_value("Videos", "folders", str_folders)
-            model.remove(selection[1])
-        except:
-            pass
+        rm_folder = model.get_value(selection[1], 0)
+        self.video_folders.remove(rm_folder)
+        str_folders = ";".join(self.video_folders)
+        self.config.write_content_value("Videos", "folders", str_folders)
+        model.remove(selection[1])
 
     def on_button_edit_videos_clicked(self, widget):
         """Edit currently selected folder"""
@@ -197,25 +188,21 @@
         url_dialog = self.widgets.get_widget("url_dialog")
         url_entry = self.widgets.get_widget("url_entry")
         model = widget.get_model()
-        try:
-            selection = widget.get_selection().get_selected()
-            folder = model.get_value(selection[1], 0)
-            url_entry.set_text(folder)
-            url_dialog.set_title(_("Edit URL"))
-            status = url_dialog.run()
-            if status == gtk.RESPONSE_OK and os.path.exists(self.url):
-                # Update list model
-                model.set_value(selection[1], 0, self.url)
-                # Update configure file
-                pos = self.video_folders.index(folder)
-                self.video_folders.remove(folder)
-                self.video_folders.insert(pos, self.url)
-                str_folders = ";".join(self.video_folders)
-                self.config.write_content_value("Videos", "folders",
-                    str_folders)
-        except:
-            # No need for actions. Item wasn't selected.
-            pass
+        selection = widget.get_selection().get_selected()
+        folder = model.get_value(selection[1], 0)
+        url_entry.set_text(folder)
+        url_dialog.set_title(_("Edit URL"))
+        status = url_dialog.run()
+        if status == gtk.RESPONSE_OK and os.path.exists(self.url):
+            # Update list model
+            model.set_value(selection[1], 0, self.url)
+            # Update configure file
+            pos = self.video_folders.index(folder)
+            self.video_folders.remove(folder)
+            self.video_folders.insert(pos, self.url)
+            str_folders = ";".join(self.video_folders)
+            self.config.write_content_value("Videos", "folders",
+                str_folders)
 
     def on_checkbutton_video_metadata_toggled(self, widget):
         """
@@ -250,40 +237,32 @@
         widget = self.widgets.get_widget("treeview_music")
         model = widget.get_model()
         selection = widget.get_selection().get_selected()
-        try:
-            rm_folder = model.get_value(selection[1], 0)
-            self.music_folders.remove(rm_folder)
+        rm_folder = model.get_value(selection[1], 0)
+        self.music_folders.remove(rm_folder)
+        str_folders = ";".join(self.music_folders)
+        self.config.write_content_value("Music", "folders", str_folders)
+        model.remove(selection[1])
+
+    def on_button_edit_music_clicked(self, widget):
+        """Edit currently selected music folder"""
+        widget = self.widgets.get_widget("treeview_music")
+        url_dialog = self.widgets.get_widget("url_dialog")
+        url_entry = self.widgets.get_widget("url_entry")
+        model = widget.get_model()
+        selection = widget.get_selection().get_selected()
+        folder = model.get_value(selection[1], 0)
+        url_entry.set_text(folder)
+        url_dialog.set_title(_("Edit URL"))
+        status = url_dialog.run()
+        if status == gtk.RESPONSE_OK and os.path.exists(self.url):
+            # Update list model
+            model.set_value(selection[1], 0, self.url)
+            # Update configure file
+            pos = self.music_folders.index(folder)
+            self.music_folders.remove(folder)
+            self.music_folders.insert(pos, self.url)
             str_folders = ";".join(self.music_folders)
             self.config.write_content_value("Music", "folders", str_folders)
-            model.remove(selection[1])
-        except:
-            # No need for actions. Item wasn't selected.
-            pass
-
-    def on_button_edit_music_clicked(self, widget):
-        """Edit currently selected music folder"""
-        widget = self.widgets.get_widget("treeview_music")
-        url_dialog = self.widgets.get_widget("url_dialog")
-        url_entry = self.widgets.get_widget("url_entry")
-        model = widget.get_model()
-        try:
-            selection = widget.get_selection().get_selected()
-            folder = model.get_value(selection[1], 0)
-            url_entry.set_text(folder)
-            url_dialog.set_title(_("Edit URL"))
-            status = url_dialog.run()
-            if status == gtk.RESPONSE_OK and os.path.exists(self.url):
-                # Update list model
-                model.set_value(selection[1], 0, self.url)
-                # Update configure file
-                pos = self.music_folders.index(folder)
-                self.music_folders.remove(folder)
-                self.music_folders.insert(pos, self.url)
-                str_folders = ";".join(self.music_folders)
-                self.config.write_content_value("Music", "folders", str_folders)
-        except:
-            # No need for actions. Item wasn't selected.
-            pass
 
     def on_button_add_images_clicked(self, widget):
         """Opens add URL dialog. """
@@ -307,41 +286,33 @@
         widget = self.widgets.get_widget("treeview_images")
         model = widget.get_model()
         selection = widget.get_selection().get_selected()
-        try:
-            rm_folder = model.get_value(selection[1], 0)
-            self.image_folders.remove(rm_folder)
+        rm_folder = model.get_value(selection[1], 0)
+        self.image_folders.remove(rm_folder)
+        str_folders = ";".join(self.image_folders)
+        self.config.write_content_value("Images", "folders", str_folders)
+        model.remove(selection[1])
+
+    def on_button_edit_images_clicked(self, widget):
+        """Edit currently selected music folder"""
+        widget = self.widgets.get_widget("treeview_images")
+        url_dialog = self.widgets.get_widget("url_dialog")
+        url_entry = self.widgets.get_widget("url_entry")
+        model = widget.get_model()
+        selection = widget.get_selection().get_selected()
+        folder = model.get_value(selection[1], 0)
+        url_entry.set_text(folder)
+        url_dialog.set_title(_("Edit URL"))
+        status = url_dialog.run()
+        if status == gtk.RESPONSE_OK and os.path.exists(self.url):
+            # Update list model
+            model.set_value(selection[1], 0, self.url)
+            # Update configure file
+            pos = self.image_folders.index(folder)
+            self.image_folders.remove(folder)
+            self.image_folders.insert(pos, self.url)
             str_folders = ";".join(self.image_folders)
-            self.config.write_content_value("Images", "folders", str_folders)
-            model.remove(selection[1])
-        except:
-            # No need for actions. Item wasn't selected.
-            pass
-
-    def on_button_edit_images_clicked(self, widget):
-        """Edit currently selected music folder"""
-        widget = self.widgets.get_widget("treeview_images")
-        url_dialog = self.widgets.get_widget("url_dialog")
-        url_entry = self.widgets.get_widget("url_entry")
-        model = widget.get_model()
-        try:
-            selection = widget.get_selection().get_selected()
-            folder = model.get_value(selection[1], 0)
-            url_entry.set_text(folder)
-            url_dialog.set_title(_("Edit URL"))
-            status = url_dialog.run()
-            if status == gtk.RESPONSE_OK and os.path.exists(self.url):
-                # Update list model
-                model.set_value(selection[1], 0, self.url)
-                # Update configure file
-                pos = self.image_folders.index(folder)
-                self.image_folders.remove(folder)
-                self.image_folders.insert(pos, self.url)
-                str_folders = ";".join(self.image_folders)
-                self.config.write_content_value("Images", "folders",
-                    str_folders)
-        except:
-            # No need for actions. Item wasn't selected.
-            pass
+            self.config.write_content_value("Images", "folders",
+                str_folders)
 
     def on_button_add_feed_clicked(self, widget):
         """Opens add feed dialog. """
@@ -363,15 +334,11 @@
         widget = self.widgets.get_widget("treeview_feeds")
         model = widget.get_model()
         selection = widget.get_selection().get_selected()
-        try:
-            rm_folder = model.get_value(selection[1], 0)
-            self.feeds.remove(rm_folder)
-            str_folders = ";".join(self.feeds)
-            self.config.write_content_value("RSS", "feeds", str_folders)
-            model.remove(selection[1])
-        except:
-            # No need for actions. Item wasn't selected.
-            pass
+        rm_folder = model.get_value(selection[1], 0)
+        self.feeds.remove(rm_folder)
+        str_folders = ";".join(self.feeds)
+        self.config.write_content_value("RSS", "feeds", str_folders)
+        model.remove(selection[1])
 
     def on_button_edit_feed_clicked(self, widget):
         """Edit currently selected feed"""
@@ -379,24 +346,20 @@
         url_dialog = self.widgets.get_widget("url_dialog")
         url_entry = self.widgets.get_widget("url_entry")
         model = widget.get_model()
-        try:
-            selection = widget.get_selection().get_selected()
-            feed = model.get_value(selection[1], 0)
-            url_entry.set_text(feed)
-            url_dialog.set_title(_("Edit feed"))
-            status = url_dialog.run()
-            if status == gtk.RESPONSE_OK:
-                # Update list model
-                model.set_value(selection[1], 0, self.url)
-                # Update configure file
-                pos = self.feeds.index(feed)
-                self.feeds.remove(feed)
-                self.feeds.insert(pos, self.url)
-                str_feeds = ";".join(self.feeds)
-                self.config.write_content_value("RSS", "feeds", str_feeds)
-        except:
-            # No need for actions. Item wasn't selected.
-            pass
+        selection = widget.get_selection().get_selected()
+        feed = model.get_value(selection[1], 0)
+        url_entry.set_text(feed)
+        url_dialog.set_title(_("Edit feed"))
+        status = url_dialog.run()
+        if status == gtk.RESPONSE_OK:
+            # Update list model
+            model.set_value(selection[1], 0, self.url)
+            # Update configure file
+            pos = self.feeds.index(feed)
+            self.feeds.remove(feed)
+            self.feeds.insert(pos, self.url)
+            str_feeds = ";".join(self.feeds)
+            self.config.write_content_value("RSS", "feeds", str_feeds)
 
     def on_button_open_list_clicked(self, widget):
         """Opens the open feed source dialog"""
@@ -563,54 +526,30 @@
         Rebuild video cache requested
         @param widget: GTK-Widget
         """
-        try:
-            proxy = MessageBusProxy(client_name = "Content Management GUI")
-            proxy.connectToMessageBus()
-            proxy.sendMessage(Message(MessageType.REBUILD_VIDEO_CACHE))
-            proxy.disconnectFromMessageBus()
-        except:
-            # This means that backend is not running. Doesn't matter
-            error = gtk.MessageDialog(None, gtk.DIALOG_MODAL,
-                gtk.MESSAGE_ERROR, gtk.BUTTONS_OK,
-            _("Entertainer backend is not running. Cache cannot be rebuilt."))
-            error.run()
-            error.destroy()
+        proxy = MessageBusProxy(client_name = "Content Management GUI")
+        proxy.connectToMessageBus()
+        proxy.sendMessage(Message(MessageType.REBUILD_VIDEO_CACHE))
+        proxy.disconnectFromMessageBus()
 
     def on_button_music_rebuild_clicked(self, widget):
         """
         Rebuild music cache requested
         @param widget: GTK-Widget
         """
-        try:
-            proxy = MessageBusProxy(client_name = "Content Management GUI")
-            proxy.connectToMessageBus()
-            proxy.sendMessage(Message(MessageType.REBUILD_MUSIC_CACHE))
-            proxy.disconnectFromMessageBus()
-        except:
-            # This means that backend is not running. Doesn't matter
-            error = gtk.MessageDialog(None, gtk.DIALOG_MODAL,
-                gtk.MESSAGE_ERROR, gtk.BUTTONS_OK,
-            _("Entertainer backend is not running. Cache cannot be rebuilt."))
-            error.run()
-            error.destroy()
+        proxy = MessageBusProxy(client_name = "Content Management GUI")
+        proxy.connectToMessageBus()
+        proxy.sendMessage(Message(MessageType.REBUILD_MUSIC_CACHE))
+        proxy.disconnectFromMessageBus()
 
     def on_button_image_rebuild_clicked(self, widget):
         """
         Rebuild image cache requested
         @param widget: GTK-Widget
         """
-        try:
-            proxy = MessageBusProxy(client_name = "Content Management GUI")
-            proxy.connectToMessageBus()
-            proxy.sendMessage(Message(MessageType.REBUILD_IMAGE_CACHE))
-            proxy.disconnectFromMessageBus()
-        except:
-            # This means that backend is not running. Doesn't matter
-            error = gtk.MessageDialog(None, gtk.DIALOG_MODAL,
-                gtk.MESSAGE_ERROR, gtk.BUTTONS_OK,
-            _("Entertainer backend is not running. Cache cannot be rebuilt."))
-            error.run()
-            error.destroy()
+        proxy = MessageBusProxy(client_name = "Content Management GUI")
+        proxy.connectToMessageBus()
+        proxy.sendMessage(Message(MessageType.REBUILD_IMAGE_CACHE))
+        proxy.disconnectFromMessageBus()
 
     def on_button_feed_rebuild_clicked(self, widget):
         """
@@ -624,18 +563,10 @@
         status = dialog.run()
         #If user has ok'd the request send the message to the message bus
         if(status == gtk.RESPONSE_OK):
-            try:
-                proxy = MessageBusProxy(client_name = "Content Management GUI")
-                proxy.connectToMessageBus()
-                proxy.sendMessage(Message(MessageType.REBUILD_FEED_CACHE))
-                proxy.disconnectFromMessageBus()
-            except:
-                # This means that backend is not running. Doesn't matter
-                error = gtk.MessageDialog(None, gtk.DIALOG_MODAL,
-                    gtk.MESSAGE_ERROR, gtk.BUTTONS_OK,
-            _("Entertainer backend is not running. Cache cannot be rebuilt."))
-                error.run()
-                error.destroy()
+            proxy = MessageBusProxy(client_name = "Content Management GUI")
+            proxy.connectToMessageBus()
+            proxy.sendMessage(Message(MessageType.REBUILD_FEED_CACHE))
+            proxy.disconnectFromMessageBus()
         dialog.destroy()
 
     def init_dialog_values_from_configure_file(self):

=== modified file 'entertainerlib/utils/feed_utils.py'
--- entertainerlib/utils/feed_utils.py	2009-02-07 17:12:21 +0000
+++ entertainerlib/utils/feed_utils.py	2009-02-08 07:43:25 +0000
@@ -62,11 +62,8 @@
                     in_tag = False
                     parse_list.pop(i)
                     #check if tag matches
-                    try:
-                        if len(valid_tag_list) > valid_tag_list.index(tag):
-                            output += ("<" + tag + tag_attributes + ">")
-                    except:
-                        pass
+                    if tag in valid_tag_list:
+                        output += ("<" + tag + tag_attributes + ">")
                     tag = ""
                     tag_attributes = ""
                 elif in_tag_name:

=== modified file 'entertainerlib/utils/lyrics_downloader.py'
--- entertainerlib/utils/lyrics_downloader.py	2008-08-07 01:17:29 +0000
+++ entertainerlib/utils/lyrics_downloader.py	2009-02-07 21:43:35 +0000
@@ -48,12 +48,9 @@
         Search lyrics and download if found
         """
         lyrics = ""
-        try:
-            self._clean_up_artist_title()
-            lyrics_xml = self._get_lyrics_xml()
-            lyrics = self._parse_lyrics_xml(lyrics_xml)
-        except:
-            lyrics = None
+        self._clean_up_artist_title()
+        lyrics_xml = self._get_lyrics_xml()
+        lyrics = self._parse_lyrics_xml(lyrics_xml)
         self.callback(lyrics)
 
     def _clean_up_artist_title(self):
@@ -95,10 +92,7 @@
 
     def _parse_lyrics_xml(self, lyrics_xml):
         """Parse lyrics XML and return lyrics string"""
-        try:
-            xmldoc = minidom.parseString(lyrics_xml).documentElement
-        except:
-            raise Exception("Can't get lyrics for this track.")
+        xmldoc = minidom.parseString(lyrics_xml).documentElement
 
         # Get the lyric from the XML file
         lyrics = xmldoc.getElementsByTagName('tx')[0].firstChild.nodeValue

=== modified file 'entertainerlib/utils/preferences_dialog.py'
--- entertainerlib/utils/preferences_dialog.py	2009-02-07 20:28:47 +0000
+++ entertainerlib/utils/preferences_dialog.py	2009-02-07 21:43:35 +0000
@@ -88,15 +88,7 @@
         # If theme was selected with file chooser
         if(status == gtk.RESPONSE_OK):
             package = dialog.get_filename()
-            try:
-                tar = tarfile.open(package, 'r:gz') # Open tar.gz package
-            except:
-                error = gtk.MessageDialog(None, gtk.DIALOG_MODAL,
-                    gtk.MESSAGE_ERROR, gtk.BUTTONS_OK, _("Invalid theme file!"))
-                error.run()
-                error.destroy()
-                dialog.destroy()
-                return
+            tar = tarfile.open(package, 'r:gz') # Open tar.gz package
 
             # Make sure that package contains configuration file (is theme)
             content = tar.getnames()
@@ -213,13 +205,10 @@
 
     def close(self):
         """Close Dialog"""
-        try:
-            proxy = MessageBusProxy(client_name = "Preferences GUI")
-            proxy.connectToMessageBus()
-            proxy.sendMessage(Message(MessageType.PREFERENCES_CFG_UPDATED))
-            proxy.disconnectFromMessageBus()
-        except:
-            pass # This means that backend is not running. Doesn't matter
+        proxy = MessageBusProxy(client_name = "Preferences GUI")
+        proxy.connectToMessageBus()
+        proxy.sendMessage(Message(MessageType.PREFERENCES_CFG_UPDATED))
+        proxy.disconnectFromMessageBus()
 
         if(self.STAND_ALONE):
             self.pref_dialog.hide()
@@ -249,19 +238,16 @@
         themelist_widget.set_model(model)
 
         # Set current theme selected in theme list
-        try:
-            index = model.get_iter_first()
-            unselected = True
-            index_counter = 0
-            while(unselected):
-                name = model.get_value(iter, 0)
-                if name == current_theme:
-                    unselected = False
-                    themelist_widget.set_cursor(index_counter)
-                index = model.iter_next(index)
-                index_counter += 1
-        except:
-            pass # Error in configfile
+        index = model.get_iter_first()
+        unselected = True
+        index_counter = 0
+        while(unselected):
+            name = model.get_value(iter, 0)
+            if name == current_theme:
+                unselected = False
+                themelist_widget.set_cursor(index_counter)
+            index = model.iter_next(index)
+            index_counter += 1
 
         # Checkboxes
         effect_checkbox = self.widgets.get_widget("effect_checkbox")

=== modified file 'entertainerlib/utils/theme.py'
--- entertainerlib/utils/theme.py	2009-02-06 08:13:48 +0000
+++ entertainerlib/utils/theme.py	2009-02-07 21:43:35 +0000
@@ -38,49 +38,45 @@
             print "IOError: Couldn't read theme file."
             sys.exit(1)
 
-        try:
-            # Get theme information
-            self.name = theme.get("Theme", "name")
-            self.comment = theme.get("Theme", "comment")
-            self.author = theme.get("Theme", "author")
-            self.licence = theme.get("Theme", "licence")
-            self.copyright = theme.get("Theme", "copyright")
-
-            #The theme font must be pango compatible font, hence this code
-            #checks the theme font against the pango list generated from a
-            #pango context object and then sets self.font if the font is
-            #compatible. Unfortunately the list can only be generated from a
-            #gtk object at present.
-            self._font = ""
-            tmp_font = theme.get("Theme", "font")
-
-            for font in gtk.TreeView().get_pango_context().list_families():
-                if font.get_name() == tmp_font:
-                    self._font = tmp_font
-
-            if self.font == "":
-                self._font = "Arial"
-
-            # Get theme colors
-            self.color = {}
-            self.color['background'] = theme.get(
-                "Colors", "background").split(',')
-            self.color['title'] = theme.get("Colors", "title").split(',')
-            self.color['subtitle'] = theme.get("Colors", "subtitle").split(',')
-            self.color['screentitle'] = theme.get(
-                "Colors", "screentitle").split(',')
-            self.color['text'] = theme.get("Colors", "text").split(',')
-            self.color['menuitem_active'] = theme.get(
-                "Colors", "menuitem_active").split(',')
-            self.color['menuitem_inactive'] = theme.get(
-                "Colors", "menuitem_inactive").split(',')
-            self.color['arrow_foreground'] = theme.get(
-                "Colors", "arrow_foreground").split(',')
-            self.color['arrow_background'] = theme.get(
-                "Colors", "arrow_background").split(',')
-        except:
-            print "Invalid theme.conf file!"
-            sys.exit(1)
+        # Get theme information
+        self.name = theme.get("Theme", "name")
+        self.comment = theme.get("Theme", "comment")
+        self.author = theme.get("Theme", "author")
+        self.licence = theme.get("Theme", "licence")
+        self.copyright = theme.get("Theme", "copyright")
+
+        #The theme font must be pango compatible font, hence this code
+        #checks the theme font against the pango list generated from a
+        #pango context object and then sets self.font if the font is
+        #compatible. Unfortunately the list can only be generated from a
+        #gtk object at present.
+        self._font = ""
+        tmp_font = theme.get("Theme", "font")
+
+        for font in gtk.TreeView().get_pango_context().list_families():
+            if font.get_name() == tmp_font:
+                self._font = tmp_font
+
+        if self.font == "":
+            self._font = "Arial"
+
+        # Get theme colors
+        self.color = {}
+        self.color['background'] = theme.get(
+            "Colors", "background").split(',')
+        self.color['title'] = theme.get("Colors", "title").split(',')
+        self.color['subtitle'] = theme.get("Colors", "subtitle").split(',')
+        self.color['screentitle'] = theme.get(
+            "Colors", "screentitle").split(',')
+        self.color['text'] = theme.get("Colors", "text").split(',')
+        self.color['menuitem_active'] = theme.get(
+            "Colors", "menuitem_active").split(',')
+        self.color['menuitem_inactive'] = theme.get(
+            "Colors", "menuitem_inactive").split(',')
+        self.color['arrow_foreground'] = theme.get(
+            "Colors", "arrow_foreground").split(',')
+        self.color['arrow_background'] = theme.get(
+            "Colors", "arrow_background").split(',')
 
         # Build the image array : image[name] = filename
         self.image = {}
@@ -164,12 +160,8 @@
     def get_color(self, element):
         """Return color for the element as a tuple of (r, b, g, a)."""
         if self.color.has_key(element):
-            try:
-                color = self.color[element]
-                return (int(color[0]), int(color[1]), int(color[2]),
-                    int(color[3]))
-            except:
-                return (255, 0, 0, 255)
+            color = [int(ele) for ele in self.color[element]]
+            return (color[0], color[1], color[2], color[3])
         else:
             # On error we return bright red.
             return (255, 0, 0, 255)

=== modified file 'entertainerlib/utils/video_thumbnailer.py'
--- entertainerlib/utils/video_thumbnailer.py	2009-02-07 21:53:37 +0000
+++ entertainerlib/utils/video_thumbnailer.py	2009-02-07 22:12:25 +0000
@@ -188,8 +188,7 @@
 
         try:
             duration = self._pipeline.query_duration(gst.FORMAT_TIME)[0]
-        except Exception:
-            ## FIXME: precise this exception
+        except AssertionError:
             #Gstreamer cannot determine the media duration using
             #playing-thumbnailing for file
             self.set_pipeline_state(self._pipeline, gst.STATE_NULL)
@@ -225,7 +224,6 @@
         '''
         Plays the video file to gather information for generating a thumbnail
         '''
-        fileid = None
         self._img = None
 
         if duration >= 250000:
@@ -280,12 +278,8 @@
 
             frame = self._sink.get_current_frame()
 
-            try:
-                img = Image.frombuffer("RGB", sink_size, frame, "raw", "RGB",
-                    0, 1)
-            except:
-                #Invalid frame
-                continue
+            img = Image.frombuffer(
+                "RGB", sink_size, frame, "raw", "RGB", 0, 1)
 
             if self.interesting_image(img):
                 break

=== modified file 'pylintrc'
--- pylintrc	2009-02-07 21:53:37 +0000
+++ pylintrc	2009-02-08 07:01:25 +0000
@@ -56,20 +56,13 @@
 # E1101 and E1103 are broken, as it reports non-existing members when the
 # member is inherited.
 # W0142 checks for * or ** argument magic
+# W0232 checks that in __init__ method is always present
+# W0613 is a warning about unused arguments.
+# W0201 checks for attributes defined outside init
 
-# XXX: rockstar - W0613 is a warning about unused arguments.  This can be a
-# little misleading, since cluttergst needs a few parameters that pylint
-# doesn't see getting used
 # XXX: rockstar - C0103 constrains method and function names to a regex
-# XXX: rockstar - W0702 constrains calls to except to specific Exceptions
-# XXX: rockstar - W0232 ensures that an __init__ method is always present
 # XXX: rockstar - W0511 checks for XXX, TODO, and FIXME
-# XXX: rockstar - W0201 checks for attributes defined outside init
-# XXX: rockstar - W0703 er, I have no idea what it does
-# XXX: rockstar - W0704 checks for empty except
-# XXX: rockstar - W0221 checks for inherited function signatures for similar
-# args
-disable-msg=I0011,R0201,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0923,W0613,C0103,W0702,W0232,W0511,W0201,E1101,W0703,W0704,E1103,W0221,W0142
+disable-msg=I0011,R0201,R0801,R0901,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0923,W0613,C0103,W0232,W0511,W0201,E1101,E1103,W0142
 
 
 [REPORTS]