webbrowser-app

Merge lp:~robru/webbrowser-app/hardening into lp:webbrowser-app

  1. hardening
  2. Merge into trunk
Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 365
Merged at revision: 365
Proposed branch: lp:~robru/webbrowser-app/hardening
Merge into: lp:webbrowser-app
Diff against target: 40 lines (+6/-1)
3 files modified
debian/control (+2/-1)
debian/qtdeclarative5-ubuntu-ui-extras-browser-plugin.lintian-overrides (+3/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp:~robru/webbrowser-app/hardening
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Bruce Park (community) Approve
Review via email: mp+189158@code.launchpad.net

Commit message

Enable hardening, and fix some lintian warnings.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:365
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/464/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4486
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2259
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-ci/348
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/347
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-ci/347/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-ci/347
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/768
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/361
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/361/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2261
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2261/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1932
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1948

Click here to trigger a rebuild:
http://s-jenkins:8080/job/webbrowser-app-ci/464/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Approved by jdstrand here:

https://bugs.launchpad.net/ubuntu/+source/unity-webapps-qml/+bug/1206268/comments/36

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/webbrowser-app-autolanding/307/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4495/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2269
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-amd64-autolanding/251
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-autolanding/251
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-armhf-autolanding/251/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-saucy-i386-autolanding/251
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/777/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/370
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/370/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2271
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2271/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1944
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1958

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-09-24 08:36:47 +0000
3+++ debian/control 2013-10-03 18:31:12 +0000
4@@ -5,6 +5,7 @@
5 Build-Depends: cmake (>= 2.8.9),
6 debhelper (>= 9),
7 dh-translations,
8+ hardening-wrapper,
9 python,
10 libqt5sql5-sqlite,
11 libqt5v8-5-private-dev,
12@@ -50,7 +51,7 @@
13 libqt5sql5-sqlite,
14 libqt5webkit5-qmlwebkitplugin,
15 qtdeclarative5-qtquick2-plugin,
16- qtdeclarative5-ubuntu-ui-extras-browser-plugin-assets (>= ${binary:Version}),
17+ qtdeclarative5-ubuntu-ui-extras-browser-plugin-assets (>= ${source:Version}),
18 qtdeclarative5-ubuntu-ui-toolkit-plugin,
19 qtdeclarative5-unity-action-plugin,
20 qtdeclarative5-window-plugin,
21
22=== added file 'debian/qtdeclarative5-ubuntu-ui-extras-browser-plugin.lintian-overrides'
23--- debian/qtdeclarative5-ubuntu-ui-extras-browser-plugin.lintian-overrides 1970-01-01 00:00:00 +0000
24+++ debian/qtdeclarative5-ubuntu-ui-extras-browser-plugin.lintian-overrides 2013-10-03 18:31:12 +0000
25@@ -0,0 +1,3 @@
26+qtdeclarative5-ubuntu-ui-extras-browser-plugin: pkg-has-shlibs-control-file-but-no-actual-shared-libs
27+qtdeclarative5-ubuntu-ui-extras-browser-plugin: postinst-has-useless-call-to-ldconfig
28+qtdeclarative5-ubuntu-ui-extras-browser-plugin: postrm-has-useless-call-to-ldconfig
29
30=== modified file 'debian/rules'
31--- debian/rules 2013-07-18 14:15:53 +0000
32+++ debian/rules 2013-10-03 18:31:12 +0000
33@@ -4,6 +4,7 @@
34 # Uncomment this to turn on verbose mode.
35 #export DH_VERBOSE=1
36
37+export DEB_BUILD_HARDENING=1
38 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
39
40 %:

Subscribers

People subscribed via source and target branches

to status/vote changes: