Merge lp:~robru/webaccounts-browser-extension/inline-packaging into lp:webaccounts-browser-extension

Proposed by Robert Bruce Park
Status: Merged
Approved by: Víctor R. Ruiz
Approved revision: 33
Merged at revision: 31
Proposed branch: lp:~robru/webaccounts-browser-extension/inline-packaging
Merge into: lp:webaccounts-browser-extension
Diff against target: 370 lines (+302/-1)
12 files modified
.bzr-builddeb/default.conf (+2/-0)
.bzrignore (+0/-1)
debian/changelog (+134/-0)
debian/compat (+1/-0)
debian/control (+52/-0)
debian/copyright (+59/-0)
debian/docs (+2/-0)
debian/rules (+21/-0)
debian/webaccounts-chromium-extension.install (+2/-0)
debian/webaccounts-extension-common.install (+2/-0)
debian/webaccounts.pem (+15/-0)
debian/xul-ext-webaccounts.postinst (+12/-0)
To merge this branch: bzr merge lp:~robru/webaccounts-browser-extension/inline-packaging
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Didier Roche-Tolomelli Approve
Víctor R. Ruiz Pending
Review via email: mp+135463@code.launchpad.net

Description of the change

Inline packaging metadata.

This mp was already approved my mardy, however jenkins got a bit confused so I deleted that one and am resubmitting an identical mp.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

312 +override_dh_auto_install:
313 + install-xpi -p xul-ext-webaccounts firefox-extension/webaccounts-firefox-extension.xpi
314 + dh_auto_install
315 + rm -rf debian/tmp/usr/lib/*/webaccounts-firefox
316 + rm -f debian/tmp/usr/lib/*/*/libwebaccounts.la

I would prefer that we use the now traditional:
override_dh_install:
   install-xpi…
   rm what we want to remove
   dh_install --fail-missing

Do you mind changing that?

review: Needs Fixing
33. By Robert Bruce Park

Fix debian/rules as per didrocks.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

perfect!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.bzr-builddeb'
2=== added file '.bzr-builddeb/default.conf'
3--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
4+++ .bzr-builddeb/default.conf 2012-11-22 16:02:21 +0000
5@@ -0,0 +1,2 @@
6+[BUILDDEB]
7+split = True
8
9=== modified file '.bzrignore'
10--- .bzrignore 2012-09-07 14:26:17 +0000
11+++ .bzrignore 2012-11-22 16:02:21 +0000
12@@ -2,7 +2,6 @@
13 *.gcno
14 *.la
15 *.lo
16-*.pem
17 *.tar.gz
18 Makefile
19 Makefile.in
20
21=== added directory 'debian'
22=== added file 'debian/changelog'
23--- debian/changelog 1970-01-01 00:00:00 +0000
24+++ debian/changelog 2012-11-22 16:02:21 +0000
25@@ -0,0 +1,134 @@
26+webaccounts-browser-extension (0.4.6-0ubuntu1) raring; urgency=low
27+
28+ * Inline packaging metadata.
29+
30+ -- Robert Bruce Park <robert.park@canonical.com> Tue, 20 Nov 2012 15:44:39 -0600
31+
32+webaccounts-browser-extension (0.4.5-0ubuntu4) raring; urgency=low
33+
34+ * debian/control
35+ - build depend on vim-common, it is required
36+
37+ -- Ken VanDine <ken.vandine@canonical.com> Thu, 15 Nov 2012 12:22:18 -0500
38+
39+webaccounts-browser-extension (0.4.5-0ubuntu3) raring; urgency=low
40+
41+ * debian/control
42+ - Move the depends for gnome-control-center-signon to the -common package
43+ instead of specifying it multiple times.
44+ - Don't build depend on vim-common
45+ * debian/copyright
46+ - Updated to add license/copyright for lib/*
47+
48+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 14 Nov 2012 13:58:52 -0500
49+
50+webaccounts-browser-extension (0.4.5-0ubuntu2) raring; urgency=low
51+
52+ * debian/rules
53+ - enable tests
54+ * debian/compat, debian/control
55+ - dh 9
56+
57+ -- Ken VanDine <ken.vandine@canonical.com> Thu, 08 Nov 2012 16:13:39 -0500
58+
59+webaccounts-browser-extension (0.4.5-0ubuntu1) raring; urgency=low
60+
61+ * New upstream release.
62+ - Do not load the libwebaccounts library more than once (LP: #1066917)
63+
64+ -- Ken VanDine <ken.vandine@canonical.com> Thu, 08 Nov 2012 12:44:23 -0500
65+
66+webaccounts-browser-extension (0.4.4-0ubuntu1) quantal; urgency=low
67+
68+ * New upstream release.
69+ - Don't use npapi plugin for firefox
70+ - install library as a private lib
71+
72+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 10 Sep 2012 14:41:04 -0400
73+
74+webaccounts-browser-extension (0.4.2-0ubuntu1) quantal; urgency=low
75+
76+ * New upstream release.
77+ - Don't add any symbols to the main window global scope (LP: #1037706)
78+ - Don't leak the browser chrome window (LP: #1037707)
79+ - Don't import XPCOMUtils.jsm, it's not used anywhere
80+ - Get the cookiemanager from Services.jsm
81+ - Updated names and descriptions to be consistent between firefox and
82+ chromium extensions (LP: #1025462)
83+
84+ -- Ken VanDine <ken.vandine@canonical.com> Fri, 17 Aug 2012 16:40:48 -0400
85+
86+webaccounts-browser-extension (0.4.1-0ubuntu3) quantal; urgency=low
87+
88+ * debian/rules
89+ - enable firefox extension build
90+ * debian/control
91+ - add the xul-ext-webaccounts binary
92+
93+ -- Ken VanDine <ken.vandine@canonical.com> Thu, 16 Aug 2012 12:57:59 -0400
94+
95+webaccounts-browser-extension (0.4.1-0ubuntu2) quantal; urgency=low
96+
97+ * debian/rules
98+ - bump dbus-test-runner timeout to 180
99+
100+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 15 Aug 2012 17:19:21 -0400
101+
102+webaccounts-browser-extension (0.4.1-0ubuntu1) quantal; urgency=low
103+
104+ * New upstream release
105+ * debian/watch
106+ - added
107+ * debian/control
108+ - added dbus-test-runner build depends
109+ * debian/patches/tests_gsettings_fix.patch
110+ - setup GSETTINGS_SCHEMA_DIR for tests
111+ * debian/rules
112+ - compile gsettings schemas for tests
113+
114+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 15 Aug 2012 16:56:41 -0400
115+
116+webaccounts-browser-extension (0.2+bzr13-0quantal2) quantal; urgency=low
117+
118+ * Added gtest build dep
119+
120+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 16 Jul 2012 16:51:06 -0400
121+
122+webaccounts-browser-extension (0.2+bzr13-0quantal1) quantal; urgency=low
123+
124+ * rebuild for quantal
125+
126+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 16 Jul 2012 10:30:02 -0400
127+
128+webaccounts-browser-extension (0.2+bzr13-0precise1) precise; urgency=low
129+
130+ * New snapshot from tag 0.2+bzr13
131+
132+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 11 Jul 2012 10:26:00 -0400
133+
134+webaccounts-browser-extension (0.1-0precise4) precise; urgency=low
135+
136+ * no change rebuild
137+
138+ -- Ken VanDine <ken.vandine@canonical.com> Fri, 15 Jun 2012 16:45:31 -0400
139+
140+webaccounts-browser-extension (0.1-0precise3) precise; urgency=low
141+
142+ * debian/control
143+ - make both browser extensions depend on gnome-control-center-signon,
144+ they require it via dbus
145+
146+ -- Ken VanDine <ken.vandine@canonical.com> Thu, 14 Jun 2012 16:54:19 -0400
147+
148+webaccounts-browser-extension (0.1-0precise2) precise; urgency=low
149+
150+ * chromium-extension/manifest.json.in
151+ - use the .so
152+
153+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 11 Jun 2012 15:27:37 -0400
154+
155+webaccounts-browser-extension (0.1-0precise1) precise; urgency=low
156+
157+ * Initial package
158+
159+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 04 Jun 2012 11:15:08 -0400
160
161=== added file 'debian/compat'
162--- debian/compat 1970-01-01 00:00:00 +0000
163+++ debian/compat 2012-11-22 16:02:21 +0000
164@@ -0,0 +1,1 @@
165+9
166
167=== added file 'debian/control'
168--- debian/control 1970-01-01 00:00:00 +0000
169+++ debian/control 2012-11-22 16:02:21 +0000
170@@ -0,0 +1,52 @@
171+Source: webaccounts-browser-extension
172+Priority: optional
173+Maintainer: Ubuntu Desktop Team <ubuntu-desktop@lists.ubuntu.com>
174+Build-Depends: autotools-dev,
175+ dbus-test-runner,
176+ debhelper (>= 9),
177+ dh-autoreconf,
178+ gnome-common,
179+ libaccounts-glib-dev (>= 1.1+bzr153),
180+ libglib2.0-dev,
181+ libgtest-dev,
182+ libjson-glib-dev,
183+ mozilla-devscripts,
184+ openssl,
185+ pkg-config,
186+ vim-common,
187+ zip,
188+Standards-Version: 3.9.3
189+Section: web
190+Homepage: https://launchpad.net/webaccounts-browser-extension
191+# If you aren't a member of ~online-accounts but need to upload packaging changes,
192+# just go ahead. ~online-accounts will notice and sync up the code again.
193+Vcs-Bzr: https://code.launchpad.net/~online-accounts/webaccounts-browser-extension/trunk
194+
195+Package: webaccounts-extension-common
196+Architecture: any
197+Depends: gnome-control-center-signon, ${misc:Depends}, ${shlibs:Depends}
198+Description: Ubuntu Online Accounts browser extension - common files
199+ Common files needed by the Ubuntu Online Accounts integration Chromium
200+ and Firefox extensions
201+
202+Package: webaccounts-chromium-extension
203+Architecture: any
204+Depends: chromium-browser,
205+ webaccounts-extension-common (= ${binary:Version}),
206+ ${misc:Depends},
207+Breaks: libwebaccounts-chromium
208+Replaces: libwebaccounts-chromium
209+Description: Ubuntu Online Accounts extension for chromium
210+ Chromium extension to allow integraton with Ubuntu Online Accounts
211+
212+Package: xul-ext-webaccounts
213+Architecture: any
214+Depends: webaccounts-extension-common (= ${binary:Version}),
215+ ${misc:Depends},
216+ ${xpi:Depends},
217+Enhances: ${xpi:Enhances}
218+Provides: ${xpi:Provides}
219+Recommends: ${xpi:Recommends}
220+Breaks: ${xpi:Breaks}
221+Description: Ubuntu Online Accounts extension for firefox
222+ Firefox extension to allow integraton with Ubuntu Online Accounts
223
224=== added file 'debian/copyright'
225--- debian/copyright 1970-01-01 00:00:00 +0000
226+++ debian/copyright 2012-11-22 16:02:21 +0000
227@@ -0,0 +1,59 @@
228+Format: http://dep.debian.net/deps/dep5
229+Upstream-Name: online-accounts-browser-extension
230+Source: https://launchpad.net/online-accounts-browser-extension
231+
232+Files: *
233+Copyright: Copyright (C) Canonical LTD 2012
234+License: GPL-3
235+ On Debian systems, the complete text of the GNU General
236+ Public License version 3 can be found in `/usr/share/common-licenses/GPL-3'.
237+
238+Files: lib/*
239+Copyright: 2012 Canonical Ltd
240+License: GPL-2+
241+
242+Files: npapi-plugin/*
243+Copyright: 2012 Canonical Ltd
244+License: GPL-2+
245+
246+Files: npapi-plugin/src/npapi-headers/headers/nptypes.h
247+Copyright: 2004 mozilla.org
248+License: GPL-2+
249+
250+Files: npapi-plugin/src/npapi-headers/headers/npapi.h
251+ npapi-plugin/src/npapi-headers/headers/npfunctions.h
252+Copyright: 1998 Netscape Communications Corporation
253+License: GPL-2+
254+
255+Files: npapi-plugin/src/npapi-headers/headers/npruntime.h
256+Copyright: 2004 Apple Computer, Inc.
257+License:
258+ Redistribution and use in source and binary forms, with or without
259+ modification, are permitted provided that the following conditions are
260+ met:
261+ .
262+ 1. Redistributions of source code must retain the above copyright
263+ notice, this list of conditions and the following disclaimer.
264+ 2. Redistributions in binary form must reproduce the above copyright
265+ notice, this list of conditions and the following disclaimer in the
266+ documentation and/or other materials provided with the distribution.
267+ 3. Neither the names of Apple Computer, Inc. ("Apple") or The Mozilla
268+ Foundation ("Mozilla") nor the names of their contributors may be used
269+ to endorse or promote products derived from this software without
270+ specific prior written permission.
271+ .
272+ THIS SOFTWARE IS PROVIDED BY APPLE, MOZILLA AND THEIR CONTRIBUTORS "AS
273+ IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
274+ TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
275+ PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE, MOZILLA OR
276+ THEIR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
277+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED
278+ TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
279+ PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
280+ LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
281+ NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
282+ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
283+
284+License: GPL-2+
285+ On Debian systems, the complete text of the GNU General
286+ Public License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
287
288=== added file 'debian/docs'
289--- debian/docs 1970-01-01 00:00:00 +0000
290+++ debian/docs 2012-11-22 16:02:21 +0000
291@@ -0,0 +1,2 @@
292+NEWS
293+README
294
295=== added file 'debian/rules'
296--- debian/rules 1970-01-01 00:00:00 +0000
297+++ debian/rules 2012-11-22 16:02:21 +0000
298@@ -0,0 +1,21 @@
299+#!/usr/bin/make -f
300+# -*- makefile -*-
301+# Uncomment this to turn on verbose mode.
302+#export DH_VERBOSE=1
303+export DPKG_GENSYMBOLS_CHECK_LEVEL=4
304+
305+override_dh_autoreconf:
306+ cp debian/webaccounts.pem .
307+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
308+
309+override_dh_install:
310+ install-xpi -p xul-ext-webaccounts firefox-extension/webaccounts-firefox-extension.xpi
311+ rm -rf debian/tmp/usr/lib/*/webaccounts-firefox
312+ rm -f debian/tmp/usr/lib/*/*/libwebaccounts.la
313+ dh_install --fail-missing
314+
315+override_dh_auto_test:
316+ dbus-test-runner -t make -p check -m 180
317+
318+%:
319+ dh $@ --with xul-ext,autoreconf
320
321=== added file 'debian/webaccounts-chromium-extension.install'
322--- debian/webaccounts-chromium-extension.install 1970-01-01 00:00:00 +0000
323+++ debian/webaccounts-chromium-extension.install 2012-11-22 16:02:21 +0000
324@@ -0,0 +1,2 @@
325+usr/lib/*/webaccounts-chromium/*.crx
326+usr/share/chromium/extensions
327
328=== added file 'debian/webaccounts-extension-common.install'
329--- debian/webaccounts-extension-common.install 1970-01-01 00:00:00 +0000
330+++ debian/webaccounts-extension-common.install 2012-11-22 16:02:21 +0000
331@@ -0,0 +1,2 @@
332+usr/lib/*/webaccounts-browser-extension
333+usr/share/glib-2.0/schemas
334
335=== added file 'debian/webaccounts.pem'
336--- debian/webaccounts.pem 1970-01-01 00:00:00 +0000
337+++ debian/webaccounts.pem 2012-11-22 16:02:21 +0000
338@@ -0,0 +1,15 @@
339+-----BEGIN RSA PRIVATE KEY-----
340+MIICXAIBAAKBgQDDkeiTu8AJ32tEHdtsPV3zzd6qKc2xIMu6MkfyADxssTvshm1W
341+uSyWQPEOpoyklDD4XtjjlhrOgh1DTslCv/uz0+fi7P2M+IRWzRQynRcbA9OUkdHt
342+TKhXgVkY+5iNSPxVLtObY5KxLqXu9EDmeFFvK3j/XiIEj0FOMZBrV6NYiwIDAQAB
343+AoGAPexiNvzYxod+gFfv1SrtJ7hEy55m6bHXsAIhs6eNemD392FtF2uUiZLQgPIN
344+UEM36jyl8hHiNQcP2vMEWOVO/cjQmM3mSkVTHav1bgFv/UolXQZ6XuO5jg28p3fa
345+C4gjTqCMtfcRV5+TU9nPHR+dU6T8b2VyblrUL0amN9B76jECQQDngF5lhwvnCI90
346+sIwDy3fplUGRBB7nsJhSgSi3VGkFsVQq80pv8WAzsi/8Awy/x0nQjldTb7srkxkc
347+K90e6tOTAkEA2EQdq+eOXBdoKpG9x/15jPebm13CYJIFSgZlb1b8y5qRDGvjTipx
348+c55Yf7lqjsYvipwKuZWbLclyFBqKqPByKQJAU8CvZg/LkJQaQl806JKOGWW0SOCy
349+xaOwF/k+X8UcEcEr8DYAsisjYNCQZ5462I8i917n3PnJP2SCaxy7bNoMHQJBAMy0
350+3Skky5ncBhuVTICLK40Fq2MLAryKOztwhn83ZZ4LtpR9YvFQN4drMPXlOjne2o1n
351+WreEJxjV/4eMAAgdYNECQGw1H3AVMrrRPNoneX4ryT2NiuTILGmTVIFeTM2Y/p1Q
352+2+ISRM2Vjdz7wvnpwYNfxflM5PHV/wJnlUwE+mnnAHY=
353+-----END RSA PRIVATE KEY-----
354
355=== added file 'debian/xul-ext-webaccounts.postinst'
356--- debian/xul-ext-webaccounts.postinst 1970-01-01 00:00:00 +0000
357+++ debian/xul-ext-webaccounts.postinst 2012-11-22 16:02:21 +0000
358@@ -0,0 +1,12 @@
359+#!/bin/sh
360+
361+set -e
362+
363+echo "Please restart all running instances of firefox, or you will experience problems."
364+
365+if [ -d /var/run ] ; then
366+ touch /var/run/firefox-restart-required
367+fi
368+
369+#DEBHELPER#
370+

Subscribers

People subscribed via source and target branches