YahooNews WebApp

Merge lp:~robru/unity-webapps-yahoonews/const-to-var into lp:unity-webapps-yahoonews

  1. const-to-var
  2. Merge into trunk
Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 47
Merged at revision: 47
Proposed branch: lp:~robru/unity-webapps-yahoonews/const-to-var
Merge into: lp:unity-webapps-yahoonews
Diff against target: 21 lines (+2/-2)
1 file modified
YahooNews.user.js (+2/-2)
To merge this branch: bzr merge lp:~robru/unity-webapps-yahoonews/const-to-var
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Víctor R. Ruiz Pending
Review via email: mp+169318@code.launchpad.net

Commit message

Replace 'const' with 'var'.

Description of the change

Seems this one got overlooked by Victor. I didn't see an MP for it yet.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:47
http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-ci/2/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-armhf-ci/2

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-yahoonews-ci/2/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'YahooNews.user.js'
2--- YahooNews.user.js 2013-06-12 00:42:38 +0000
3+++ YahooNews.user.js 2013-06-14 00:32:28 +0000
4@@ -6,7 +6,7 @@
5 // ==/UserScript==
6
7 // This placeholder gets munged with real data at build time.
8-const WebappsGettextDict = JSON.parse(unescape(
9+var WebappsGettextDict = JSON.parse(unescape(
10 "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"
11 ));
12
13@@ -23,7 +23,7 @@
14 function messagingIndicatorSetup() {
15 var i, res = document.evaluate('//*[@id="mediatabs"]/div[@class="bd"]/div/div/div/div/div/div[@class="bd"]/ul/li/div/a', document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
16 if (!res.snapshotLength) {
17- res = document.evaluate('//*[@id="mediamegatron"]/div[@class="bd"]/div[@class="feature"]/div[@class="meta"]/div[@class="bd"]/a', document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
18+ res = document.evaluate('//*[@id="mediamegatron"]/div[@class="bd"]/div[@class="feature"]/div[@class="meta"]/div[@class="bd"]/a', document, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
19 }
20
21 if (!res.snapshotLength) {

Subscribers

People subscribed via source and target branches

to all changes: