Merge lp:~robru/unity-webapps-twitter/packaging-fixups into lp:unity-webapps-twitter

[Robert Bruce Park]

Minor packaging fixups.

[lp:~robru/unity-webapps-twitter/packaging-fixups]

15. By Robert Bruce Park on 2013-06-17

Replace const with var.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:14
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-saucy-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-saucy-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-twitter-ci/8/rebuild

review: Needs Fixing (continuous-integration)

[lp:~robru/unity-webapps-twitter/packaging-fixups]

16. By Robert Bruce Park on 2013-06-17

Appease jslint.

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:15
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-saucy-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-saucy-armhf-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-twitter-ci/9/rebuild

review: Approve (continuous-integration)

=== modified file 'Twitter.user.js'
--- Twitter.user.js	2013-05-02 23:53:10 +0000
+++ Twitter.user.js	2013-06-17 23:19:24 +0000
@@ -4,27 +4,12 @@
 // ==/UserScript==
 
 // This placeholder gets munged with real data at build time.
-const WebappsGettextDict = JSON.parse(unescape(
+var WebappsGettextDict = JSON.parse(unescape(
     "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"
 ));
 
 window.Unity = external.getUnityObject(1);
 
-/**
- * Validates the page for functional tests.
- *
- */
-function selfTest() {
-    if (!getProfileLinkNode() || !getProfileLinkNode().href) {
-        return;
-    }
-    if (!checkMessagesCount().length) {
-        return;
-    }
-
-    reportTestState('PASS SELF TEST');
-};
-
 function getProfileLinkNode() {
     return document.evaluate('//a[@data-nav="profile"]', document, null, XPathResult.ANY_UNORDERED_NODE_TYPE, null).singleNodeValue;
 }
@@ -68,6 +53,21 @@
     return indicators;
 }
 
+/**
+ * Validates the page for functional tests.
+ *
+ */
+function selfTest() {
+    if (!getProfileLinkNode() || !getProfileLinkNode().href) {
+        return;
+    }
+    if (!checkMessagesCount().length) {
+        return;
+    }
+
+    reportTestState('PASS SELF TEST');
+}
+
 function messagingIndicatorSetup() {
     var indicatorsController = new Indicators(checkMessagesCount, true);
     indicatorsController.visited(currentIndicator);

=== modified file 'debian/control'
--- debian/control	2013-05-15 07:21:10 +0000
+++ debian/control	2013-06-17 23:19:24 +0000
@@ -1,17 +1,21 @@
 Source: unity-webapps-twitter
 Section: web
-Priority: extra
+Priority: optional
 Standards-Version: 3.9.4
 Maintainer: Ubuntu Developers <[e-mail]>
 Build-Depends: debhelper (>=9),
                unity-webapps-dev (>=2.4.16),
 Homepage: https://twitter.com/
+# If you aren't a member of ~webapps but need to upload packaging changes,
+# just go ahead.  ~webapps will notice and sync up the code again.
+Vcs-Bzr: https://code.launchpad.net/~webapps/unity-webapps-twitter/trunk
 
 Package: unity-webapps-twitter
 Architecture: all
 Section: web
-Priority: extra
-Depends: unity-webapps-common, xdg-utils, ${misc:Depends}
+Depends: unity-webapps-common,
+         xdg-utils,
+         ${misc:Depends},
 XB-Ubuntu-Webapps-Includes: https://twitter.com/*
 XB-Ubuntu-Webapps-Name: Twitter
 XB-Ubuntu-Webapps-Domain: twitter.com

=== modified file 'debian/copyright'
--- debian/copyright	2013-05-02 23:53:10 +0000
+++ debian/copyright	2013-06-17 23:19:24 +0000
@@ -22,11 +22,6 @@
   The full text of the can be found in the file
   '/usr/share/common-licenses/GPL-3'.
 
-Files: debian/*
-Copyright: 2012 The friendly pkgme.net robot
-License: public-domain
- This automatically generated code which is free from copyright restrictions.
-
 
 Files: */*.png */*.svg
 Copyright: various