Merge lp:~robru/unity-webapps-twitter/add-manifest into lp:unity-webapps-twitter

[Robert Bruce Park]

Took a stab at making the missing manifest.json for Twitter, not sure how correct it is though.

Come on, jenkins! You can do it!

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:5
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-twitter-ci/1/rebuild

review: Needs Fixing (continuous-integration)

[Robert Bruce Park (robru)]

Jenkins is still confused about rules.mk because it doesn't have the right PPA enabled in order to run it's ci tests. I guess victor will need to fix that.

[Alexandre Abreu (abreu-alexandre)]

Check out the manifest.js script in webapps-applications it basically does that for you ... (although it might need to be tweaked to account for the splitted environment), it is not currently being used nor distributed,

[Alexandre Abreu (abreu-alexandre)]

review: Approve

[Robert Bruce Park (robru)]

manifest.json not being used? erk, well maybe we should delete them then? I guess all the same info is in debian/control and within the script itself, right?

Because you're wrong about them not being distributed, all 41 debian/install files try to install manifest.json into the system, and that is what caused the build failure that this branch aims to fix...

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-autolanding/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-amd64-autolanding/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-armhf-autolanding/1/console

review: Needs Fixing (continuous-integration)

[Víctor R. Ruiz (vrruiz)]

Please, resubmit to rebuild.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:5
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-ci/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-twitter-ci/2/rebuild

review: Needs Fixing (continuous-integration)

[Alexandre Abreu (abreu-alexandre)]

review: Approve

[Alexandre Abreu (abreu-alexandre)]

(Just for the sake of completeness), I said "manifest.js" not being used not "manifest.json" ... manifest.js is a simple script that is used to generate a manifest.json out of a user script file,

[Robert Bruce Park (robru)]

Oh, sorry I misread about manifest.json/js.

[Alexandre Abreu (abreu-alexandre)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:5
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~robru/unity-webapps-twitter/add-manifest/+merge/163168/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-armhf-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-twitter-ci/3/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

=== added file 'manifest.json'
--- manifest.json	1970-01-01 00:00:00 +0000
+++ manifest.json	2013-05-09 15:58:25 +0000
@@ -0,0 +1,1 @@
+{"includes":["https://twitter.com/*"],"requires":["utils.js"],"name":"Twitter","scripts":["Twitter.user.js"],"maintainer":"Webapps Team <[e-mail]>","license":"GPL-3","manifest-version":"1.0","integration-version":"2.4.8","package-name":"Twitter","description":"Unity Webapp for Twitter","icons":{"128":"128/unity-webapps-twitter.png","48":"48/unity-webapps-twitter.png","52":"52/unity-webapps-twitter.png","64":"64/unity-webapps-twitter.png"},"domain":"twitter.com","homepage":"https://twitter.com"}