Merge lp:~robru/unity-webapps-cuttherope/require-utils into lp:unity-webapps-cuttherope

Proposed by Robert Bruce Park
Status: Superseded
Proposed branch: lp:~robru/unity-webapps-cuttherope/require-utils
Merge into: lp:unity-webapps-cuttherope
Diff against target: 10 lines (+1/-0)
1 file modified
CutTheRope.user.js (+1/-0)
To merge this branch: bzr merge lp:~robru/unity-webapps-cuttherope/require-utils
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Francis Ginther Pending
Didier Roche-Tolomelli Pending
Alexandre Abreu Pending
Review via email: mp+162701@code.launchpad.net

This proposal has been superseded by a proposal from 2013-05-08.

Commit message

Require utils.js

Description of the change

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Ugh! Not rules.mk again! This error is because jenkins is missing the build-dep from the PPA.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I think you need to check with vrruiz, they should include the dest ppa, which is next.

Revision history for this message
VĂ­ctor R. Ruiz (vrruiz) wrote :

Robert: ppa:webapps/staging has been added as jenkins hook. Please, resubmit.

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Mmmh why would you need the require when you don't really use any of it? ... I am not sure jslint supports const (which is not EcmaScript5), ...

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CutTheRope.user.js'
2--- CutTheRope.user.js 2013-05-03 23:10:57 +0000
3+++ CutTheRope.user.js 2013-05-07 03:34:30 +0000
4@@ -1,5 +1,6 @@
5 // ==UserScript==
6 // @include http://*.cuttherope.ie/*
7+// @require utils.js
8 // ==/UserScript==
9
10 // This placeholder gets munged with real data at build time.

Subscribers

People subscribed via source and target branches

to all changes: