Merge lp:~robru/uci-engine/mark-ticket-ready-for-assignment into lp:uci-engine

Proposed by Robert Bruce Park
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp:~robru/uci-engine/mark-ticket-ready-for-assignment
Merge into: lp:uci-engine
Diff against target: 34 lines (+5/-1)
2 files modified
tests/test_webui.py (+2/-0)
webui/tickets/static/tickets/webuiforms.js (+3/-1)
To merge this branch: bzr merge lp:~robru/uci-engine/mark-ticket-ready-for-assignment
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Disapprove
Celso Providelo Pending
Review via email: mp+251663@code.launchpad.net

Commit message

Allow editing the assignable state.

Description of the change

To post a comment you must log in.
925. By Robert Bruce Park

Reorder steps here.

926. By Robert Bruce Park

Ah, there's that

Revision history for this message
Robert Bruce Park (robru) wrote :
Revision history for this message
Robert Bruce Park (robru) wrote :

Rejecting because we decided in Austin not to proceed with "CI Engine as Spreadsheet Replacement"

review: Disapprove

Unmerged revisions

926. By Robert Bruce Park

Ah, there's that

925. By Robert Bruce Park

Reorder steps here.

924. By Robert Bruce Park

Allow editing the assignable state.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test_webui.py'
2--- tests/test_webui.py 2015-01-13 17:44:27 +0000
3+++ tests/test_webui.py 2015-04-02 18:12:22 +0000
4@@ -342,6 +342,8 @@
5 bug = get_element_by_css('input[name="bug_id"]')
6 write_textfield(bug, '')
7 submit = get_element_by_css('input[type="submit"]')
8+ assignable = get_element_by_css('input[name="assignable"]')
9+ set_checkbox_value(assignable, True)
10 click_button(submit, wait=True)
11
12 # The ticket has a new title and cleared bug reference.
13
14=== modified file 'webui/tickets/static/tickets/webuiforms.js'
15--- webui/tickets/static/tickets/webuiforms.js 2014-12-19 21:01:56 +0000
16+++ webui/tickets/static/tickets/webuiforms.js 2015-04-02 18:12:22 +0000
17@@ -122,7 +122,7 @@
18 _mangleFormAssignable: function (form_data) {
19 if (form_data['assignable']) {
20 form_data['current_workflow_step'] = 'Silo creating';
21- form_data['status'] = 'In progress';
22+ form_data['status'] = 'New';
23 };
24 delete form_data['assignable'];
25 return form_data;
26@@ -306,6 +306,8 @@
27 type: 'TextareaField'},
28 {name: 'comments', label: 'Comments:',
29 type: 'TextareaField'},
30+ {name: 'assignable', label: 'Ready to assign:',
31+ type: 'CheckboxField'},
32 {name: 'edit-button', type: 'SubmitButton',
33 value: 'Update!'}
34 ]

Subscribers

People subscribed via source and target branches