Merge lp:~robru/uci-engine/experimentation into lp:uci-engine

[Robert Bruce Park]

Add silo assignment/reconfigure support.

[lp:~robru/uci-engine/experimentation]

927. By Robert Bruce Park on 2015-04-02

Initial attempt at silo assign/reconfigure links.

[Ursula Junque (ursinha)]

Hey Robert :) I have a couple of questions below, forgive me for the potentially silly questions, I'm catching up to review this to you. Do you have a deployment on bootstack where you are testing this?

[Robert Bruce Park (robru)]

Hi Ursula! Thanks for taking a look. Yeah I did manage to get this deployed on bootstack and so this code sort of "looks right" when I run it but I really need some guidance on if I'm doing things correctly.

[Robert Bruce Park (robru)]

Rejecting because we decided in Austin not to proceed with "CI Engine as Spreadsheet Replacement"

review: Disapprove

Unmerged revisions

927. By Robert Bruce Park on 2015-04-02

Initial attempt at silo assign/reconfigure links.

926. By Robert Bruce Park on 2015-03-03

Ah, there's that

925. By Robert Bruce Park on 2015-03-03

Reorder steps here.

924. By Robert Bruce Park on 2015-03-03

Allow editing the assignable state.

=== modified file 'tests/test_webui.py'
--- tests/test_webui.py	2015-01-13 17:44:27 +0000
+++ tests/test_webui.py	2015-04-02 18:12:47 +0000
@@ -342,6 +342,8 @@
         bug = get_element_by_css('input[name="bug_id"]')
         write_textfield(bug, '')
         submit = get_element_by_css('input[type="submit"]')
+        assignable = get_element_by_css('input[name="assignable"]')
+        set_checkbox_value(assignable, True)
         click_button(submit, wait=True)
 
         # The ticket has a new title and cleared bug reference.

=== modified file 'webui/tickets/static/tickets/webui.js'
--- webui/tickets/static/tickets/webui.js	2015-01-09 12:45:26 +0000
+++ webui/tickets/static/tickets/webui.js	2015-04-02 18:12:47 +0000
@@ -414,6 +414,46 @@
             workflow_inner_div = workflow_wrapper.appendChild(
                 Y.Node.create("<div class='workflow'></div>"));
 
+            // Create links for assigning and reconfiguring.
+            console.log(data);
+
+            // Let's play "how many places can we hard-code this rubbish?"
+            var KNOWN_DISTROS = {
+                "vivid": "ubuntu",
+                "trusty": "ubuntu",
+                "utopic": "ubuntu",
+                "14.09": "ubuntu-rtm",
+            };
+            var sources = "";
+            data.subticket.forEach(function(subticket) {
+                if (!subticket.merge_proposals) {
+                    sources += subticket.sourcepackage.name + " ";
+                }
+            });
+            var merges = "";
+            data.subticket.forEach(function(subticket) {
+                subticket.merge_proposals.forEach(function(mp) {
+                    merges += mp.lp_url + " ";
+                });
+            });
+            var parameters = {
+                "REQUEST_ID": data.uuid,
+                "DISTRIBUTION": KNOWN_DISTROS[data.series],
+                "SERIES": data.series,
+                "LANDERS": data.citrain_overlay.landers,
+                "SOURCES": sources.trim(),
+                "MERGE_PROPOSALS": merges.trim(),
+                "SYNC_REQUEST": data.citrain_overlay.sync_request,
+            };
+
+            var paramstr = encodeURIComponent(Object.keys(parameters).map(function(key) {
+                return key + '=' + encodeURIComponent(parameters[key]);
+            }).join('&'));
+
+            workflow_wrapper.appendChild('<p><a href="https://ci-train.ubuntu.com/securityRealm/commenceLogin?from=/job/prepare-silo/parambuild%3F' + paramstr + '" target="_blank">Assign silo</a></p>');
+            workflow_wrapper.appendChild('<p><a href="http://ci-train.staging.ubuntu.com/securityRealm/commenceLogin?from=/job/prepare-silo/parambuild%3F' + paramstr + '" target="_blank">Assign silo in staging</a></p>');
+            workflow_wrapper.appendChild('<p><a href="https://ci-train.ubuntu.com/securityRealm/commenceLogin?from=/job/ubuntu-landing-000-0-reconfigure/parambuild%3F' + paramstr + '" target="_blank">Reconfigure Silo</a></p>');
+
             // Build and render the ticket status datatable.
             var dt_status = Y.webui.get_ticket_status_datatable(data);
             dt_status.render(workflow_inner_div);

=== modified file 'webui/tickets/static/tickets/webuiforms.js'
--- webui/tickets/static/tickets/webuiforms.js	2014-12-19 21:01:56 +0000
+++ webui/tickets/static/tickets/webuiforms.js	2015-04-02 18:12:47 +0000
@@ -122,7 +122,7 @@
         _mangleFormAssignable: function (form_data) {
             if (form_data['assignable']) {
                 form_data['current_workflow_step'] = 'Silo creating';
-                form_data['status'] = 'In progress';
+                form_data['status'] = 'New';
             };
             delete form_data['assignable'];
             return form_data;
@@ -306,6 +306,8 @@
                      type: 'TextareaField'},
                     {name: 'comments', label: 'Comments:',
                      type: 'TextareaField'},
+                    {name: 'assignable', label: 'Ready to assign:',
+                     type: 'CheckboxField'},
                     {name: 'edit-button', type: 'SubmitButton',
                      value: 'Update!'}
                 ]