Merge lp:~robru/ubuntu-settings-components/packaging into lp:~registry/ubuntu-settings-components/trunk

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 54
Merged at revision: 49
Proposed branch: lp:~robru/ubuntu-settings-components/packaging
Merge into: lp:~registry/ubuntu-settings-components/trunk
Diff against target: 299 lines (+240/-1)
10 files modified
.bzr-builddeb/default.conf (+2/-0)
CMakeLists.txt (+8/-1)
COPYING (+165/-0)
debian/changelog (+5/-0)
debian/compat (+1/-0)
debian/control (+30/-0)
debian/copyright (+22/-0)
debian/qtdeclarative5-ubuntu-settings-components-assets.install (+1/-0)
debian/qtdeclarative5-ubuntu-settings-components.install (+1/-0)
debian/rules (+5/-0)
To merge this branch: bzr merge lp:~robru/ubuntu-settings-components/packaging
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Didier Roche-Tolomelli (community) Approve
Robert Bruce Park (community) Approve
Mathieu Trudel-Lapierre (community) Approve
Andrea Cimitan Pending
Registry Administrators Pending
Review via email: mp+178964@code.launchpad.net

Commit message

Inline packaging.

Description of the change

First stab at packaging. Here are the lintian warnings thus far:

W: ubuntu-settings-components: unknown-section unity

(wasn't sure what section to put it in; saw unity was used in some other packages, but apparently this in invalid. Maybe it should just be misc? no idea)

W: ubuntu-settings-components: image-file-in-usr-lib usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/SettingsComponents/MediaPlayer/DoubleLeftArrow@18.png
W: ubuntu-settings-components: image-file-in-usr-lib usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/SettingsComponents/MediaPlayer/DoubleRightArrow@18.png
W: ubuntu-settings-components: image-file-in-usr-lib usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/SettingsComponents/MediaPlayer/RightArrow@18.png
W: ubuntu-settings-components: image-file-in-usr-lib usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/SettingsComponents/MediaPlayer/electric.jpg
W: ubuntu-settings-components: image-file-in-usr-lib usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/SettingsComponents/MediaPlayer/speak-now.jpg
W: ubuntu-settings-components: image-file-in-usr-lib usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/SettingsComponents/MediaPlayer/the-man-machine.jpg
W: ubuntu-settings-components: image-file-in-usr-lib usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/SettingsComponents/UserSession/CheckMark@18.png

Did we ever decide on what is the recommended way to handle this? Should I move these files into /usr/share and then supply a symlink?

To post a comment you must log in.
50. By Robert Bruce Park

Simplify!

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Which other pacakges did you see Section: unity? Just curious.

Also, I do think we really should move those files to /usr/share, and actually fix whatever is expecting them in /usr/lib to look at the right place.

review: Needs Information
Revision history for this message
Robert Bruce Park (robru) wrote :

Yeah, the problem is that some qml internal component is hardcoded to try to load it's graphic assets from inside /usr/lib/[arch] directory, the last time I came across this problem (in webbrowser-app), I changed the project to install it's images to /usr/share and then created symlinks so that qml could continue to find them; didrocks said he would work with olivier in order to resolve that issue in a nicer way, but I never heard anything about it since.

As for other projects doing section: unity, well, I can't seem to find any at the moment (of course), but at the time I had just done a 'grep -R Section:' and unity was popping up a lot. Maybe it was just from some tests inside cu2d and not anything in the real distro... bah. Anyway, would love your input as to what the correct section is.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

I'm fine with it in it's current state, we can revisit and fix the qml internals later.

I'd just like to see a longer long Description for the binary package if possible.

review: Approve
51. By Robert Bruce Park

Fix lintian warnings.

Had to create a separate -assets package to contain arch independent
files; had to move those into /usr/share, and then create a symlink to
them from /usr/lib so that qml will still be able to find them at
runtime.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

as per IRC:
18:15:30 didrocks | robru: looks perfect to me! (just change the binary package name + add the dep), everything is great, nice
                    | mess^W^W^W^Wwork

52. By Robert Bruce Park

Package rename and dependency fixes.

53. By Robert Bruce Park

Fix last lintian warning.

Revision history for this message
Robert Bruce Park (robru) wrote :

Ok, i think this is perfect now. Just needs Andrea to top-approve this because nobody else has permission to ;-)

review: Approve
54. By Robert Bruce Park

Fix missing deps.

Revision history for this message
Robert Bruce Park (robru) wrote :

Whoops, now it's fixed for real, confirmed in pbuilder and everything ;-)

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

looking good after our IRC discussions!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.bzr-builddeb'
2=== added file '.bzr-builddeb/default.conf'
3--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
4+++ .bzr-builddeb/default.conf 2013-08-09 16:37:17 +0000
5@@ -0,0 +1,2 @@
6+[BUILDDEB]
7+split = True
8
9=== modified file 'CMakeLists.txt'
10--- CMakeLists.txt 2013-06-07 15:39:04 +0000
11+++ CMakeLists.txt 2013-08-09 16:37:17 +0000
12@@ -70,8 +70,15 @@
13 SettingsComponents
14 )
15
16+INSTALL(CODE "EXECUTE_PROCESS(COMMAND
17+ mkdir -p \$ENV{DESTDIR}${SETTINGS_COMPONENTS_DIR})")
18+INSTALL(CODE "EXECUTE_PROCESS(COMMAND
19+ ln -sf /usr/share/SettingsComponents
20+ \$ENV{DESTDIR}${SETTINGS_COMPONENTS_DIR})")
21+
22+# Install arch-independent assets under /usr/share
23 install(DIRECTORY ${QML_DIRS}
24- DESTINATION ${SETTINGS_COMPONENTS_DIR}
25+ DESTINATION ${CMAKE_INSTALL_DATADIR}
26 )
27
28 # Tests
29
30=== added file 'COPYING'
31--- COPYING 1970-01-01 00:00:00 +0000
32+++ COPYING 2013-08-09 16:37:17 +0000
33@@ -0,0 +1,165 @@
34+ GNU LESSER GENERAL PUBLIC LICENSE
35+ Version 3, 29 June 2007
36+
37+ Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
38+ Everyone is permitted to copy and distribute verbatim copies
39+ of this license document, but changing it is not allowed.
40+
41+
42+ This version of the GNU Lesser General Public License incorporates
43+the terms and conditions of version 3 of the GNU General Public
44+License, supplemented by the additional permissions listed below.
45+
46+ 0. Additional Definitions.
47+
48+ As used herein, "this License" refers to version 3 of the GNU Lesser
49+General Public License, and the "GNU GPL" refers to version 3 of the GNU
50+General Public License.
51+
52+ "The Library" refers to a covered work governed by this License,
53+other than an Application or a Combined Work as defined below.
54+
55+ An "Application" is any work that makes use of an interface provided
56+by the Library, but which is not otherwise based on the Library.
57+Defining a subclass of a class defined by the Library is deemed a mode
58+of using an interface provided by the Library.
59+
60+ A "Combined Work" is a work produced by combining or linking an
61+Application with the Library. The particular version of the Library
62+with which the Combined Work was made is also called the "Linked
63+Version".
64+
65+ The "Minimal Corresponding Source" for a Combined Work means the
66+Corresponding Source for the Combined Work, excluding any source code
67+for portions of the Combined Work that, considered in isolation, are
68+based on the Application, and not on the Linked Version.
69+
70+ The "Corresponding Application Code" for a Combined Work means the
71+object code and/or source code for the Application, including any data
72+and utility programs needed for reproducing the Combined Work from the
73+Application, but excluding the System Libraries of the Combined Work.
74+
75+ 1. Exception to Section 3 of the GNU GPL.
76+
77+ You may convey a covered work under sections 3 and 4 of this License
78+without being bound by section 3 of the GNU GPL.
79+
80+ 2. Conveying Modified Versions.
81+
82+ If you modify a copy of the Library, and, in your modifications, a
83+facility refers to a function or data to be supplied by an Application
84+that uses the facility (other than as an argument passed when the
85+facility is invoked), then you may convey a copy of the modified
86+version:
87+
88+ a) under this License, provided that you make a good faith effort to
89+ ensure that, in the event an Application does not supply the
90+ function or data, the facility still operates, and performs
91+ whatever part of its purpose remains meaningful, or
92+
93+ b) under the GNU GPL, with none of the additional permissions of
94+ this License applicable to that copy.
95+
96+ 3. Object Code Incorporating Material from Library Header Files.
97+
98+ The object code form of an Application may incorporate material from
99+a header file that is part of the Library. You may convey such object
100+code under terms of your choice, provided that, if the incorporated
101+material is not limited to numerical parameters, data structure
102+layouts and accessors, or small macros, inline functions and templates
103+(ten or fewer lines in length), you do both of the following:
104+
105+ a) Give prominent notice with each copy of the object code that the
106+ Library is used in it and that the Library and its use are
107+ covered by this License.
108+
109+ b) Accompany the object code with a copy of the GNU GPL and this license
110+ document.
111+
112+ 4. Combined Works.
113+
114+ You may convey a Combined Work under terms of your choice that,
115+taken together, effectively do not restrict modification of the
116+portions of the Library contained in the Combined Work and reverse
117+engineering for debugging such modifications, if you also do each of
118+the following:
119+
120+ a) Give prominent notice with each copy of the Combined Work that
121+ the Library is used in it and that the Library and its use are
122+ covered by this License.
123+
124+ b) Accompany the Combined Work with a copy of the GNU GPL and this license
125+ document.
126+
127+ c) For a Combined Work that displays copyright notices during
128+ execution, include the copyright notice for the Library among
129+ these notices, as well as a reference directing the user to the
130+ copies of the GNU GPL and this license document.
131+
132+ d) Do one of the following:
133+
134+ 0) Convey the Minimal Corresponding Source under the terms of this
135+ License, and the Corresponding Application Code in a form
136+ suitable for, and under terms that permit, the user to
137+ recombine or relink the Application with a modified version of
138+ the Linked Version to produce a modified Combined Work, in the
139+ manner specified by section 6 of the GNU GPL for conveying
140+ Corresponding Source.
141+
142+ 1) Use a suitable shared library mechanism for linking with the
143+ Library. A suitable mechanism is one that (a) uses at run time
144+ a copy of the Library already present on the user's computer
145+ system, and (b) will operate properly with a modified version
146+ of the Library that is interface-compatible with the Linked
147+ Version.
148+
149+ e) Provide Installation Information, but only if you would otherwise
150+ be required to provide such information under section 6 of the
151+ GNU GPL, and only to the extent that such information is
152+ necessary to install and execute a modified version of the
153+ Combined Work produced by recombining or relinking the
154+ Application with a modified version of the Linked Version. (If
155+ you use option 4d0, the Installation Information must accompany
156+ the Minimal Corresponding Source and Corresponding Application
157+ Code. If you use option 4d1, you must provide the Installation
158+ Information in the manner specified by section 6 of the GNU GPL
159+ for conveying Corresponding Source.)
160+
161+ 5. Combined Libraries.
162+
163+ You may place library facilities that are a work based on the
164+Library side by side in a single library together with other library
165+facilities that are not Applications and are not covered by this
166+License, and convey such a combined library under terms of your
167+choice, if you do both of the following:
168+
169+ a) Accompany the combined library with a copy of the same work based
170+ on the Library, uncombined with any other library facilities,
171+ conveyed under the terms of this License.
172+
173+ b) Give prominent notice with the combined library that part of it
174+ is a work based on the Library, and explaining where to find the
175+ accompanying uncombined form of the same work.
176+
177+ 6. Revised Versions of the GNU Lesser General Public License.
178+
179+ The Free Software Foundation may publish revised and/or new versions
180+of the GNU Lesser General Public License from time to time. Such new
181+versions will be similar in spirit to the present version, but may
182+differ in detail to address new problems or concerns.
183+
184+ Each version is given a distinguishing version number. If the
185+Library as you received it specifies that a certain numbered version
186+of the GNU Lesser General Public License "or any later version"
187+applies to it, you have the option of following the terms and
188+conditions either of that published version or of any later version
189+published by the Free Software Foundation. If the Library as you
190+received it does not specify a version number of the GNU Lesser
191+General Public License, you may choose any version of the GNU Lesser
192+General Public License ever published by the Free Software Foundation.
193+
194+ If the Library as you received it specifies that a proxy can decide
195+whether future versions of the GNU Lesser General Public License shall
196+apply, that proxy's public statement of acceptance of any version is
197+permanent authorization for you to choose that version for the
198+Library.
199
200=== added directory 'debian'
201=== added file 'debian/changelog'
202--- debian/changelog 1970-01-01 00:00:00 +0000
203+++ debian/changelog 2013-08-09 16:37:17 +0000
204@@ -0,0 +1,5 @@
205+ubuntu-settings-components (0.1-0ubuntu1) UNRELEASED; urgency=low
206+
207+ * Initial release.
208+
209+ -- Robert Bruce Park <robert.park@canonical.com> Wed, 07 Aug 2013 14:45:26 +0200
210
211=== added file 'debian/compat'
212--- debian/compat 1970-01-01 00:00:00 +0000
213+++ debian/compat 2013-08-09 16:37:17 +0000
214@@ -0,0 +1,1 @@
215+9
216
217=== added file 'debian/control'
218--- debian/control 1970-01-01 00:00:00 +0000
219+++ debian/control 2013-08-09 16:37:17 +0000
220@@ -0,0 +1,30 @@
221+Source: ubuntu-settings-components
222+Section: misc
223+Priority: optional
224+Maintainer: Andrea Cimitan <andrea.cimitan@canonical.com>
225+Build-Depends: cmake,
226+ debhelper (>= 9),
227+ pkg-config,
228+ qtdeclarative5-dev,
229+Standards-Version: 3.9.4
230+Homepage: https://launchpad.net/ubuntu-settings-components
231+# If you aren't a member of ~ubuntu-settings-components-team but need to upload packaging changes,
232+# just go ahead. ~ubuntu-settings-components-team will notice and sync up the code again.
233+Vcs-Bzr: https://code.launchpad.net/~ubuntu-settings-components-team/ubuntu-settings-components/trunk
234+
235+Package: qtdeclarative5-ubuntu-settings-components
236+Architecture: any
237+Depends: qtdeclarative5-ubuntu-settings-components-assets (= ${source:Version}),
238+ qtdeclarative5-ubuntu-ui-toolkit-plugin,
239+ ${misc:Depends},
240+ ${shlibs:Depends},
241+Description: Ubuntu Settings Components
242+ This package provides a link from /usr/lib to /usr/share, so QML can
243+ find its assets.
244+
245+Package: qtdeclarative5-ubuntu-settings-components-assets
246+Architecture: all
247+Depends: ${misc:Depends},
248+ ${shlibs:Depends},
249+Description: Ubuntu Settings Components
250+ Architecture-independent QML and images files for Ubuntu Settings.
251
252=== added file 'debian/copyright'
253--- debian/copyright 1970-01-01 00:00:00 +0000
254+++ debian/copyright 2013-08-09 16:37:17 +0000
255@@ -0,0 +1,22 @@
256+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
257+Source: https://launchpad.net/ubuntu-settings-components
258+Upstream-Name: ubuntu-settings-components
259+Upstream-Contact: Andrea Cimitan <andrea.cimitan@canonical.com>
260+
261+Files: *
262+Copyright: 2013 Canonical, Ltd.
263+License: LGPL-3
264+
265+License: LGPL-3
266+ This program is free software: you can redistribute it and/or modify
267+ it under the terms of version 3 of the GNU Lesser General Public
268+ License as published by the Free Software Foundation.
269+ .
270+ This program is distributed in the hope that it will be useful,
271+ but WITHOUT ANY WARRANTY; without even the implied warranty of
272+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
273+ GNU General Public License for more details.
274+ .
275+ On Debian systems, the full text of the GNU Lesser General Public
276+ License version 3 can be found in the file
277+ `/usr/share/common-licenses/LGPL-3'.
278
279=== added file 'debian/qtdeclarative5-ubuntu-settings-components-assets.install'
280--- debian/qtdeclarative5-ubuntu-settings-components-assets.install 1970-01-01 00:00:00 +0000
281+++ debian/qtdeclarative5-ubuntu-settings-components-assets.install 2013-08-09 16:37:17 +0000
282@@ -0,0 +1,1 @@
283+usr/share/
284
285=== added file 'debian/qtdeclarative5-ubuntu-settings-components.install'
286--- debian/qtdeclarative5-ubuntu-settings-components.install 1970-01-01 00:00:00 +0000
287+++ debian/qtdeclarative5-ubuntu-settings-components.install 2013-08-09 16:37:17 +0000
288@@ -0,0 +1,1 @@
289+usr/lib/
290
291=== added file 'debian/rules'
292--- debian/rules 1970-01-01 00:00:00 +0000
293+++ debian/rules 2013-08-09 16:37:17 +0000
294@@ -0,0 +1,5 @@
295+#!/usr/bin/make -f
296+# -*- makefile -*-
297+
298+%:
299+ dh $@ --parallel --fail-missing

Subscribers

People subscribed via source and target branches

to all changes: