Merge lp:~robru/queuebot/string-tweaks into lp:queuebot

Proposed by Robert Bruce Park on 2016-01-13
Status: Merged
Merged at revision: 105
Proposed branch: lp:~robru/queuebot/string-tweaks
Merge into: lp:queuebot
Diff against target: 27 lines (+2/-6)
1 file modified
plugins/landing.py (+2/-6)
To merge this branch: bzr merge lp:~robru/queuebot/string-tweaks
Reviewer Review Type Date Requested Status
Stéphane Graber 2016-01-15 Pending
Ubuntu Package Archive Administrators 2016-01-13 Pending
Review via email: mp+282524@code.launchpad.net
To post a comment you must log in.
lp:~robru/queuebot/string-tweaks updated on 2016-01-15
106. By Robert Bruce Park on 2016-01-15

Ping all QA states.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/landing.py'
2--- plugins/landing.py 2015-12-21 20:41:09 +0000
3+++ plugins/landing.py 2016-01-15 19:45:32 +0000
4@@ -9,11 +9,9 @@
5 URL = ROOT + "v1/tickets"
6
7 PERMALINK = "{}#/ticket/{{request_id}}".format(ROOT)
8-TESTED = "{{landers}}, {} {{qa_signoff}}".format(PERMALINK)
9+TESTED = "{{landers}}, {} QA Signoff: {{qa_signoff}}".format(PERMALINK)
10 STATUS = "{{landers}}, {} {{status}}".format(PERMALINK)
11
12-PINGERS = set(['ready', 'granted', 'publish'])
13-
14
15 class LandingScanner(threading.Thread):
16 notices = list()
17@@ -38,9 +36,7 @@
18 continue # Don't spam message if old version not cached.
19
20 if req['qa_signoff'] != old_req['qa_signoff']:
21- if PINGERS & set(req['qa_signoff'].lower().split()):
22- self.notices.append(
23- (TESTED.format(**req), (self.queue,)))
24+ self.notices.append((TESTED.format(**req), (self.queue,)))
25 if req['status'] != old_req['status']:
26 msg = req['status'].lower()
27 if 'currently building' not in msg or 'fail' in msg:

Subscribers

People subscribed via source and target branches