Merge lp:~robru/poppler-qml-plugin/more-packaging into lp:poppler-qml-plugin

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 12
Merged at revision: 11
Proposed branch: lp:~robru/poppler-qml-plugin/more-packaging
Merge into: lp:poppler-qml-plugin
Diff against target: 225 lines (+115/-10)
8 files modified
debian/control (+2/-1)
debian/copyright (+2/-2)
pageImageProvider.cpp (+19/-0)
pageImageProvider.h (+18/-0)
pdfModel.cpp (+18/-1)
pdfModel.h (+19/-2)
plugin.cpp (+18/-2)
plugin.h (+19/-2)
To merge this branch: bzr merge lp:~robru/poppler-qml-plugin/more-packaging
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
PS Jenkins bot continuous-integration Approve
Mathieu Trudel-Lapierre Pending
Didier Roche-Tolomelli Pending
Review via email: mp+180888@code.launchpad.net

Commit message

Minor packaging fixups.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
12. By Robert Bruce Park

Add Multi-Arch field.

Revision history for this message
Robert Bruce Park (robru) wrote :

Self-approving because all changes here were directly requested by didrocks anyway.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-08-19 07:56:50 +0000
3+++ debian/control 2013-08-19 16:26:29 +0000
4@@ -1,5 +1,5 @@
5 Source: poppler-qml-plugin
6-Priority: extra
7+Priority: optional
8 Maintainer: Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>
9 Build-Depends: debhelper (>= 9),
10 libpoppler-qt5-dev,
11@@ -16,6 +16,7 @@
12 Package: qtdeclarative5-poppler1.0
13 Section: libs
14 Architecture: any
15+Multi-Arch: same
16 Depends: ${misc:Depends},
17 ${shlibs:Depends},
18 Replaces: qtdeclarative5-poppler-qml-plugin
19
20=== modified file 'debian/copyright'
21--- debian/copyright 2013-08-15 20:01:24 +0000
22+++ debian/copyright 2013-08-19 16:26:29 +0000
23@@ -1,6 +1,6 @@
24 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
25-Upstream-Name: qtdeclarative5-poppler-qml-plugin
26-Source:
27+Upstream-Name: poppler-qml-plugin
28+Source: https://launchpad.net/poppler-qml-plugin
29
30 Files: *
31 Copyright: 2013 Canonical Ltd.
32
33=== modified file 'pageImageProvider.cpp'
34--- pageImageProvider.cpp 2013-08-02 14:23:06 +0000
35+++ pageImageProvider.cpp 2013-08-19 16:26:29 +0000
36@@ -1,3 +1,22 @@
37+/*
38+ * Copyright (C) 2013 Canonical, Ltd.
39+ *
40+ * This program is free software: you can redistribute it and/or modify it
41+ * under the terms of the GNU General Public License version 3, as published
42+ * by the Free Software Foundation.
43+ *
44+ * This program is distributed in the hope that it will be useful, but
45+ * WITHOUT ANY WARRANTY; without even the implied warranties of
46+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
47+ * PURPOSE. See the GNU General Public License for more details.
48+ *
49+ * You should have received a copy of the GNU General Public License along
50+ * with this program. If not, see <http://www.gnu.org/licenses/>.
51+ *
52+ * Author: Anthony Granger <grangeranthony@gmail.com>
53+ */
54+
55+
56 #include <poppler/qt5/poppler-qt5.h>
57 #include <QQuickImageProvider>
58 #include <QDebug>
59
60=== modified file 'pageImageProvider.h'
61--- pageImageProvider.h 2013-07-19 16:50:46 +0000
62+++ pageImageProvider.h 2013-08-19 16:26:29 +0000
63@@ -1,3 +1,21 @@
64+/*
65+ * Copyright (C) 2013 Canonical, Ltd.
66+ *
67+ * This program is free software: you can redistribute it and/or modify it
68+ * under the terms of the GNU General Public License version 3, as published
69+ * by the Free Software Foundation.
70+ *
71+ * This program is distributed in the hope that it will be useful, but
72+ * WITHOUT ANY WARRANTY; without even the implied warranties of
73+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
74+ * PURPOSE. See the GNU General Public License for more details.
75+ *
76+ * You should have received a copy of the GNU General Public License along
77+ * with this program. If not, see <http://www.gnu.org/licenses/>.
78+ *
79+ * Author: Anthony Granger <grangeranthony@gmail.com>
80+ */
81+
82 #ifndef PAGEIMAGEPROVIDER_H
83 #define PAGEIMAGEPROVIDER_H
84
85
86=== modified file 'pdfModel.cpp'
87--- pdfModel.cpp 2013-08-02 14:23:06 +0000
88+++ pdfModel.cpp 2013-08-19 16:26:29 +0000
89@@ -1,3 +1,21 @@
90+/*
91+ * Copyright (C) 2013 Canonical, Ltd.
92+ *
93+ * This program is free software: you can redistribute it and/or modify it
94+ * under the terms of the GNU General Public License version 3, as published
95+ * by the Free Software Foundation.
96+ *
97+ * This program is distributed in the hope that it will be useful, but
98+ * WITHOUT ANY WARRANTY; without even the implied warranties of
99+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
100+ * PURPOSE. See the GNU General Public License for more details.
101+ *
102+ * You should have received a copy of the GNU General Public License along
103+ * with this program. If not, see <http://www.gnu.org/licenses/>.
104+ *
105+ * Author: Anthony Granger <grangeranthony@gmail.com>
106+ */
107+
108 #include <pdfModel.h>
109 #include <pageImageProvider.h>
110
111@@ -83,4 +101,3 @@
112 PdfModel::~PdfModel()
113 {
114 }
115-
116
117=== modified file 'pdfModel.h'
118--- pdfModel.h 2013-07-19 16:50:46 +0000
119+++ pdfModel.h 2013-08-19 16:26:29 +0000
120@@ -1,3 +1,21 @@
121+/*
122+ * Copyright (C) 2013 Canonical, Ltd.
123+ *
124+ * This program is free software: you can redistribute it and/or modify it
125+ * under the terms of the GNU General Public License version 3, as published
126+ * by the Free Software Foundation.
127+ *
128+ * This program is distributed in the hope that it will be useful, but
129+ * WITHOUT ANY WARRANTY; without even the implied warranties of
130+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
131+ * PURPOSE. See the GNU General Public License for more details.
132+ *
133+ * You should have received a copy of the GNU General Public License along
134+ * with this program. If not, see <http://www.gnu.org/licenses/>.
135+ *
136+ * Author: Anthony Granger <grangeranthony@gmail.com>
137+ */
138+
139 #ifndef PDFMODEL_H
140 #define PDFMODEL_H
141
142@@ -8,7 +26,7 @@
143 {
144 Q_OBJECT
145 Q_DISABLE_COPY(PdfModel)
146-
147+
148 public:
149 explicit PdfModel(QQuickItem *parent = 0);
150 virtual ~PdfModel();
151@@ -40,4 +58,3 @@
152 QML_DECLARE_TYPE(PdfModel)
153
154 #endif // PDFMODEL_H
155-
156
157=== modified file 'plugin.cpp'
158--- plugin.cpp 2013-07-19 16:50:46 +0000
159+++ plugin.cpp 2013-08-19 16:26:29 +0000
160@@ -1,3 +1,21 @@
161+/*
162+ * Copyright (C) 2013 Canonical, Ltd.
163+ *
164+ * This program is free software: you can redistribute it and/or modify it
165+ * under the terms of the GNU General Public License version 3, as published
166+ * by the Free Software Foundation.
167+ *
168+ * This program is distributed in the hope that it will be useful, but
169+ * WITHOUT ANY WARRANTY; without even the implied warranties of
170+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
171+ * PURPOSE. See the GNU General Public License for more details.
172+ *
173+ * You should have received a copy of the GNU General Public License along
174+ * with this program. If not, see <http://www.gnu.org/licenses/>.
175+ *
176+ * Author: Anthony Granger <grangeranthony@gmail.com>
177+ */
178+
179 #include "plugin.h"
180 #include "pdfModel.h"
181
182@@ -8,5 +26,3 @@
183 // @uri org.docviewer.poppler
184 qmlRegisterType<PdfModel>(uri, 1, 0, "Poppler");
185 }
186-
187-
188
189=== modified file 'plugin.h'
190--- plugin.h 2013-07-19 16:50:46 +0000
191+++ plugin.h 2013-08-19 16:26:29 +0000
192@@ -1,3 +1,21 @@
193+/*
194+ * Copyright (C) 2013 Canonical, Ltd.
195+ *
196+ * This program is free software: you can redistribute it and/or modify it
197+ * under the terms of the GNU General Public License version 3, as published
198+ * by the Free Software Foundation.
199+ *
200+ * This program is distributed in the hope that it will be useful, but
201+ * WITHOUT ANY WARRANTY; without even the implied warranties of
202+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
203+ * PURPOSE. See the GNU General Public License for more details.
204+ *
205+ * You should have received a copy of the GNU General Public License along
206+ * with this program. If not, see <http://www.gnu.org/licenses/>.
207+ *
208+ * Author: Anthony Granger <grangeranthony@gmail.com>
209+ */
210+
211 #ifndef POPPLERPLUGIN_H
212 #define POPPLERPLUGIN_H
213
214@@ -7,10 +25,9 @@
215 {
216 Q_OBJECT
217 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
218-
219+
220 public:
221 void registerTypes(const char *uri);
222 };
223
224 #endif // POPPLERPLUGIN_H
225-

Subscribers

People subscribed via source and target branches