lp:~robru/gwibber/dispatcher

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~barry/gwibber/py3 at revision 1427

Barry Warsaw: Pending requested 2012-09-10

Diff: 736 lines (+303/-89)

12 files modified

gwibber/gwibber/main.py (+14/-18)
gwibber/gwibber/protocols/flickr.py (+6/-8)
gwibber/gwibber/protocols/twitter.py (+2/-1)
gwibber/gwibber/service/dispatcher.py (+201/-0)
gwibber/gwibber/testing/com.Gwibber.Service.service.in (+3/-0)
gwibber/gwibber/testing/dbus.py (+1/-0)
gwibber/gwibber/tests/test_dbus.py (+39/-22)
gwibber/gwibber/tests/test_flickr.py (+6/-8)
gwibber/gwibber/tests/test_protocols.py (+10/-15)
gwibber/gwibber/tests/test_twitter.py (+1/-1)
gwibber/gwibber/utils/account.py (+9/-2)
gwibber/gwibber/utils/protocol.py (+11/-14)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1438. By Robert Bruce Park on 2012-09-12

Rename _manager to protocolmanager because it is actually public.

1437. By Robert Bruce Park on 2012-09-12

Raise NotImplementedErrors instead of AttributeErrors for protocols.

This makes more sense.

1436. By Robert Bruce Park on 2012-09-12

Add Dispatcher.online property to enhance readability of the timer_id.

1435. By Robert Bruce Park on 2012-09-12

Drop protocol.info.features as it is redundant; we can introspect what
features are present based on what methods are present on the protocol
instance.

1434. By Robert Bruce Park on 2012-09-12

Get refresh timeout interval from GSettings.

1433. By Robert Bruce Park on 2012-09-12

Call Dispatcher.Refresh periodically from the GLib mainloop.

1432. By Robert Bruce Park on 2012-09-12

Expand test_get_features to check invalid inputs.

1431. By Robert Bruce Park on 2012-09-12

Convert protocol info into a sub-namespace called 'info'.

This was necessary because the primary protocol class namespace is reserved
for callable methods that can be accessed through __call__, so now eg
protocol.version has been renamed to protocol.info.version, etc.

This commit results in the Dispatcher.GetFeatures test passing, because it's
now possible to introspect what features a protocol supports just by looking
at its public methods.

1430. By Robert Bruce Park on 2012-09-12

Converted services from an array to a class.

This makes it easier to pass references from one service to another's
constructor, cleaning up service instantiation quite a bit.

1429. By Robert Bruce Park on 2012-09-11

Invoke super() so that the Dispatcher can actually be called through dbus.