Merge lp:~robru/gwibber/3.4-twitter-1.1 into lp:gwibber/3.4

Proposed by Robert Bruce Park on 2013-06-25
Status: Merged
Approved by: Ken VanDine on 2013-07-08
Approved revision: 1323
Merged at revision: 1322
Proposed branch: lp:~robru/gwibber/3.4-twitter-1.1
Merge into: lp:gwibber/3.4
Diff against target: 43 lines (+4/-4)
2 files modified
gwibber/microblog/plugins/twitter/__init__.py (+1/-1)
gwibber/microblog/plugins/twitter/gtk/twitter/__init__.py (+3/-3)
To merge this branch: bzr merge lp:~robru/gwibber/3.4-twitter-1.1
Reviewer Review Type Date Requested Status
Ken VanDine 2013-06-25 Approve on 2013-07-08
Review via email: mp+171193@code.launchpad.net

Commit message

Switch to Twitter v1.1 as v1 has been retired.

To post a comment you must log in.
lp:~robru/gwibber/3.4-twitter-1.1 updated on 2013-06-25
1323. By Robert Bruce Park on 2013-06-25

Get the other v1 API URL too.

Ken VanDine (ken-vandine) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gwibber/microblog/plugins/twitter/__init__.py'
2--- gwibber/microblog/plugins/twitter/__init__.py 2012-03-30 14:32:20 +0000
3+++ gwibber/microblog/plugins/twitter/__init__.py 2013-06-25 01:25:31 +0000
4@@ -57,7 +57,7 @@
5 }
6
7 URL_PREFIX = "https://twitter.com"
8-API_PREFIX = "https://api.twitter.com/1"
9+API_PREFIX = "https://api.twitter.com/1.1"
10
11 class Client ():
12 def __init__(self, acct):
13
14=== modified file 'gwibber/microblog/plugins/twitter/gtk/twitter/__init__.py'
15--- gwibber/microblog/plugins/twitter/gtk/twitter/__init__.py 2012-03-07 21:17:19 +0000
16+++ gwibber/microblog/plugins/twitter/gtk/twitter/__init__.py 2013-06-25 01:25:31 +0000
17@@ -17,7 +17,7 @@
18 class AccountWidget(Gtk.VBox):
19 """AccountWidget: A widget that provides a user interface for configuring twitter accounts in Gwibber
20 """
21-
22+
23 def __init__(self, account=None, dialog=None):
24 """Creates the account pane for configuring Twitter accounts"""
25 Gtk.VBox.__init__( self, False, 20 )
26@@ -141,7 +141,7 @@
27 apireq = oauth.OAuthRequest.from_consumer_and_token(
28 self.consumer, atok,
29 http_method="GET",
30- http_url="http://api.twitter.com/1/account/verify_credentials.json", parameters=None)
31+ http_url="http://api.twitter.com/1.1/account/verify_credentials.json", parameters=None)
32
33 apireq.sign_request(sigmeth, self.consumer, atok)
34
35@@ -161,7 +161,7 @@
36 self.dialog.infobar.set_message_type(Gtk.MessageType.ERROR)
37 message_label.set_text(_("Authorization failed. Please try again."))
38
39- if saved:
40+ if saved:
41 message_label.set_text(_("Successful"))
42 self.dialog.infobar.set_message_type(Gtk.MessageType.INFO)
43 #self.dialog.infobar.hide()

Subscribers

People subscribed via source and target branches