lp:~robru/friends/refresh-fixup

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:friends

Robert Bruce Park: Approve on 2012-10-20

Diff: 833 lines (+160/-139)

24 files modified

friends-service.sh (+1/-1)
friends/main.py (+4/-2)
friends/protocols/facebook.py (+1/-1)
friends/protocols/flickr.py (+1/-1)
friends/protocols/foursquare.py (+1/-1)
friends/protocols/twitter.py (+6/-7)
friends/service/connection.py (+1/-1)
friends/service/dispatcher.py (+2/-1)
friends/service/shortener.py (+1/-1)
friends/testing/mocks.py (+3/-3)
friends/testing/service.py (+1/-1)
friends/tests/test_authentication.py (+15/-9)
friends/tests/test_download.py (+14/-8)
friends/tests/test_facebook.py (+2/-0)
friends/tests/test_flickr.py (+16/-2)
friends/tests/test_logging.py (+16/-37)
friends/utils/account.py (+1/-1)
friends/utils/authentication.py (+15/-15)
friends/utils/avatar.py (+1/-1)
friends/utils/base.py (+8/-3)
friends/utils/download.py (+4/-11)
friends/utils/logging.py (+24/-11)
friends/utils/menus.py (+1/-1)
tools/debug_live.py (+21/-20)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

26. By Robert Bruce Park on 2012-10-20

debug_live.py doesn't need to be on a loop anymore.

The looping of it was primarily useful before we had the dispatcher
actually running. Now that we have the dispatcher, debug_live is more
just for firing single messages.

25. By Robert Bruce Park on 2012-10-20

Simplify debug_live.py

24. By Robert Bruce Park on 2012-10-20

Greatly simplify the logging logic. Was overthinking it before...

23. By Robert Bruce Park on 2012-10-19

Fix the last of the test failures.

22. By Robert Bruce Park on 2012-10-19

Overhaul a lot of the logging logic.

Logging now works in both friends-service and in debug_live. I found a
workaround for that duplicate-records bug. Tests have been updated.

21. By Robert Bruce Park on 2012-10-19

Resurrect logging from friends-service.sh

20. By Robert Bruce Park on 2012-10-19

Update tests to no longer expect HTTPError to be raised.

This brings us much more into line with the Soup way of doing things,
rather than trying to force urllib-like behavior on top of Soup.

19. By Robert Bruce Park on 2012-10-19

Overhaul debug_live.py to make it compatible with Authentication changes.

18. By Robert Bruce Park on 2012-10-19

Make logging *much* more explicit about what is being logged from where.

17. By Robert Bruce Park on 2012-10-19

Replace threading.Lock() with time.sleep()

Yes, yes, I know time.sleep() is ugly, but this is looking like the
only way I can get this working quite right. The previous attempts
using threading.Lock and GObject.MainLoops both had very subtle hangs
that basically screwed up everything.