Merge lp:~robru/friends/model-cleanup into lp:friends
Proposed by
Robert Bruce Park
Status: | Merged |
---|---|
Approved by: | Ken VanDine |
Approved revision: | 178 |
Merged at revision: | 175 |
Proposed branch: | lp:~robru/friends/model-cleanup |
Merge into: | lp:friends |
Diff against target: |
316 lines (+118/-22) 7 files modified
friends/protocols/facebook.py (+10/-3) friends/protocols/twitter.py (+10/-7) friends/tests/test_facebook.py (+14/-3) friends/tests/test_identica.py (+1/-1) friends/tests/test_protocols.py (+49/-0) friends/tests/test_twitter.py (+9/-1) friends/utils/base.py (+25/-7) |
To merge this branch: | bzr merge lp:~robru/friends/model-cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Ken VanDine | Approve | ||
Review via email: mp+156704@code.launchpad.net |
Commit message
Thread replies properly, and fix up likes/unlikes to modify model data upon success.
Description of the change
Alright Ken, just like you asked, replies are threading and likes/unlikes are updating the model contents as you'd expect. Not sure how we overlooked this originally ;-)
Anyway, I did the model alteration stuff with a fairly simple API in the Base class, rather than having to import the Model into the protocol classes, which is a bit hacky.
As usual, excellent test coverage is included.
To post a comment you must log in.
FAILED: Continuous integration, rev:178 /code.launchpad .net/~robru/ friends/ model-cleanup/ +merge/ 156704/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ friends- ci/16/ jenkins. qa.ubuntu. com/job/ friends- raring- amd64-ci/ 16
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ friends- ci/16/rebuild
http://