Merge lp:~robru/friends/gschema into lp:friends

Proposed by Robert Bruce Park
Status: Merged
Merged at revision: 21
Proposed branch: lp:~robru/friends/gschema
Merge into: lp:friends
Diff against target: 90 lines (+60/-2)
3 files modified
data/com.canonical.friends.gschema.xml (+54/-0)
friends/main.py (+2/-2)
setup.py (+4/-0)
To merge this branch: bzr merge lp:~robru/friends/gschema
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+131261@code.launchpad.net

Description of the change

Ken, I need your input on this gschema that I came up with for the new friends-service. It's based off the old gwibber schema, but I ripped out all the stuff that we didn't seem to be using.

Also, I modified setup.py to install the schema for us, and it seems to work, but I'm not sure if I did it the "right" way so I'd like your input on that.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks great and works fine

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'data'
2=== added file 'data/com.canonical.friends.gschema.xml'
3--- data/com.canonical.friends.gschema.xml 1970-01-01 00:00:00 +0000
4+++ data/com.canonical.friends.gschema.xml 2012-10-24 18:58:20 +0000
5@@ -0,0 +1,54 @@
6+<schemalist>
7+ <schema id="com.canonical.friends" path="/com/canonical/friends/">
8+
9+ <key name="interval" type="i">
10+ <default>15</default>
11+ <summary>Refresh interval in minutes.</summary>
12+ <description>
13+ The number of minutes friends-service will wait in between
14+ attempts at downloading new messages.
15+ </description>
16+ </key>
17+
18+ <key name="notifications" type="b">
19+ <default>true</default>
20+ <summary>Display notifications?</summary>
21+ <description>
22+ True if you want to see unread message counts in the messaging
23+ menu, false otherwise.
24+ </description>
25+ </key>
26+
27+ <key name="debug" type="b">
28+ <default>false</default>
29+ <summary>Display debugging messages?</summary>
30+ <description>
31+ Whether or not to show verbose debugging messages in the logfile.
32+ </description>
33+ </key>
34+
35+ <key name="shorten-urls" type="b">
36+ <default>true</default>
37+ <summary>Shorten URLs?</summary>
38+ <description>
39+ Whether or not to automatically shorten URLs in messages that
40+ we send out to the world.
41+ </description>
42+ </key>
43+
44+ <key name="urlshorter" type="s">
45+ <choices>
46+ <choice value="is.gd"/>
47+ <choice value="cli.gs"/>
48+ <choice value="tinyurl.com"/>
49+ <choice value="ur1.ca"/>
50+ </choices>
51+ <default>"is.gd"</default>
52+ <summary>URL shortening service.</summary>
53+ <description>
54+ Choose the preferred URL shortening service.
55+ </description>
56+ </key>
57+
58+ </schema>
59+</schemalist>
60
61=== modified file 'friends/main.py'
62--- friends/main.py 2012-10-20 14:42:21 +0000
63+++ friends/main.py 2012-10-24 18:58:20 +0000
64@@ -55,9 +55,9 @@
65 package, dot, class_name = cls.__name__.rpartition('.')
66 print(class_name)
67 return
68+
69 # Initialize the logging subsystem.
70- # XXX FIXME - this should be renamed to 'friends'.
71- gsettings = Gio.Settings.new('org.gwibber.preferences')
72+ gsettings = Gio.Settings.new('com.canonical.friends')
73 initialize(console=args.console,
74 debug=args.debug or gsettings.get_boolean('debug'))
75 log = logging.getLogger(__name__)
76
77=== modified file 'setup.py'
78--- setup.py 2012-10-18 19:20:52 +0000
79+++ setup.py 2012-10-24 18:58:20 +0000
80@@ -33,6 +33,10 @@
81 package_data = {
82 'friends.service.templates': ['*.service.in'],
83 },
84+ data_files = [
85+ ('/usr/share/glib-2.0/schemas',
86+ ['data/com.canonical.friends.gschema.xml'])
87+ ],
88 entry_points = {
89 'console_scripts': ['friends-service = friends.main:main'],
90 'distutils.commands': [

Subscribers

People subscribed via source and target branches