Merge lp:~robru/friends/fix-twitter-test into lp:friends

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 235
Merged at revision: 236
Proposed branch: lp:~robru/friends/fix-twitter-test
Merge into: lp:friends
Diff against target: 20 lines (+1/-2)
1 file modified
friends/tests/test_twitter.py (+1/-2)
To merge this branch: bzr merge lp:~robru/friends/fix-twitter-test
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Super Friends Pending
Review via email: mp+193640@code.launchpad.net

Commit message

Fix & re-enable failing twitter test.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:235
http://jenkins.qa.ubuntu.com/job/friends-ci/53/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/friends-trusty-amd64-ci/1

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/friends-ci/53/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'friends/tests/test_twitter.py'
2--- friends/tests/test_twitter.py 2013-09-26 18:23:54 +0000
3+++ friends/tests/test_twitter.py 2013-11-01 17:32:54 +0000
4@@ -83,7 +83,6 @@
5 self.assertEqual(self.account.access_token, 'some clever fake data')
6 self.assertEqual(self.account.secret_token, 'sssssshhh!')
7
8- @unittest.skip("FIXME: this is totally broken :-(")
9 @mock.patch('friends.protocols.twitter.Downloader')
10 @mock.patch('oauthlib.oauth1.rfc5849.generate_nonce',
11 lambda: 'once upon a nonce')
12@@ -105,7 +104,7 @@
13 oauth_signature_method="HMAC-SHA1", \
14 oauth_consumer_key="consume", \
15 oauth_token="omega", \
16-oauth_signature="2MlC4DOqcAdCUmU647izPmxiL%2F0%3D"'''
17+oauth_signature="klnMTp3hH%2Fl3b5%2BmPtBlv%2BCulic%3D"'''
18
19 self.protocol._rate_limiter = 'limits'
20 class fake:

Subscribers

People subscribed via source and target branches