lp:~robru/friends/dont-block-refresh

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:friends at revision 90

Ken VanDine: Approve on 2012-12-11

Ricardo Mendoza: Pending requested 2012-12-07

Diff: 78 lines (+27/-16)

2 files modified

friends/service/dispatcher.py (+7/-10)
friends/tests/test_dispatcher.py (+20/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

90. By Robert Bruce Park on 2012-12-07

Instead of blocking Dispatcher.Refresh until the previous refresh
completes, simply abort it instead. With test coverage.

89. By Robert Bruce Park on 2012-12-06

Add debug logging to Twitter's rate limiter.

88. By Robert Bruce Park on 2012-12-05

Only upload images once, not twice. With test coverage.

87. By Robert Bruce Park on 2012-12-05

Get better about raising exceptions to indicate error conditions.

Now that we have a viable way of indicating error conditions to our
calling code, with the failure callback, it no longer makes sense to
log & ignore error conditions. So, this commit changes most (if not
all...) of the calls to 'log.error' with calls to 'raise FriendsError'
instead.

These exceptions still end up being logged thanks to
_OperationThread's traceback logging logic, and also prevent the
success callback from being called.

I think we're in a pretty good state here, although we'll have to keep
an eye on this and make sure that the success callback never gets
called when there was actually an error. If we find such a case, we'll
need to fix it by identifying the error condition and then ensuring
that it raises an appropriate exception.

86. By Robert Bruce Park on 2012-12-05

Merge ken's exception handling fixes.

85. By Robert Bruce Park on 2012-12-04

Fully generalize all the async code so that any protocol operation can
utilize it without needing any modifications.

This commit also adds the async API onto Dispatcher.Do, SendMessage,
and SendReply, and re-unifies UploadAsync into Upload. The callbacks
are fully optional, so all previous code should be unaffected and
continue working, but you now have the option of adding callbacks to
be notified when the operations complete.

This commit also adds test coverage to _OperationThread, which I
discovered was untested.

84. By Ken VanDine on 2012-12-04

Merged the addition of the UploadAsync API from robru (LP: #1085781)

83. By Robert Bruce Park on 2012-11-27

Add Upload method to Dispatcher class.

This was necessary because 'Do' was unable to specify both a URI and a
description for the uploaded image.

82. By Robert Bruce Park on 2012-11-25

Merge what's left of friends.testing into friends.tests.

There used to be a bigger distinction between those modules but that
has largely been lost over time.

81. By Robert Bruce Park on 2012-11-25

Split notify logic off into it's own module, friends.utils.notify.

This commit also moves it's related testsuite into it's own test
module, generally improving the overall structure and making it easier
to find.

No semantic changes are introduced, API remains identical.