Merge lp:~robru/cupstream2distro/fix-ubuntu-push into lp:cupstream2distro

Proposed by Robert Bruce Park
Status: Merged
Merged at revision: 1398
Proposed branch: lp:~robru/cupstream2distro/fix-ubuntu-push
Merge into: lp:cupstream2distro
Diff against target: 16 lines (+3/-4)
1 file modified
tools/buildpackage.sh (+3/-4)
To merge this branch: bzr merge lp:~robru/cupstream2distro/fix-ubuntu-push
Reviewer Review Type Date Requested Status
CU2D maintainers Pending
Review via email: mp+293643@code.launchpad.net

Commit message

Tweak orig.tar creation.

To post a comment you must log in.
1399. By Robert Bruce Park

Revert buildpackage changes.

1400. By Robert Bruce Park

Try more explicit excludes.

Revision history for this message
Colin Watson (cjwatson) wrote :

This probably won't make much difference to the problem at hand, will
it? --exclude-vcs is documented to skip .bzrignore and .gitignore too.

1401. By Robert Bruce Park

Exclude only from source tree root.

1402. By Robert Bruce Park

Pin debian dir also to source root.

Revision history for this message
Robert Bruce Park (robru) wrote :

Yeah I'm just iterating a bit on this. Have another look.

1403. By Robert Bruce Park

Fix whitespace.

Revision history for this message
Colin Watson (cjwatson) wrote :

Seems fair if it works :-)

Revision history for this message
Robert Bruce Park (robru) wrote :

It works in the sense that it successfully strips .bzr* only from the root and not recursively, and the build succeeds & uploads to the PPA, however it's not clear to me that this is actually the Correct behavior, I've asked Steve for his opinion on how to proceed with this.

1404. By Robert Bruce Park

Fix dpkg-buildpackage to ignore VCS files.

1405. By Robert Bruce Park

Fix regex.

1406. By Robert Bruce Park

What if I try...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/buildpackage.sh'
2--- tools/buildpackage.sh 2016-04-06 19:12:11 +0000
3+++ tools/buildpackage.sh 2016-05-03 18:58:27 +0000
4@@ -26,9 +26,8 @@
5 # -sa: Force inclusion of original source.
6 # -d: Do not check build dependencies and conflicts.
7 # -S: Only build source package, no binaries.
8-# -i: Ignore VCS files from generated diff.
9-# -I: Ignore VCS files from generated tarball.
10+# -i: Ignore bzr/git files from generated diff (can only be specified once).
11+# -I: Ignore VCS files from generated tarball, plus .bzr-builddeb which isn't included in default -I
12 # -nc: Do not run `./debian/rules clean`
13 # -k: Sign .changes with this key.
14-# -i'^.bzr' and -I'.bzr*': Ignore .bzr-builddeb which default -i and -I miss.
15-dpkg-buildpackage -sa -d -S -i -i'^.bzr' -I -I'.bzr*' -nc -k"$gpg_key" 1>&2
16+dpkg-buildpackage -sa -d -S -i'(^|/)(\.bzr|\.git)' -I -I'.bzr*' -nc -k"$gpg_key" 1>&2

Subscribers

People subscribed via source and target branches