Merge lp:~robru/cupstream2distro/fix-reverter-silo-dir into lp:cupstream2distro

Proposed by Robert Bruce Park on 2015-02-02
Status: Merged
Approved by: Łukasz Zemczak on 2015-02-03
Approved revision: 865
Merged at revision: 866
Proposed branch: lp:~robru/cupstream2distro/fix-reverter-silo-dir
Merge into: lp:cupstream2distro
Diff against target: 13 lines (+3/-0)
1 file modified
citrain/reverter.py (+3/-0)
To merge this branch: bzr merge lp:~robru/cupstream2distro/fix-reverter-silo-dir
Reviewer Review Type Date Requested Status
Łukasz Zemczak 2015-02-02 Approve on 2015-02-03
PS Jenkins bot continuous-integration Approve on 2015-02-02
Review via email: mp+248285@code.launchpad.net

Commit Message

Allow reverter to run from any directory, not just silos.

To post a comment you must log in.
Robert Bruce Park (robru) wrote :

Lukasz, this one I actually tested and is working ;-)

865. By Robert Bruce Park on 2015-02-02

Short explanatory comment.

PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:865
http://jenkins.qa.ubuntu.com/job/cu2d-choo-choo-ci/411/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/cu2d-choo-choo-ci/411/rebuild

review: Approve (continuous-integration)
Łukasz Zemczak (sil2100) wrote :

Works, +1! Ah those namespaces.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'citrain/reverter.py'
2--- citrain/reverter.py 2014-12-03 05:25:41 +0000
3+++ citrain/reverter.py 2015-02-02 17:34:36 +0000
4@@ -49,6 +49,9 @@
5
6
7 def main():
8+ # Unlike the rest of the train, reverter is run manually outside
9+ # of "silo dirs", so override SILO_DIR() to just be the cwd.
10+ packagemanager.SILO_DIR = os.getcwd
11 parser = argparse.ArgumentParser(
12 description="Revert to previous version of the one published in the "
13 "release pocket of selected packages")

Subscribers

People subscribed via source and target branches