Merge lp:~robru/cupstream2distro/fix-filterdiff-tests into lp:cupstream2distro

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 1127
Merged at revision: 1127
Proposed branch: lp:~robru/cupstream2distro/fix-filterdiff-tests
Merge into: lp:cupstream2distro
Diff against target: 15 lines (+4/-1)
1 file modified
tests/unit/test_packagemanager.py (+4/-1)
To merge this branch: bzr merge lp:~robru/cupstream2distro/fix-filterdiff-tests
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
CU2D maintainers Pending
Review via email: mp+272832@code.launchpad.net

Commit message

Fix filterdiff tests on wily.

To post a comment you must log in.
1127. By Robert Bruce Park

Fix filterdiff tests on wily.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1127
http://jenkins.qa.ubuntu.com/job/cu2d-choo-choo-ci/813/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/cu2d-choo-choo-ci/813/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/unit/test_packagemanager.py'
2--- tests/unit/test_packagemanager.py 2015-09-28 21:49:55 +0000
3+++ tests/unit/test_packagemanager.py 2015-09-29 19:02:18 +0000
4@@ -302,7 +302,10 @@
5 ])
6 with utf8_open(self.pkg_diff_path) as pkg_diff:
7 result = [line.split('\t')[0] for line in
8- pkg_diff.read().strip().splitlines()]
9+ pkg_diff.read().strip().splitlines()
10+ # filterdiff includes 'diff -Nru' lines in wily but not
11+ # vivid or trusty, so this lets tests pass everywhere.
12+ if not line.startswith('diff -Nru')]
13 self.assertEqual(result, [
14 '/!\\ Source package is a main component.',
15 '',

Subscribers

People subscribed via source and target branches