Merge lp:~robru/cupstream2distro/begin-xenial-overlay into lp:cupstream2distro

Proposed by Robert Bruce Park on 2016-04-11
Status: Merged
Approved by: Łukasz Zemczak on 2016-04-11
Approved revision: 1390
Merged at revision: 1390
Proposed branch: lp:~robru/cupstream2distro/begin-xenial-overlay
Merge into: lp:cupstream2distro
Diff against target: 25 lines (+2/-2)
2 files modified
cupstream2distro/silomanager.py (+1/-1)
tests/unit/test_silomanager.py (+1/-1)
To merge this branch: bzr merge lp:~robru/cupstream2distro/begin-xenial-overlay
Reviewer Review Type Date Requested Status
Łukasz Zemczak 2016-04-11 Approve on 2016-04-11
Review via email: mp+291547@code.launchpad.net

Commit Message

Send both xenial & vivid in dual silos to overlay PPA.

To post a comment you must log in.
Łukasz Zemczak (sil2100) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cupstream2distro/silomanager.py'
2--- cupstream2distro/silomanager.py 2016-03-28 21:32:25 +0000
3+++ cupstream2distro/silomanager.py 2016-04-11 20:01:11 +0000
4@@ -455,7 +455,7 @@
5 def dest(self):
6 """Return launchpadlib object representing the destination archive."""
7 series = self._series
8- if series == 'vivid':
9+ if 'vivid' in series: # matches 'vivid' and 'xenial+vivid'
10 return self.stable_overlay
11 if self._dest and '+' not in series:
12 return lp.get_ppa(self._dest)
13
14=== modified file 'tests/unit/test_silomanager.py'
15--- tests/unit/test_silomanager.py 2016-03-28 21:32:25 +0000
16+++ tests/unit/test_silomanager.py 2016-04-11 20:01:11 +0000
17@@ -608,7 +608,7 @@
18 dest='ignored', distribution='robruntu', series='xenial+vivid')
19 robruntu = Mock()
20 lp_mock.distributions = dict(robruntu=robruntu)
21- self.assertEqual(self.state.dest, robruntu.main_archive)
22+ self.assertEqual(self.state.dest, lp_mock.get_ppa.return_value)
23
24 @patch('cupstream2distro.silomanager.lp')
25 def test_silostate_dest_ppa(self, lp_mock):

Subscribers

People subscribed via source and target branches