Merge lp:~robru/cupstream2distro/absolute-paths-in-watch-ppa into lp:cupstream2distro

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 795
Merged at revision: 794
Proposed branch: lp:~robru/cupstream2distro/absolute-paths-in-watch-ppa
Merge into: lp:cupstream2distro
Diff against target: 26 lines (+7/-1)
1 file modified
cupstream2distro/packageinppa.py (+7/-1)
To merge this branch: bzr merge lp:~robru/cupstream2distro/absolute-paths-in-watch-ppa
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Bruce Park (community) Approve
Review via email: mp+240329@code.launchpad.net

Commit message

Use an absolute path in PackageInPPA class to avoid buggy chdir sloppiness. (LP: 1387819)

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

I tested this branch in preprod and was not able to reproduce the bug either with a normal build nor a WATCH_ONLY.

review: Approve
795. By Robert Bruce Park

Simplify a bit.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:795
http://jenkins.qa.ubuntu.com/job/cu2d-choo-choo-ci/246/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/cu2d-choo-choo-ci/246/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cupstream2distro/packageinppa.py'
2--- cupstream2distro/packageinppa.py 2014-10-20 23:06:35 +0000
3+++ cupstream2distro/packageinppa.py 2014-10-31 20:10:41 +0000
4@@ -23,6 +23,9 @@
5
6 import packagemanager
7
8+from cupstream2distro.settings import SILOS_DIR
9+from cupstream2distro.utils import env, log_value_of
10+
11
12 class PackageInPPA():
13
14@@ -47,8 +50,11 @@
15
16 # Get archs we should look at
17 version_for_source_file = version.split(':')[-1]
18- dsc_filename = "{}_{}.dsc".format(source_name, version_for_source_file)
19+ dsc_filename = os.path.join(
20+ SILOS_DIR, env.SILONAME, '{}_{}.dsc'.format(
21+ source_name, version_for_source_file))
22 regexp = re.compile("^Architecture: (.*)\n")
23+ log_value_of.dsc_filename()
24 for line in open(dsc_filename):
25 arch_lists = regexp.findall(line)
26 if arch_lists:

Subscribers

People subscribed via source and target branches