Merge lp:~robru/cordova-ubuntu-tests/drop-unity-autopilot into lp:cordova-ubuntu-tests

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 28
Merged at revision: 29
Proposed branch: lp:~robru/cordova-ubuntu-tests/drop-unity-autopilot
Merge into: lp:cordova-ubuntu-tests
Diff against target: 11 lines (+0/-1)
1 file modified
debian/control (+0/-1)
To merge this branch: bzr merge lp:~robru/cordova-ubuntu-tests/drop-unity-autopilot
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+194046@code.launchpad.net

Commit message

Drop unity-autopilot dependency.

Description of the change

unity-autopilot brings in a lot of unnecessary desktop components, like compiz-core and other things that are hilariously inappropriate on a phone.

Does anybody know why this dependency was added in the first place? I just tried running our autopilot tests on the phone without it and only got 2 failures.

I *guess* that it was added because we really depend on some component that unity-autopilot brings in. If anybody can identify what that component might be, I'll add it directly. Otherwise, we need to land this as-is, because unity-autopilot is simply not a correct dependency of cordova-ubuntu-autopilot.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
VĂ­ctor R. Ruiz (vrruiz) wrote :

Hi Robert. I was testing yesterday the package without the unity-autopilot dependency installed, apparently it's not needed, but I want to be sure.

Revision history for this message
Robert Bruce Park (robru) wrote :

Victor, agreed. I did see 2 failures when i tested this, but i didn't look closely, and i didn't check if the failures were resolved by installing unity-autopilot. I can dig a bit deeper into this today and we'll see where it goes.

Revision history for this message
Robert Bruce Park (robru) wrote :

Still testing this. The failures I get seem to be related to an inability to create files?

http://paste.ubuntu.com/6372030/

Revision history for this message
Robert Bruce Park (robru) wrote :

In fact, installing unity-autopilot didn't cause these tests to pass, so I'm going to go ahead and approve this. I'm pretty sure it's not necessary at this point.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-10-15 17:03:13 +0000
3+++ debian/control 2013-11-06 01:39:53 +0000
4@@ -26,7 +26,6 @@
5 Depends: cordova-ubuntu-2.8,
6 cordova-ubuntu-tests,
7 libautopilot-qt,
8- unity-autopilot,
9 dpkg-dev,
10 ${misc:Depends},
11 ${python:Depends},

Subscribers

People subscribed via source and target branches