Merge lp:~robru/bileto/fix-url-stability into lp:bileto

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 222
Merged at revision: 220
Proposed branch: lp:~robru/bileto/fix-url-stability
Merge into: lp:bileto
Diff against target: 24 lines (+1/-2)
2 files modified
tickets/static/app.js (+0/-1)
tickets/static/index.html (+1/-1)
To merge this branch: bzr merge lp:~robru/bileto/fix-url-stability
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Bruce Park (community) Approve
Review via email: mp+267911@code.launchpad.net

Commit message

Stop clearing URL params at page load time.

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

Looks good in staging.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tickets/static/app.js'
2--- tickets/static/app.js 2015-08-12 21:29:22 +0000
3+++ tickets/static/app.js 2015-08-13 07:36:22 +0000
4@@ -196,7 +196,6 @@
5
6 $scope.searchstring = $location.search().search;
7 $scope.$watch('searchstring', function(searchstring) {
8- $location.url($location.path());
9 $location.search('search', searchstring);
10 });
11
12
13=== modified file 'tickets/static/index.html'
14--- tickets/static/index.html 2015-08-12 21:07:26 +0000
15+++ tickets/static/index.html 2015-08-13 07:36:22 +0000
16@@ -35,7 +35,7 @@
17 <li><a ng-click="search('Abandoned')">Abandoned</a></li>
18 <li><a target="_blank" href="/static/dashboard.html">Dashboard</a></li>
19 <li>
20-<form ng-submit="refresh()">
21+<form ng-submit="search(searchstring)">
22 <input type="search" class="search" placeholder="Search..." ng-model="searchstring" />
23 <input type="submit" style="display: none" />
24 </form>

Subscribers

People subscribed via source and target branches