Merge ~robertliu/snappy-hwe-snaps/+git/pulseaudio:unset-xdg_runtime_dir into ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master

[Robert Liu]

snapd now exports XDG_RUNTIME_DIR for each snap. for PulseAudio which runs in system mode, the XDR_RUNTIME_DIR will be /run/user/0/pulseaudio.snap. However, to create '/run/user/0' is not allowed.

Dec 22 06:43:55 localhost kernel: [ 66.505522] audit: type=1400 audit(1482389035.822:21): apparmor="DENIED" operation="mkdir" profile="snap.pulseaudio.pactl" name="/run/user/0/" pid=1793 comm="pactl" requested_mask="c" denied_mask="c" fsuid=0 ouid=0

I propose that lets unset XDG_RUNTIME_DIR and PulseAudio will fallback to use the home directory (/root/snap/pulseaudio/[rev])

[Simon Fels (morphis)]

LGTM. Triggered CI at https://jenkins.canonical.com/system-enablement/job/generic-build-snap/581/

review: Approve

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:91d1d7b3d23e45bfda5376a14a4291eee6f65420
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/581/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/310/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/489/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/581/rebuild

review: Needs Fixing (continuous-integration)

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:91d1d7b3d23e45bfda5376a14a4291eee6f65420
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/586/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/314/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/494/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/586/rebuild

review: Needs Fixing (continuous-integration)

[Simon Fels (morphis)]

Can you rebase on top of master? CI issues are fixed in master now.

3be07bd... by Robert Liu on 2017-01-13

Merge branch 'master' of git+ssh://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio into unset-xdg_runtime_dir

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:3be07bdd54653fe80a45887cedacdf1608072a7f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/632/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/352
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/540/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/632/rebuild

review: Approve (continuous-integration)

Unmerged commits

3be07bd... by Robert Liu on 2017-01-13

Merge branch 'master' of git+ssh://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio into unset-xdg_runtime_dir

91d1d7b... by Robert Liu on 2016-12-22

Unset XDG_RUNTIME_DIR and let PulseAudio fallback to HOME

diff --git a/bin/pactl b/bin/pactl
index 97e23b2..f39f21b 100755
--- a/bin/pactl
+++ b/bin/pactl
@@ -23,6 +23,8 @@ export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$SNAP/usr/lib/pulseaudio:$SNAP/usr/lib/p
 export PULSE_CLIENTCONFIG=$SNAP/etc/pulse/client.conf
 export HOME=$SNAP_DATA/home
 
+unset XDG_RUNTIME_DIR
+
 mkdir -p $HOME
 
 $SNAP/usr/bin/pactl $@
diff --git a/bin/paplay b/bin/paplay
index a132d51..eb759c9 100755
--- a/bin/paplay
+++ b/bin/paplay
@@ -23,6 +23,8 @@ export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$SNAP/usr/lib/pulseaudio:$SNAP/usr/lib/p
 export PULSE_CLIENTCONFIG=$SNAP/etc/pulse/client.conf
 export HOME=$SNAP_DATA/home
 
+unset XDG_RUNTIME_DIR
+
 mkdir -p $HOME
 
 $SNAP/usr/bin/paplay $@
diff --git a/bin/parec b/bin/parec
index 269e0f8..ea78b35 100755
--- a/bin/parec
+++ b/bin/parec
@@ -23,6 +23,8 @@ export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$SNAP/usr/lib/pulseaudio:$SNAP/usr/lib/p
 export PULSE_CLIENTCONFIG=$SNAP/etc/pulse/client.conf
 export HOME=$SNAP_DATA/home
 
+unset XDG_RUNTIME_DIR
+
 mkdir -p $HOME
 
 $SNAP/usr/bin/parec $@