Merge ~robertliu/snappy-hwe-snaps/+git/pulseaudio:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master
Status: | Merged |
---|---|
Approved by: | Jim Hodapp |
Approved revision: | e697cdd85a8e8d12e590fa10dcef9d6d3177a776 |
Merged at revision: | 5ba21e4d3ce2d3fed46a73fcf9f69abacb682104 |
Proposed branch: | ~robertliu/snappy-hwe-snaps/+git/pulseaudio:master |
Merge into: | ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master |
Diff against target: |
102 lines (+54/-7) 2 files modified
bin/pulseaudio (+4/-1) snapcraft.yaml (+50/-6) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jim Hodapp (community) | code | Approve | |
System Enablement Bot | continuous-integration | Needs Fixing | |
Simon Fels | Approve | ||
Review via email: mp+311561@code.launchpad.net |
This proposal supersedes a proposal from 2016-11-23.
Description of the change
When using the original pulseaudio snap on Intel NUC, pulseaudio only listed the analog output but not HDMI audio port. After some debugging, I found libasound2 has several hard-coded path variables. These modifications are used to change the paths in libasound2-data.
1. Import alsa-lib_
2. Modify alsa-lib to use the SNAP environment variable when getting the data directory
3. Add a new parts in snapcraft.yaml for alsa-lib
4. Only pack necessary files in the snap
Also export more variables in bin/pulseaudio.
This needs rebase or merge now that https:/ /code.launchpad .net/~jhodapp/ snappy- hwe-snaps/ +git/fix- pulseaudio- slots-plugs/ +merge/ 309604 is merged. Leaving detailed review up to Jim.