Merge lp:~robertcarr/unity-mir/update-to-not-use-configure-output into lp:unity-mir

Proposed by Robert Carr
Status: Merged
Approved by: Michael Terry
Approved revision: 166
Merged at revision: 200
Proposed branch: lp:~robertcarr/unity-mir/update-to-not-use-configure-output
Merge into: lp:unity-mir
Prerequisite: lp:~mterry/unity-mir/drop-dbusscreen
Diff against target: 27 lines (+3/-8)
1 file modified
src/unity-mir/displayconfigurationpolicy.cpp (+3/-8)
To merge this branch: bzr merge lp:~robertcarr/unity-mir/update-to-not-use-configure-output
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+209565@code.launchpad.net

Commit message

configure_output has been dropped in mir devel, update to the new API. Depends on drop dbusscreen.

Description of the change

configure_output has been dropped in mir devel, update to the new API. Depends on drop dbusscreen.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity-mir/displayconfigurationpolicy.cpp'
2--- src/unity-mir/displayconfigurationpolicy.cpp 2014-02-12 00:23:17 +0000
3+++ src/unity-mir/displayconfigurationpolicy.cpp 2014-03-06 00:15:42 +0000
4@@ -37,7 +37,7 @@
5
6 base_policy->apply_to(conf);
7 conf.for_each_output(
8- [&](mg::DisplayConfigurationOutput const& conf_output)
9+ [&](mg::UserDisplayConfigurationOutput& conf_output)
10 {
11 if (!conf_output.connected || !conf_output.used) return;
12
13@@ -52,12 +52,7 @@
14 // keep the default settings if nothing was found
15 if (format == conf_output.pixel_formats.end())
16 return;
17-
18- conf.configure_output(conf_output.id, true, conf_output.top_left,
19- conf_output.current_mode_index,
20- *format,
21- conf_output.power_mode,
22- conf_output.orientation
23- );
24+
25+ conf_output.current_format = *format;
26 });
27 }

Subscribers

People subscribed via source and target branches