lp:~robertcarr/mir/surface-shell-data

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

Alan Griffiths: Disapprove on 2014-02-19

Daniel van Vugt: Disapprove on 2014-02-19

Kevin DuBois (community): Needs Fixing on 2014-02-19

PS Jenkins bot (community): Approve (continuous-integration) on 2014-02-18

Gerry Boland: Pending requested 2014-02-18

Diff: 249 lines (+111/-2)

11 files modified

include/server/mir/compositor/compositing_criteria.h (+4/-0)
include/server/mir/shell/surface.h (+5/-0)
include/test/mir_test_doubles/mock_compositing_criteria.h (+1/-0)
include/test/mir_test_doubles/stub_compositing_criteria.h (+5/-0)
src/server/scene/basic_surface.cpp (+10/-0)
src/server/scene/basic_surface.h (+4/-0)
src/server/scene/surface_data.cpp (+38/-2)
src/server/scene/surface_data.h (+9/-0)
src/server/scene/surface_impl.cpp (+10/-0)
src/server/scene/surface_impl.h (+3/-0)
tests/unit-tests/scene/test_surface_data.cpp (+22/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1406. By Robert Carr on 2014-02-18

Add shell_data storage to shell surface interface for assosciation to shell side surface object.

1405. By Daniel van Vugt on 2014-02-18

Remember to set field "current_format" when sending a display config to the
server. Until now it had been left uninitialized, which resulted in an
invalid display config on the server (LP: #1277343)

A test case did exist for this kind of thing, but the test case itself was
buggy and never updated to check the relatively new field "current_format". Fixes: https://bugs.launchpad.net/bugs/1277343.

Approved by Alan Griffiths, Alexandros Frantzis, PS Jenkins bot.

1404. By Alberto Aguirre on 2014-02-18

Fix crash in android devices by working around a subtle threading bug

Use a dummy thead_local array to push the gl/egl context TLS into a region
where the future wait code does not overwrite it.

Other changes:
- Query the preferred read pixel format/type at setup.
- Write a video file instead of snapshot files; the raw file can then be played as a video with vlc

fixes: lp: #1280086. Fixes: https://bugs.launchpad.net/bugs/1280086.

Approved by PS Jenkins bot, Alexandros Frantzis.

1403. By Chris Halse Rogers on 2014-02-18

Sundry improvements to mir::udev.

Approved by PS Jenkins bot, Daniel van Vugt.

1402. By Alan Griffiths on 2014-02-18

compositor: calling SwitchingBundle::force_requests_to_complete() can be a no-op when there are no requests. Fixes: https://bugs.launchpad.net/bugs/1281145.

Approved by PS Jenkins bot, Daniel van Vugt.

1401. By Alexandros Frantzis on 2014-02-18

tests: Don't emit an "add" uevent manually when adding a device
(LP: #1281146)

The latest version (0.6) of umockdev emits such "add" uevents itself. Fixes: https://bugs.launchpad.net/bugs/1281146.

Approved by Daniel van Vugt, PS Jenkins bot.

1400. By Daniel van Vugt on 2014-02-17

Move Renderer rotation out of the begin() method and into set_rotation().

It's conceivable you won't want to change the rotation angle on every frame,
so now you don't have to. Also, this makes GLRenderer::begin() nice and
trivial again.
.

Approved by Alberto Aguirre, Alan Griffiths, PS Jenkins bot.

1399. By Alan Griffiths on 2014-02-15

config: reduce size of default RPC thread pool. Fixes: https://bugs.launchpad.net/bugs/1233001.

Approved by PS Jenkins bot, Daniel van Vugt, kevin gunn, Kevin DuBois.

1398. By Alan Griffiths on 2014-02-14

compositor: non-blocking implementation of SwitchingBundle::client_acquire. Fixes: https://bugs.launchpad.net/bugs/1267323.

Approved by PS Jenkins bot, Alexandros Frantzis, Andreas Pokorny, Kevin DuBois.

1397. By Daniel van Vugt on 2014-02-14

Move Renderer viewport setup out of the constructor and into a separate
function, where it can be changed without having to reconstruct the whole
Renderer.

This will be useful in future in cases such as:
  * Non-destructive display config changes that will avoid reconstructing
    DisplayBuffers (and compositors, and renderers :)
  * Viewport dimensions morphing during a screen rotation animation.
.

Approved by Alexandros Frantzis, PS Jenkins bot, Daniel van Vugt, Kevin DuBois, Alan Griffiths.