Mir

Code review comment for lp:~robertcarr/mir/receive-input-in-client

  1. receive-input-in-client
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

321 InputMessage msg;
322 + memset(&msg, 0, sizeof(InputMessage));
...
330 InputMessage msg;
331 + memset(&msg, 0, sizeof(InputMessage));
...
339 InputMessage msg;
340 + memset(&msg, 0, sizeof(InputMessage));

Wouldn't a default constructor be less repetitive?

~~~~

Why is "MirEventDelegate const *event_handler" a separate parameter and not a member of MirSurfaceParameters?

~~~~

"Should the event handler type take MirSurface as the first argument? ... ubuntu_platform_api uses no Surface as the first argument and delegate attached to surface (or rather two argument callback, context). Maybe we should just work this way?"

review: Needs Information

« Back to merge proposal