Code review comment for lp:~robert-kern/ipython/pretty

On Sat, Mar 14, 2009 at 6:24 PM, Robert Kern
<email address hidden> wrote:
> On Sat, Mar 14, 2009 at 19:34, Fernando Perez <email address hidden> wrote:
>> Review: Needs Fixing
>> A few comments.  This is great, but our extensions setup right now is a mess, see my email on list.  Why don't you modify it to wrap the activation hook into a
>>
>> def load():
>>   ....
>>
>> method for now, and we can change the API later in trunk if we come to a different naming convention.
>
> Done as activate(). We need a way to unset hooks in order to implement
> deactivate().
>
>> I'd also suggest putting your numpy prettyprinter as real code, instead of in-docstring, so that users can just load it themselves from your extension.
>
> Done.

Thanks!

>> Finally, can you provide some doctests?  While currently the main iptest script skips extensions (too many of them break dangerously if loaded), they can be manually tested via
>
> I have not been able to get this to work. I get 0 tests with your
> example. Anyways, the doctestable docstring is there.

Cool. You may need my trunk-dev for that to work though, there's a
lot of work on the testing machinery I've done there.

I have to run now, I'll return to this tomorrow...

In the meantime, if anyone has a chance to look at the other branches
pending review, that would be great :)