Merge lp:~robert-ancell/update-manager/ua-updates-api into lp:update-manager

[Robert Ancell]

Use uaclient library instead of calling ua tool directly. This simplifies parsing errors. The API is blocking however, so we hold up the UI.

[Sebastien Bacher (seb128)]

Thanks, makes sense, that's what the pro client team suggested using, it would also have avoided the recently issue when the parsing wasn't working anymore due to them changing one of the key names

review: Approve

[Kiwinote (kiwinote)]

Hi there - just wanted to let you know that this change might have caused a regression in update-manager as described at https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/2008280 - if you're able to take a quick look that would be much appreciated - thanks!

=== modified file 'UpdateManager/UpdateManager.py'
--- UpdateManager/UpdateManager.py	2022-10-17 06:26:07 +0000
+++ UpdateManager/UpdateManager.py	2023-01-19 23:22:09 +0000
@@ -36,12 +36,12 @@
 
 import distro_info
 import fnmatch
-import json
 import os
 import subprocess
 import sys
 import time
 from gettext import gettext as _
+from uaclient.api.u.pro.packages.updates.v1 import updates
 
 import dbus
 import dbus.service
@@ -272,24 +272,10 @@
 
     def _get_ua_security_status(self):
         self.ua_security_packages = []
-        try:
-            p = subprocess.Popen(['ua', 'security-status', '--format=json'],
-                                 stdout=subprocess.PIPE)
-        except OSError:
-            pass
-        else:
-            while p.poll() is None:
-                while Gtk.events_pending():
-                    Gtk.main_iteration()
-                time.sleep(0.05)
-            s = json.load(p.stdout)
-            for package in s.get('packages', []):
-                status = package.get('status', '')
-                if status == 'pending_attach':
-                    name = package.get('name', '')
-                    version = package.get('version', '')
-                    size = package.get('download_size', 0)
-                    self.ua_security_packages.append((name, version, size))
+        update_result = updates()
+        for info in update_result.updates:
+            if info.status == 'pending_attach':
+                self.ua_security_packages.append((info.name, info.version, info.download_size))
 
     def _make_available_pane(self, install_count, need_reboot=False,
                              cancelled_update=False, error_occurred=False):