Merge lp:~robert-ancell/unity-greeter/double-authenticate into lp:unity-greeter

[Robert Ancell]

Fix the greeter authenticating twice when it starts.

This was due to it authenticating when the user list is created and then again when it is realized.
This is due to faulty code that needs to start the animation once the widget is realized.
I've hacked this by waiting for the realize for the first authenticate (since the realize must always occur in this case).
The existing code was buggy anyway because it would not even pick up user changes if the initial list was empty.

This bug was discovered by hitting a race condition in LightDM where the two sessions started in quick succession would cause the terminate of the first session to get misinterpreted and stopping the daemon.

While we now correctly handle this in the daemon we should fix the greeter to only authenticate once as there could potentially be other side-effects.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1157
http://jenkins.qa.ubuntu.com/job/unity-greeter-ci/38/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-greeter-trusty-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-greeter-trusty-armhf-ci/21

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-greeter-ci/38/rebuild

review: Approve (continuous-integration)

[Michael Terry (mterry)]

Looks good to me.

review: Approve

=== modified file 'src/greeter-list.vala'
--- src/greeter-list.vala	2014-01-15 20:53:05 +0000
+++ src/greeter-list.vala	2014-03-12 03:23:15 +0000
@@ -685,6 +685,7 @@
     {
         base.realize ();
 
+        /* NOTE: This is going to cause the entry_selected signal to be emitted even if selected_entry has not changed */
         var saved_entry = selected_entry;
         selected_entry = null;
         select_entry (saved_entry, 1, start_scrolling);

=== modified file 'src/user-list.vala'
--- src/user-list.vala	2013-10-21 20:06:10 +0000
+++ src/user-list.vala	2014-03-12 03:23:15 +0000
@@ -116,11 +116,7 @@
 
         fill_list ();
 
-        if (selected_entry != null)
-        {
-            entry_selected.connect (entry_selected_cb);
-            entry_selected_cb (selected_entry.id);
-        }
+        entry_selected.connect (entry_selected_cb);
 
         connect_to_lightdm ();