Unity Control Center

Merge lp:~robert-ancell/unity-control-center/ui-scale-keyboard into lp:unity-control-center

  1. ui-scale-keyboard
  2. Merge into trunk
Proposed by Robert Ancell
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 12766
Merged at revision: 12766
Proposed branch: lp:~robert-ancell/unity-control-center/ui-scale-keyboard
Merge into: lp:unity-control-center
Diff against target: 31 lines (+5/-2)
1 file modified
panels/display/cc-display-panel.c (+5/-2)
To merge this branch: bzr merge lp:~robert-ancell/unity-control-center/ui-scale-keyboard
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+212525@code.launchpad.net

Commit message

Allow the UI scale to be controlled by the keyboard

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:12766
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/87/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-amd64-ci/87
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-armhf-ci/87
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-trusty-i386-ci/88

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/87/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks good, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panels/display/cc-display-panel.c'
2--- panels/display/cc-display-panel.c 2014-02-26 15:58:33 +0000
3+++ panels/display/cc-display-panel.c 2014-03-24 23:19:46 +0000
4@@ -67,6 +67,8 @@
5
6 #define UI_SCALE_MIN 4.0
7 #define UI_SCALE_MAX 32.0
8+#define UI_SCALE_STEP 1.0
9+#define UI_SCALE_DEFAULT 8.0
10
11 enum {
12 TEXT_COL,
13@@ -602,15 +604,16 @@
14 return;
15 }
16
17+ gtk_adjustment_set_step_increment (adj, UI_SCALE_STEP);
18 gtk_adjustment_set_upper (adj, UI_SCALE_MAX);
19 gtk_adjustment_set_lower (adj, UI_SCALE_MIN);
20 gtk_scale_set_digits (GTK_SCALE(self->priv->ui_scale), 0);
21- gtk_scale_add_mark (GTK_SCALE(self->priv->ui_scale), 8, GTK_POS_TOP, NULL);
22+ gtk_scale_add_mark (GTK_SCALE(self->priv->ui_scale), UI_SCALE_DEFAULT, GTK_POS_TOP, NULL);
23
24 dict = g_settings_get_value (self->priv->desktop_settings, "scale-factor");
25 if (!g_variant_lookup (dict, monitor_name, "i", &value))
26 {
27- value = 8;
28+ value = UI_SCALE_DEFAULT;
29 self->priv->ui_prev_scale = value;
30 }
31 new_dict = add_dict_entry (dict, monitor_name, value);

Subscribers

People subscribed via source and target branches